Change in ovirt-engine[master]: core: remove always true condition
by masayag@redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: remove always true condition
......................................................................
core: remove always true condition
remove part of condition that is always true - it's not necessary
Change-Id: If59dc05ce11172c351bc238dc10ffce715600c22
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10980
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If59dc05ce11172c351bc238dc10ffce715600c22
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: RestoreAllSnapshots partial cleanup
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RestoreAllSnapshots partial cleanup
......................................................................
core: RestoreAllSnapshots partial cleanup
- Replace the class member 'targetSnapshot' with local field.
- Change the type of deleteDisksIds from List to Set, which is more
appropriate (as it should contain every value at most once), and
it improves the performance of the loop in #deleteOrphanedImages.
- Change the type of 'snapshotsToRemove' member from List to Set,
instead of ensuring that it doesn't contain any value more than once
when inserting to it.
Change-Id: I0557a832915e00877f9d1ee79e4cf2d429537396
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
1 file changed, 16 insertions(+), 19 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10855
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0557a832915e00877f9d1ee79e4cf2d429537396
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: fix logging and mispelling in few classes
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: fix logging and mispelling in few classes
......................................................................
core: fix logging and mispelling in few classes
1.Fix mispelling of comment
2.Rephrase logging message
3.Log exception in error instead of debug
4.Getting the correct logger of same class in PasswordValueHelper
5.Not log same exception twice as error and debug, instead have one
unified logging in error for both message and corresponding exception
Change-Id: I1da28578bec13daa58e19081d78f6dbb07f264ca
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskUtils.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java
7 files changed, 12 insertions(+), 18 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1da28578bec13daa58e19081d78f6dbb07f264ca
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: packaging: engine-setup - Add option to generate passwords
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: engine-setup - Add option to generate passwords
......................................................................
packaging: engine-setup - Add option to generate passwords
Adds a new option to engine-setup: --generate-passwords.
Using this option will allow administrators to run engine-setup in
answer-file mode, so engine will ignore the passwords in the file, and
will generates passwords of it's own, later can be changed via
engine-config/postgres/configuration files.
Change-Id: Ib1e8cfec87e908d8aa5f8d73db91b9c8b02480e1
Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com>
---
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/common_utils.py
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/output_messages.py
4 files changed, 38 insertions(+), 1 deletion(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10681
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1e8cfec87e908d8aa5f8d73db91b9c8b02480e1
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: packaging: engine-setup - add firewalld support
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: engine-setup - add firewalld support
......................................................................
packaging: engine-setup - add firewalld support
Add firewalld support for ovirt-engine-setup.
If the user will ask setup to handle firewalld, the setup will open
needed ports (JBoss ports + NFS) in all firewalld zones.
Change-Id: Ieea93c90ffb90e02b880949a67575495aac5a472
Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com>
---
M Makefile
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/common_utils.py
M packaging/fedora/setup/engine-setup.py
A packaging/fedora/setup/engine_firewalld.py
A packaging/fedora/setup/firewalld.ovirt.xml
M packaging/fedora/setup/output_messages.py
M packaging/fedora/spec/ovirt-engine.spec.in
8 files changed, 155 insertions(+), 29 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieea93c90ffb90e02b880949a67575495aac5a472
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: engine: A check for possible NPE in RemoveExternalEventComma...
by asaf@redhat.com
Asaf Shakarchi has submitted this change and it was merged.
Change subject: engine: A check for possible NPE in RemoveExternalEventCommand.canDoAction
......................................................................
engine: A check for possible NPE in RemoveExternalEventCommand.canDoAction
Added a check for possible NPE in RemoveExternalEventCommand.canDoAction
method.
Change-Id: I64014addc38828506d6d04c63dabdbab555f1481
Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Asaf Shakarchi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64014addc38828506d6d04c63dabdbab555f1481
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: add toString method to VM and VDS
by lhornyak@redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: add toString method to VM and VDS
......................................................................
core: add toString method to VM and VDS
Added toString methods to display the names of the entities for easier
debuging.
Change-Id: I7cd449b18c6187d00366e2c30d4288c909a9ef6a
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
2 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7640
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cd449b18c6187d00366e2c30d4288c909a9ef6a
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 11 months
Change in ovirt-engine[master]: storage: revert change to RhevhLocalFSPath
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: storage: revert change to RhevhLocalFSPath
......................................................................
storage: revert change to RhevhLocalFSPath
This revert a change to RhevhLocalFSPath in change I3fa85dd89.
It was wrongly tied to deployment process.
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=893920
Change-Id: Ie152f713d503f3fb1f172517abfdcdd70a766021
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10965
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie152f713d503f3fb1f172517abfdcdd70a766021
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: webadmin: Change running vm column
by alkaplan@redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: Change running vm column
......................................................................
webadmin: Change running vm column
Change the "running vm" column in main tab Host to "Virtual Machines"
(counting total number of VMs on the host)
Change-Id: I19d06e11a2db1dd70471999064dc0480f81c0e17
Bug-Url: https://bugzilla.redhat.com/890823
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10968
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19d06e11a2db1dd70471999064dc0480f81c0e17
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: fixes to RecoveryStoragePool command
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: fixes to RecoveryStoragePool command
......................................................................
core: fixes to RecoveryStoragePool command
This patch handles the following issues:
1. automatic engine timers and different commands might trigger automated
reconstruct, currently the event queue leave only vds connect operations
in the queue after a run of reconstruct whether it was succesfull or
not, causing to a situation in which a user cannot initiate
RecoveryStoragePool command because of reconstruct operations initiated
by automatic system procedures.
2. race condition/stale data: data loaded within the
canDoAction() run might have been changed and can be irrelevant
during the reconstruct execution - therefore the data need to be
reloaded and candoaction should be checked again.
3. The newly domain that should be added as master, should be added to
the db after we performed connect operation to it - otherwise it might
be chosen by different reconstruct as a master domain, but we don't have
storage server connection to it.
4. recoveryStoragePool used to perform reconstruct operation after the
storage pool status is set to Problematic- changed it back to run
reconstruct with the pool set to this status (previous logic).
Change-Id: I9423d880a7d10a5bfa917e415fe41651f9d7e7f1
Bug-Url: https://bugzilla.redhat.com/888259
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/eventqueue/EventType.java
3 files changed, 46 insertions(+), 37 deletions(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit http://gerrit.ovirt.org/10549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9423d880a7d10a5bfa917e415fe41651f9d7e7f1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months