Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Remove vNIC items changed listener before flush
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Remove vNIC items changed listener before flush
......................................................................
webadmin: Remove vNIC items changed listener before flush
Upon flushing the AddRemoveRowWidget, it sets the backing ListModel's
items according to the entries in the widget. However, in the add/edit
VM dialog, since it is listening on the items changed event, this
re-initializes the widget just before it closes, thus adding a new
vNIC row. This patch moves the listening logic into
ProfilesInstanceTypeEditor and removes the listener prior to flushing
the widget, in order to avoid that flicker.
Change-Id: I5f153a3b19e467d41131015c7e2819c3ce365c22
Bug-Url: https://bugzilla.redhat.com/1020755
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
2 files changed, 38 insertions(+), 17 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20658
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f153a3b19e467d41131015c7e2819c3ce365c22
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Allow different options for different entries
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Allow different options for different entries
......................................................................
webadmin: Allow different options for different entries
ListModelListBoxCell used to have one set of options for all of the
entries. Now it only sets the options in the last minute, when a
specific entry is rendered, according to the items in the ListModel
backing the specific entry, which enables to have different options
for different entries.
Change-Id: I703ab631ef959fa3ca3ad5bb6dd878634993a3b2
Bug-Url: https://bugzilla.redhat.com/989909
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ListModelListBoxCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/ListModelListBoxColumn.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java
4 files changed, 8 insertions(+), 44 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20604
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I703ab631ef959fa3ca3ad5bb6dd878634993a3b2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: build: use own temp directory and preferences for gwt
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: build: use own temp directory and preferences for gwt
......................................................................
build: use own temp directory and preferences for gwt
during build, gwt generates a lots of files into temp directory which
not always cleaned up.
best to generate these at own project directory so once project is
cleaned up these will also be cleaned up.
to avoid conflicts with other running instances, set java preferences
location to be in temp directory as well.
Change-Id: If2551534ccf0c181fdd755c64e11328ad24b47b2
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M frontend/webadmin/modules/pom.xml
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2551534ccf0c181fdd755c64e11328ad24b47b2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: Don't log unsynchronized unmanaged networks
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Don't log unsynchronized unmanaged networks
......................................................................
engine: Don't log unsynchronized unmanaged networks
If the network is not synchronized, it should be logged only if it's
managed. Otherwise, it's of no interest to us.
Change-Id: I7b8a582134f5c9d37d64bcd5970f2f3bfb24ab20
Bug-Url: https://bugzilla.redhat.com/1023705
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20581
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b8a582134f5c9d37d64bcd5970f2f3bfb24ab20
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3.1]: core: empty quota causes FK violation
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: empty quota causes FK violation
......................................................................
core: empty quota causes FK violation
When creating a disk in Foreman, the disk object is sent via
REST with empty string in id attribute:
<quota id=""/>
REST creates an empty UUID (000...) out of empty string, and causes
FK violation, since there is no quota with that id.
This patch fixes it by ignoring empty quota for adding disk.
Change-Id: Ic488486edc7c5602d24e804c9a89aeccc98fc32b
Bug-Url: https://bugzilla.redhat.com/1022942
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Itamar Heim: Verified; Looks good to me, approved
Gilad Chaplik: Verified
--
To view, visit http://gerrit.ovirt.org/20702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic488486edc7c5602d24e804c9a89aeccc98fc32b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3.1
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[master]: webadmin: Rendered checkbox headers resizeable
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Rendered checkbox headers resizeable
......................................................................
webadmin: Rendered checkbox headers resizeable
Previously, CheckboxHeader wasn't resizeable. Created a class
ResizeableCheckboxHeader to fix this, a wrapper for CheckboxHeader
that inherits from ResizableHeader (classic case for multiple
inheritance, but used composition due to Java limitations).
A CheckboxHeader is automatically wrapped with a
ResizeableCheckboxHeader when it is added to a ColumnResizeCellTable
that has column resizing enabled, as in such a case it would be
expected that the checkbox headers are resizeable as well.
Change-Id: Ie442350893282e7838e5216d277718e654f1d884
Bug-Url: https://bugzilla.redhat.com/1009745
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/SafeHtmlCellWithTooltip.java
R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/CheckboxHeader.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/ResizeableCheckboxHeader.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ColumnResizeCellTable.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/resize/ResizableHeader.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java
8 files changed, 67 insertions(+), 13 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie442350893282e7838e5216d277718e654f1d884
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine[ovirt-engine-3.3]: core: empty quota causes FK violation
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: empty quota causes FK violation
......................................................................
core: empty quota causes FK violation
When creating a disk in Foreman, the disk object is sent via
REST with empty string in id attribute:
<quota id=""/>
REST creates an empty UUID (000...) out of empty string, and causes
FK violation, since there is no quota with that id.
This patch fixes it by ignoring empty quota for adding disk.
Change-Id: Ic488486edc7c5602d24e804c9a89aeccc98fc32b
Bug-Url: https://bugzilla.redhat.com/1022942
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20499
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic488486edc7c5602d24e804c9a89aeccc98fc32b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 6 months
Change in ovirt-engine-sdk-java[sdk_3.3]: sdk: release 1.0.0.19-1
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: release 1.0.0.19-1
......................................................................
sdk: release 1.0.0.19-1
Change-Id: I39a5dd4ac945649badcec311a4f8630856fd5401
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java/Makefile
M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in
M ovirt-engine-sdk-java/pom.xml
3 files changed, 12 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20693
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I39a5dd4ac945649badcec311a4f8630856fd5401
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.3
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
10 years, 6 months
Change in ovirt-engine-sdk-java[sdk_3.3]: sdk: regenerate against the latest api
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: regenerate against the latest api
......................................................................
sdk: regenerate against the latest api
- to host.install() added ssh related arguments
- to template added virtio_scsi.enabled
- to vm added virtio_scsi.enabled
- added ability to attach a disk snapshot to the virtual machine
- to File class added 'content' field
- Payload class now reuses Files instead of own PayloadFile collection
Change-Id: If0ea500890f41d3bf58508a720cb183b7a6eb890
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Template.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Templates.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Disk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/File.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Payload.java
D ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/PayloadFile.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Template.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VM.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VirtIOSCSI.java
14 files changed, 313 insertions(+), 186 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20692
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0ea500890f41d3bf58508a720cb183b7a6eb890
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.3
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
10 years, 6 months
Change in ovirt-engine-sdk-java[master]: sdk: regenerate against the latest api
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: regenerate against the latest api
......................................................................
sdk: regenerate against the latest api
- to host.install() added ssh related arguments
- to template added virtio_scsi.enabled
- to vm added virtio_scsi.enabled
- added ability to attach a disk snapshot to the virtual machine
- to File class added 'content' field
- Payload class now reuses Files instead of own PayloadFile collection
Change-Id: If0ea500890f41d3bf58508a720cb183b7a6eb890
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Host.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Template.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Templates.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VM.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMDisks.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Disk.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/File.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/ObjectFactory.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Payload.java
D ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/PayloadFile.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/Template.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VM.java
A ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/entities/VirtIOSCSI.java
14 files changed, 313 insertions(+), 186 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20691
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0ea500890f41d3bf58508a720cb183b7a6eb890
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
10 years, 6 months