October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-reports[master]: packaging: setup: fixed log jar location
by ydary＠redhat.com 13 Oct '13

13 Oct '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fixed log jar location ...................................................................... packaging: setup: fixed log jar location Fix for F19 as priority and F18 as fallback. Change-Id: I09032b12b5cd4f3fe4820aa9541eb654d07b4e15 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 19 insertions(+), 6 deletions(-) Approvals: Alex Lourie: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09032b12b5cd4f3fe4820aa9541eb654d07b4e15 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use pin to host only when present in cluster policy
by dfediuck＠redhat.com 13 Oct '13

13 Oct '13

Doron Fediuck has submitted this change and it was merged. Change subject: core: Use pin to host only when present in cluster policy ...................................................................... core: Use pin to host only when present in cluster policy This removes the explicit pin to host check in scheduling. The check is already present in cluster policy and will be used when the policy unit is selected by the administrator. It also restores the optimization we had in the code that used Pin To Host logic as the first filter for the provided cluster policies. Change-Id: If2c0496327c9f692b0dbe92e1cf481f900f4a747 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007282 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties A packaging/dbscripts/upgrade/03_03_0990_pin_to_host_first_in_powersaving_policy.sql 3 files changed, 8 insertions(+), 28 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2c0496327c9f692b0dbe92e1cf481f900f4a747 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Allow vlan to serve as a migration network
by masayag＠redhat.com 13 Oct '13

13 Oct '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Allow vlan to serve as a migration network ...................................................................... engine: Allow vlan to serve as a migration network In order for a nic device to be entitled to serve as the underlying interface for a migration network, it should be UP. The nics statuses are reported by the getVdsStats verb of VDSM which doesn't report it for vlan devices. Therefore, until the statistics will be collected for vlans, we'll allow migration to go over the vlan if its underlying nic is UP. Change-Id: Icdfcca442d40d8f2c3b6b28dc9f520e286b7e8f2 Bug-Url: https://bugzilla.redhat.com/1014013 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdfcca442d40d8f2c3b6b28dc9f520e286b7e8f2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: update formatter conf to java version 1.7
by amureini＠redhat.com 13 Oct '13

13 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: engine: update formatter conf to java version 1.7 ...................................................................... engine: update formatter conf to java version 1.7 Update engine code formatter configuration file settings to format according to java 1.7 instead of 1.5. Change-Id: If15ff59ec2711ac43fa16b40f8cc31c08992c681 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M config/engine-code-format.xml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If15ff59ec2711ac43fa16b40f8cc31c08992c681 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: set action/type in FenceVdsManualyCommand
by amureini＠redhat.com 13 Oct '13

13 Oct '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: set action/type in FenceVdsManualyCommand ...................................................................... core: set action/type in FenceVdsManualyCommand Set action and type in setActionMessageParameters so it will be properly resolved. Change-Id: I89bbd039d683e6b95b5ce930f3bae195414283d1 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89bbd039d683e6b95b5ce930f3bae195414283d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: Corrected the status values
by ofrenkel＠redhat.com 13 Oct '13

13 Oct '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: Corrected the status values ...................................................................... gluster: Corrected the status values VDSM returns as IN_PROGRESS and NOT_STARTED for the tasks which are in progress and not started yet respectively. Corrected the same in engine code. Change-Id: Iaa2b66a2f11270d5b02accded8f8fd74c226ccfe Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/gluster/GlusterAsyncTaskStatus.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19866 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa2b66a2f11270d5b02accded8f8fd74c226ccfe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: restapi: Start VM not as RunOnce
by iheim＠redhat.com 13 Oct '13

13 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Start VM not as RunOnce ...................................................................... restapi: Start VM not as RunOnce The BackendVmResource.start issued RunVmOnce command even if none additional parameters were provided. Now we check if a Vm is passed in the Action and if not, we issue regular RunVmCommand. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1005562 Change-Id: I40be200c8742d8b31b7881926c59deaf345992ec Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmResourceTest.java 2 files changed, 28 insertions(+), 8 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40be200c8742d8b31b7881926c59deaf345992ec Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Added InfoIcon for "public" profile checkbox
by iheim＠redhat.com 13 Oct '13

13 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Added InfoIcon for "public" profile checkbox ...................................................................... webadmin: Added InfoIcon for "public" profile checkbox In the add/edit VM dialog, the "public" checkbox in the profiles tab isn't explained, added an InfoIcon for it. Change-Id: I244fbe01be7df305af837aff3ec6c09beec4e36b Bug-Url: https://bugzilla.redhat.com/1000804 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.ui.xml 3 files changed, 26 insertions(+), 9 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I244fbe01be7df305af837aff3ec6c09beec4e36b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Create default profile when changing to VM network
by iheim＠redhat.com 13 Oct '13

13 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Create default profile when changing to VM network ...................................................................... webadmin: Create default profile when changing to VM network When a network is switched from VM to non-VM, its associated profiles are removed. When switching from non-VM to VM, a default profile is now created again in the GUI. Change-Id: Ia6764a5d99a9471e6ae07f31ab8552d41b1c28f6 Bug-Url: https://bugzilla.redhat.com/1007279 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java 3 files changed, 27 insertions(+), 25 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6764a5d99a9471e6ae07f31ab8552d41b1c28f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Display default vNIC profile in tab
by iheim＠redhat.com 13 Oct '13

13 Oct '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Display default vNIC profile in tab ...................................................................... webadmin: Display default vNIC profile in tab The user currently has no way of knowing we're intending to create this profile, so now by default it's shown in the list of profiles to be created for a network being added. Change-Id: Iaa7b46a5cfd262bfdb9915993af0a1e524362055 Bug-Url: https://bugzilla.redhat.com/1000801 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/EditVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 4 files changed, 59 insertions(+), 35 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa7b46a5cfd262bfdb9915993af0a1e524362055 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0