October 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix PinToHostPolicyUnit when PinToHost is enabled
by gchaplik＠redhat.com 10 Oct '13

10 Oct '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix PinToHostPolicyUnit when PinToHost is enabled ...................................................................... core: Fix PinToHostPolicyUnit when PinToHost is enabled We have to return an empty list of available hosts when PinToHost is enabled and the pinned Host was already filtered out. Otherwise the whole PolicyUnit has no effect. This is fixing one issue out of two that caused the referenced bug. The issues are independent on each other and so I did want to preserve the history. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1007282 Change-Id: Id5a49813d433a10debe607f17783057d7d4a767b Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PinToHostPolicyUnit.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19786 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5a49813d433a10debe607f17783057d7d4a767b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : Fixed rebalance status esc key issue
by kmayilsa＠redhat.com 10 Oct '13

10 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Fixed rebalance status esc key issue ...................................................................... webadmin : Fixed rebalance status esc key issue When esc key was pressed to close the status popup it used to open the close confirm window.Now,it is fixed. Change-Id: If6fe38c3be05a49b4697310031ec4e64b725b45c Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20005 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6fe38c3be05a49b4697310031ec4e64b725b45c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : Rebalance stop error handling
by kmayilsa＠redhat.com 10 Oct '13

10 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : Rebalance stop error handling ...................................................................... webadmin : Rebalance stop error handling If rebalance stop fails, rebalance status was still triggered. Now,it has been corrected and only a error message is shown. Change-Id: I02f434c3b83db286fae9f01956018a7edca2a736 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I02f434c3b83db286fae9f01956018a7edca2a736 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin : rebalance status pop up resizing
by kmayilsa＠redhat.com 10 Oct '13

10 Oct '13

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : rebalance status pop up resizing ...................................................................... webadmin : rebalance status pop up resizing rebalance status pop up resizing Change-Id: I34038e11aee30552b8529fc6dfb092b2ac4ccfc8 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.ui.xml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34038e11aee30552b8529fc6dfb092b2ac4ccfc8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Fixed profiles explanation constant
by lvernia＠redhat.com 10 Oct '13

10 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fixed profiles explanation constant ...................................................................... webadmin: Fixed profiles explanation constant Accidentally used a constant that wasn't quite right for the info icon when I just added it. Change-Id: Ic835428d4a0090ee25b536fc8d59752235fdaa12 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic835428d4a0090ee25b536fc8d59752235fdaa12 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Create default profile when changing to VM network
by lvernia＠redhat.com 10 Oct '13

10 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Create default profile when changing to VM network ...................................................................... webadmin: Create default profile when changing to VM network When a network is switched from VM to non-VM, its associated profiles are removed. When switching from non-VM to VM, a default profile is now created again in the GUI. Change-Id: Ia6764a5d99a9471e6ae07f31ab8552d41b1c28f6 Bug-Url: https://bugzilla.redhat.com/1007279 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java 3 files changed, 27 insertions(+), 25 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19902 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6764a5d99a9471e6ae07f31ab8552d41b1c28f6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Display default vNIC profile in tab
by lvernia＠redhat.com 10 Oct '13

10 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Display default vNIC profile in tab ...................................................................... webadmin: Display default vNIC profile in tab The user currently has no way of knowing we're intending to create this profile, so now by default it's shown in the list of profiles to be created for a network being added. Change-Id: Iaa7b46a5cfd262bfdb9915993af0a1e524362055 Bug-Url: https://bugzilla.redhat.com/1000801 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/EditVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 4 files changed, 59 insertions(+), 35 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa7b46a5cfd262bfdb9915993af0a1e524362055 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Hide profiles tab if network is non-VM
by lvernia＠redhat.com 10 Oct '13

10 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Hide profiles tab if network is non-VM ...................................................................... webadmin: Hide profiles tab if network is non-VM A non-VM network cannot have profiles associated with it, so the profiles tab of the add/edit network dialog is now hidden whenever the VM network checkbox isn't marked. If the network is non-VM, then whatever's in the (hidden) profiles tab is ignored. Change-Id: I0cb1d77310a88c58d89b997e6fb7a974d06b009e Bug-Url: https://bugzilla.redhat.com/1007286 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java 3 files changed, 22 insertions(+), 4 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cb1d77310a88c58d89b997e6fb7a974d06b009e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Removed unused constructor
by lvernia＠redhat.com 10 Oct '13

10 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Removed unused constructor ...................................................................... webadmin: Removed unused constructor Presumably added before there was a split between NewVnicProfileModel and EditVnicProfileModel, and was forgotten afterwards. Change-Id: I0a35ed37a445a1251fad427b01d133c857e8c316 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a35ed37a445a1251fad427b01d133c857e8c316 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Added InfoIcon for "public" profile checkbox
by lvernia＠redhat.com 10 Oct '13

10 Oct '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Added InfoIcon for "public" profile checkbox ...................................................................... webadmin: Added InfoIcon for "public" profile checkbox In the add/edit VM dialog, the "public" checkbox in the profiles tab isn't explained, added an InfoIcon for it. Change-Id: I244fbe01be7df305af837aff3ec6c09beec4e36b Bug-Url: https://bugzilla.redhat.com/1000804 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.ui.xml 2 files changed, 23 insertions(+), 9 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/20081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I244fbe01be7df305af837aff3ec6c09beec4e36b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0