November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: frontend: null checks
by tjelinek＠redhat.com 29 Nov '13

29 Nov '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: null checks ...................................................................... frontend: null checks added null checks to ConsoleModelsCache and MainTabBasicDetailsPresenterWidget Change-Id: I770e0ec23d59643f37b5f8be93a7565c47a3d006 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java 2 files changed, 9 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/21870 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I770e0ec23d59643f37b5f8be93a7565c47a3d006 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Console code refactor and cleanup
by tjelinek＠redhat.com 29 Nov '13

29 Nov '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Console code refactor and cleanup ...................................................................... frontend: Console code refactor and cleanup Purpose of this patch - remove duplicated console code - minor refactoring of consoles - make the code ready for simultaneous SPICE + VNC consoles. major changes: - introduced interface VmConsoles (+ implementations) that allows relative simple access and control over consoles of a single vm (selecting active console model, connecting to console, reading state). This class should be used for any manipulation with consoles of a VM. - concept of 'DefaultConsoleModel' and 'AdditionalConsoleModel' is thrown away. instead frontend remembers VmConsoles implementation for every vm. - most utils classes deleted in favor of VmConsoles - removed ConsoleManager - used for connecting to console, replaced by VmConsoles - reduced ConsoleUtils - now it only contains wrapper methods to wrap Configurator. It should contain only methods that do not need actual vm/console state - removed UserSelectedDisplayProtocolManager (switching between SPICE/VNC and RDP), in favor of VmConsoles - simplified ConsoleModelsCache - removed HasConsoleModel interface in favor of VmConsoles - removed ConsoleSelectionContext class since if someone wants to query console state, VmConsoles should provide fresh data to them - renamed IUserPortalListModel to AbstractUserPortalListModel since it's not interface but abstract class - removed WebAdminItemModel in favor of VmConsoles Change-Id: Ie6d7cb5e457410e0e76a12f6602b44132cb913c9 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseUtilsModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleManagerImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleOptionsFrontendPersister.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsolePopupModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/HasConsoleModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/VmConsoles.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/VmConsolesImpl.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IVmPoolResolutionService.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/PoolItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserSelectedDisplayProtocolManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleSelectionContext.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RdpConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WebAdminItemModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/AbstractUserPortalListProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/utils/ConnectAutomaticallyManager.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/ConsoleButtonCell.java 40 files changed, 790 insertions(+), 1,567 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/21488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6d7cb5e457410e0e76a12f6602b44132cb913c9 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Change timeout on apache proxy configuration
by iheim＠redhat.com 29 Nov '13

29 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: setup: Change timeout on apache proxy configuration ...................................................................... packaging: setup: Change timeout on apache proxy configuration Increased the timeout to wait for response so that the UI does not respond with 500 errors Change-Id: I0c0c75a8c29c0a22e86a8ad648ab956f30468552 Bug-Url: https://bugzilla.redhat.com/1025869 Bug-Url: https://bugzilla.redhat.com/1035622 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M packaging/conf/ovirt-engine-proxy.conf.v2.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21818 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c0c75a8c29c0a22e86a8ad648ab956f30468552 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[ovirt-3.3.1]: packaging: changed version to 3.3.2 beta
by ydary＠redhat.com 29 Nov '13

29 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed version to 3.3.2 beta ...................................................................... packaging: changed version to 3.3.2 beta Change-Id: I89aa930240aba519cf6b4661bf6c279f44244e85 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/context_files/ovirt_engine_dwh/minimalversioncheck_3_3/contexts/Default.properties M data-warehouse/history_etl/context_files/ovirt_engine_dwh/parallelrun_3_3/contexts/Default.properties M data-warehouse/history_etl/etl_sources/advancedPersistentLookupLib/pom.xml M data-warehouse/history_etl/etl_sources/historyETLProcedure/pom.xml M data-warehouse/history_etl/etl_sources/packaging/pom.xml M data-warehouse/history_etl/etl_sources/pom.xml M data-warehouse/history_etl/etl_sources/talendRoutines/pom.xml M data-warehouse/history_etl/pom.xml M data-warehouse/history_etl/tos_project/context/connectionJDBC_3.3.item M data-warehouse/history_etl/tos_project/process/MinimalVersionCheck_3.3.item M data-warehouse/history_etl/tos_project/process/ParallelRun_3.3.item M data-warehouse/historydbscripts_postgres/upgrade/pre_upgrade/set_etl_minimal_version.sql M data-warehouse/pom.xml M pom.xml M version.mak 15 files changed, 21 insertions(+), 21 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89aa930240aba519cf6b4661bf6c279f44244e85 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[ovirt-3.3.1]: packaging: changed minor version to 3.3.2
by ydary＠redhat.com 29 Nov '13

29 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: changed minor version to 3.3.2 ...................................................................... packaging: changed minor version to 3.3.2 Change-Id: I996e185df3bffc566188cae4c65912c6579a666f Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-reports.spec.in M pom.xml M reports/jars/ChartsCustomizers/pom.xml M reports/jars/CustomOvirtReportsQueryManipulator/pom.xml M reports/jars/EngineAuthentication/pom.xml M reports/jars/ReportsLineBarChartTheme/pom.xml M reports/jars/ReportsPieChartTheme/pom.xml M reports/jars/WebadminLineBarChartTheme/pom.xml M reports/jars/pom.xml M reports/pom.xml M version.mak 11 files changed, 19 insertions(+), 19 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21861 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I996e185df3bffc566188cae4c65912c6579a666f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[ovirt-3.3.1]: reports: fixed br18 os detection
by ydary＠redhat.com 29 Nov '13

29 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed br18 os detection ...................................................................... reports: fixed br18 os detection Change-Id: Ib893baa54e5cbb31b3ccbd9b632d0cdcc6434965 Bug-Url: https://bugzilla.redhat.com/1031612 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Executive/active_vms_by_os_br18_files/active_vms_by_os_br18_jrxml.data 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib893baa54e5cbb31b3ccbd9b632d0cdcc6434965 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[ovirt-3.3.1]: packaging: fixed set of admin password in portal
by ydary＠redhat.com 29 Nov '13

29 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed set of admin password in portal ...................................................................... packaging: fixed set of admin password in portal Change-Id: I1789ed34b2648ec58b4c7304b950acdd3fe21ea1 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1789ed34b2648ec58b4c7304b950acdd3fe21ea1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[ovirt-3.3.1]: reports: moved favicon to theme
by ydary＠redhat.com 29 Nov '13

29 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: moved favicon to theme ...................................................................... reports: moved favicon to theme Change-Id: I9a498d86b7f3d75274f52dfabfe3904455408923 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/.folder.xml R reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/favicon.ico.data A reports/repository_files/resources/themes/ovirt-002dreports-002dtheme/images/favicon.ico.xml 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a498d86b7f3d75274f52dfabfe3904455408923 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3.1 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: fixed br18 os detection
by ydary＠redhat.com 29 Nov '13

29 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: fixed br18 os detection ...................................................................... reports: fixed br18 os detection Change-Id: Ib893baa54e5cbb31b3ccbd9b632d0cdcc6434965 Bug-Url: https://bugzilla.redhat.com/1031612 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M reports/repository_files/resources/Reports/Executive/active_vms_by_os_br18_files/active_vms_by_os_br18_jrxml.data 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib893baa54e5cbb31b3ccbd9b632d0cdcc6434965 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: postgres provision: generate only ASCII pa...
by sbonazzo＠redhat.com 29 Nov '13

29 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: postgres provision: generate only ASCII password ...................................................................... packaging: setup: postgres provision: generate only ASCII password python string module is locale aware, so generating letter in non unicode locale will result non unicode password, unreadable by java. instead of using the string module, use hardcoded known good characters. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1035932 Change-Id: I1b27d8eb26c777617ff3bf625b979a75bc3225c6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/provisioning/postgres.py 1 file changed, 7 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21852 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b27d8eb26c777617ff3bf625b979a75bc3225c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0