November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove mockStorageGuidList
by amureini＠redhat.com 27 Nov '13

27 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove mockStorageGuidList ...................................................................... core: Remove mockStorageGuidList CommonVmPoolWithVmsCommandTestAbstract.mockStorageGuidList(List<StorageDomain>) is unused and should thus be removed. Change-Id: I40b6f7514349a2f9888871a4a1301669332ae373 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21668 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40b6f7514349a2f9888871a4a1301669332ae373 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Rm GetDiskAlignmentCommand.serialVersionUUID
by amureini＠redhat.com 27 Nov '13

27 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Rm GetDiskAlignmentCommand.serialVersionUUID ...................................................................... core: Rm GetDiskAlignmentCommand.serialVersionUUID Since commands are no longer Serializable, there is not point in having a serivalVersionUUID in GetDiskAlignmentCommand. Change-Id: I96eea341ec3ee054972da41aa1029d398ca8d390 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96eea341ec3ee054972da41aa1029d398ca8d390 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused TagsHandler methods
by amureini＠redhat.com 27 Nov '13

27 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused TagsHandler methods ...................................................................... core: Remove unused TagsHandler methods Change-Id: I01e44ce5e7f71f8c2c32d1dbf8969e8c50824966 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsHandler.java 1 file changed, 0 insertions(+), 41 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01e44ce5e7f71f8c2c32d1dbf8969e8c50824966 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm RemoveVmHibernationVolumeCommand consts
by amureini＠redhat.com 27 Nov '13

27 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm RemoveVmHibernationVolumeCommand consts ...................................................................... core: rm RemoveVmHibernationVolumeCommand consts Removed constants that were migrated to VmCommand and left here by mistake. Change-Id: I375c632bae106683d783b5e7b081a00c83ac34f5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmHibernationVolumesCommand.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I375c632bae106683d783b5e7b081a00c83ac34f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused QueryData.type property
by amureini＠redhat.com 27 Nov '13

27 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused QueryData.type property ...................................................................... core: Remove unused QueryData.type property This property is saved in the object but never used afterwards, therefore it's redundant and should be removed. This patch removes the property, its getter, and the constructor argument that initializes it. Change-Id: I4b6cb8d9d94862fc2b66fdb1031835c4ed222f2a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueryData.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java 2 files changed, 1 insertion(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b6cb8d9d94862fc2b66fdb1031835c4ed222f2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: remove HandlersFactory.createVmPoolHandler
by amureini＠redhat.com 27 Nov '13

27 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: remove HandlersFactory.createVmPoolHandler ...................................................................... core: remove HandlersFactory.createVmPoolHandler Remove unused method. Change-Id: I5033305edcf4bc1b18ef69596b9079d0ad080a61 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandlersFactory.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5033305edcf4bc1b18ef69596b9079d0ad080a61 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: GetDiskAlignmentCommand.getStorageDomainDao
by amureini＠redhat.com 27 Nov '13

27 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: GetDiskAlignmentCommand.getStorageDomainDao ...................................................................... core: GetDiskAlignmentCommand.getStorageDomainDao Removed the unused GetDiskAlignmentCommand.getStorageDomainDao() method. Change-Id: I4f2879420a5bc268660d91412bde104a0b70d4dc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21670 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f2879420a5bc268660d91412bde104a0b70d4dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove unused interface Scorable
by amureini＠redhat.com 27 Nov '13

27 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused interface Scorable ...................................................................... core: Remove unused interface Scorable Change-Id: Iee297de0bdd2c07ff784acc2bd5b32e59da2435c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/Scorable.java 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee297de0bdd2c07ff784acc2bd5b32e59da2435c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm unused class WindowsErrorsTranslationMap
by amureini＠redhat.com 27 Nov '13

27 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm unused class WindowsErrorsTranslationMap ...................................................................... core: rm unused class WindowsErrorsTranslationMap Change-Id: If2a185c9c5154427cd50231141a3c38585dfaf0e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/WindowsErrorsTranslationMap.java 1 file changed, 0 insertions(+), 20 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2a185c9c5154427cd50231141a3c38585dfaf0e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: rm VmTemplateHandler.MarkVmTemplateAsIllegal
by amureini＠redhat.com 27 Nov '13

27 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm VmTemplateHandler.MarkVmTemplateAsIllegal ...................................................................... core: rm VmTemplateHandler.MarkVmTemplateAsIllegal This method was unused and should thus be removed. Change-Id: I50680cfe4b0e9dfe908f95f0297ee38cdd1ea83e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateHandler.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21676 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50680cfe4b0e9dfe908f95f0297ee38cdd1ea83e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0