November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Check if balloon device is present in stalled ballon c...
by gchaplik＠redhat.com 27 Nov '13

27 Nov '13

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Check if balloon device is present in stalled ballon check ...................................................................... core: Check if balloon device is present in stalled ballon check Check for stalled balloon (inflated but uncontrolable) accesses balloon data. That might cause Null pointer exception when the device is not there or we do not have all needed information. Change-Id: Ie9074fc67913e3c5ad9ad81744bfe4de27a19636 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1035297 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9074fc67913e3c5ad9ad81744bfe4de27a19636 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: version in feedback url.
by ecohen＠redhat.com 27 Nov '13

27 Nov '13

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: version in feedback url. ...................................................................... webadmin: version in feedback url. - Added the ability to specify the version of ovirt in the feedback url. - Added version retrieval to get the configuration from the cache. - Renamed getRpmVersionFromPublic to be non public. Change-Id: Ib7f4305ff1e3bd30aa13f1ba381186cf9e910c71 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/DynamicMessages.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AboutPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/AboutPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java M packaging/branding/ovirt.brand/external_resources.properties 6 files changed, 38 insertions(+), 22 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7f4305ff1e3bd30aa13f1ba381186cf9e910c71 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fixed error in VdsNetworkInterface.equals()
by lvernia＠redhat.com 27 Nov '13

27 Nov '13

Lior Vernia has submitted this change and it was merged. Change subject: core: Fixed error in VdsNetworkInterface.equals() ...................................................................... core: Fixed error in VdsNetworkInterface.equals() Seems like the network name wasn't in fact checked as intended; the check as it's currently implemented should always return false. Change-Id: I441ad028fc72815479966ef6befd9f925fa3f293 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21780 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I441ad028fc72815479966ef6befd9f925fa3f293 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Ignore temporary tables exists in engine database
by ofrenkel＠redhat.com 27 Nov '13

27 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: Ignore temporary tables exists in engine database ...................................................................... core: Ignore temporary tables exists in engine database Ignore temporary tables exists in engine database upon upgrade. Change-Id: I3664a60e1e97e52875882864995e41f3776f7fcd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1034929 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/db/schema.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21768 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3664a60e1e97e52875882864995e41f3776f7fcd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tomáš Došek <tdosek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: packaging: Do not overwrite 10-setup-database.conf if not re...
by sbonazzo＠redhat.com 27 Nov '13

27 Nov '13

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: Do not overwrite 10-setup-database.conf if not required ...................................................................... packaging: Do not overwrite 10-setup-database.conf if not required Without this change, engine-backup --mode=restore and without --change-db-credentials will empty 10-setup-database.conf . Bug-Url: https://bugzilla.redhat.com/1002401 Change-Id: I5b2e4d0e291e8c5a8afabd7d8cca29f289154b0a Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b2e4d0e291e8c5a8afabd7d8cca29f289154b0a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-reports[master]: packaging: fixed set of admin password in portal
by ydary＠redhat.com 27 Nov '13

27 Nov '13

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed set of admin password in portal ...................................................................... packaging: fixed set of admin password in portal Change-Id: I1789ed34b2648ec58b4c7304b950acdd3fe21ea1 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M packaging/ovirt-engine-reports-setup.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alex Lourie: Looks good to me, but someone else must approve Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1789ed34b2648ec58b4c7304b950acdd3fe21ea1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-hosted-engine-ha[master]: Consider engine to be safe and sound when the state is Running
by dfediuck＠redhat.com 27 Nov '13

27 Nov '13

Doron Fediuck has submitted this change and it was merged. Change subject: Consider engine to be safe and sound when the state is Running ...................................................................... Consider engine to be safe and sound when the state is Running VDSM should not return this state at all according to it's API documentation. But it does. Running is returned when VM is Up and the guest agent is running. Change-Id: I51507f1ed3c642280b600ee512f4bcc8d5b9bb88 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1034787 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/broker/submonitors/engine_health.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified Greg Padgett: Looks good to me, but someone else must approve Doron Fediuck: Looks good to me, approved Pablo Iranzo Gómez: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51507f1ed3c642280b600ee512f4bcc8d5b9bb88 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Pablo Iranzo Gómez <Pablo.Iranzo(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Improve exception handling in broker's request processing
by dfediuck＠redhat.com 27 Nov '13

27 Nov '13

Doron Fediuck has submitted this change and it was merged. Change subject: Improve exception handling in broker's request processing ...................................................................... Improve exception handling in broker's request processing When non-fatal exception occurs, try to recover first before stopping the service mainloop. Change-Id: I55c5252991b8d428ca64c125b211f974cdaca08b Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M ovirt_hosted_engine_ha/broker/listener.py 1 file changed, 25 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21510 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55c5252991b8d428ca64c125b211f974cdaca08b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: Save local maintenance flag to shared block in metadata
by dfediuck＠redhat.com 27 Nov '13

27 Nov '13

Doron Fediuck has submitted this change and it was merged. Change subject: Save local maintenance flag to shared block in metadata ...................................................................... Save local maintenance flag to shared block in metadata Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1034321 Change-Id: Idaf478c3973bd094a928005c5ea98a4e4fb5159d Signed-off-by: Martin Sivak <mars(a)montik.net> --- M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/lib/metadata.py 2 files changed, 21 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Verified Greg Padgett: Looks good to me, but someone else must approve Doron Fediuck: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idaf478c3973bd094a928005c5ea98a4e4fb5159d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: bad keys in osinfo props
by iheim＠redhat.com 27 Nov '13

27 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: bad keys in osinfo props ...................................................................... core: bad keys in osinfo props Change-Id: I8a0170bc33b4aa261743eb361ece5aa8da10180c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1032652 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M packaging/conf/osinfo-defaults.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21626 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a0170bc33b4aa261743eb361ece5aa8da10180c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0