November 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: event names partially overlap in "manage events" d...

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: event names partially overlap in "manage events" dialog ...................................................................... webadmin: event names partially overlap in "manage events" dialog event names partially overlap in "manage events" dialog Change-Id: I5d5b2cbd644615491cf1cf8a7470158f78d5c046 Bug-Url: https://bugzilla.redhat.com/974837 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/css/NotificationsTree.css 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Ravi Nori: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d5b2cbd644615491cf1cf8a7470158f78d5c046 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fix search validation of OSs

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: fix search validation of OSs ...................................................................... core: fix search validation of OSs the UI is validating the input for OSs and was mistakenly lower casing each input. this created a corner case where and os unique name with that had capital letters, windows_2008_R2 was not a valid input for search. its a false assumption to make that all osinfo unique os name are case sensitive ATM and no point in trying to refactor that. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003804 Change-Id: I818dd4eead46402d1fb6a832786020a5458c533d Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleter.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleterTest.java 2 files changed, 46 insertions(+), 11 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21707 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I818dd4eead46402d1fb6a832786020a5458c533d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: fix search validation of OSs

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix search validation of OSs ...................................................................... core: fix search validation of OSs the UI is validating the input for OSs and was mistakenly lower casing each input. this created a corner case where and os unique name with that had capital letters, windows_2008_R2 was not a valid input for search. its a false assumption to make that all osinfo unique os name are case sensitive ATM and no point in trying to refactor that. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003804 Change-Id: I818dd4eead46402d1fb6a832786020a5458c533d Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleter.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleterTest.java 2 files changed, 46 insertions(+), 11 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I818dd4eead46402d1fb6a832786020a5458c533d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: frontend: delete unused class Clipboard

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: frontend: delete unused class Clipboard ...................................................................... frontend: delete unused class Clipboard Change-Id: I92c16db5e0da4bc1829964217909f240f1bdebff Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- D frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Clipboard.java 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92c16db5e0da4bc1829964217909f240f1bdebff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: VMs tab heading "Time executing" truncated in display

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: VMs tab heading "Time executing" truncated in display ...................................................................... webadmin: VMs tab heading "Time executing" truncated in display In es_ES locale the VMs tab column header "Time Executing" is truncated. The column width is too small to accomodate the text. Change-Id: I69d8f94931693600431a2a3fc998c9581cb2a5b2 Bug-Url: https://bugzilla.redhat.com/1009757 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69d8f94931693600431a2a3fc998c9581cb2a5b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: tools: Validate TimeZone values in engine-config

by rgolan＠redhat.com

Roy Golan has submitted this change and it was merged. Change subject: tools: Validate TimeZone values in engine-config ...................................................................... tools: Validate TimeZone values in engine-config Added validation for DefaultWindowsTimeZone and DefaultGeneralTimeZone keys. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=989396 Change-Id: I78c056128f1fcd607e9baa882e24544c99ad7cd2 Signed-off-by: Martin Betak <mbetak(a)redhat.com> --- A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/BaseTimeZoneValueHelper.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/GeneralTimeZoneValueHelper.java A backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/WindowsTimeZoneValueHelper.java M packaging/etc/engine-config/engine-config.properties 4 files changed, 85 insertions(+), 2 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20501 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78c056128f1fcd607e9baa882e24544c99ad7cd2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Add validate-on-match to data source

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: Add validate-on-match to data source ...................................................................... core: Add validate-on-match to data source Since JBoss EAP 6.1 connection level validation isn't performed unless the "validate-on-match" parameter is explicitly set to true. This causes several issues like connections not being removed from the connection pool when the database is restarted. This patch adds that parameter to the data source configuration. Change-Id: I8f43be1cd95597dbc75ffb6a873a1b1e312c3897 Bug-Url: https://bugzilla.redhat.com/1024990 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/services/ovirt-engine/ovirt-engine.xml.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f43be1cd95597dbc75ffb6a873a1b1e312c3897 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Prevent usage of shareable disks on Gluster domains

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: Prevent usage of shareable disks on Gluster domains ...................................................................... core: Prevent usage of shareable disks on Gluster domains To avoid risk of split brain on Gluster domains this patch prevents the creation of shareable disks on Gluster domains as well as the update of existing disks to shareable. Also on creation of a new Gluster domain via webadmin there a message that tells to use Quorum on the Gluster server to ensure data integrity Change-Id: I6d741c93d32fa568c1d1f10429cb325a9b01c359 Bug-Url: https://bugzilla.redhat.com/1024654 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/GlusterStorageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/GlusterStorageView.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 12 files changed, 99 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d741c93d32fa568c1d1f10429cb325a9b01c359 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: fix Edit Role dialog layout

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: fix Edit Role dialog layout ...................................................................... webadmin: fix Edit Role dialog layout "Edit Role" dialog layout has several issues Change-Id: Ib73c20096b537ad06168b7402d74a19f74188a91 Bug-Url: https://bugzilla.redhat.com/1025203 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml 1 file changed, 42 insertions(+), 11 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib73c20096b537ad06168b7402d74a19f74188a91 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: task tree doesn't refresh after logout

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: task tree doesn't refresh after logout ...................................................................... webadmin: task tree doesn't refresh after logout Resubscribing to items change event. Change-Id: I26bbcd28bd024b9124e7b0e5a293baf72ff7eab1 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/TaskModelProvider.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/AlertsEventsFooterView.java 2 files changed, 28 insertions(+), 11 deletions(-) Approvals: Kanagaraj M: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26bbcd28bd024b9124e7b0e5a293baf72ff7eab1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2013