November 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: userportal, webadmin: workaround for Firefox favicon bug

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: userportal, webadmin: workaround for Firefox favicon bug ...................................................................... userportal, webadmin: workaround for Firefox favicon bug Workaround for Firefox bug https://bugzilla.mozilla.org/show_bug.cgi?id=519028, 'change location.hash leads to location bar icon (favicon) disappearance.' The symptom is that the favicon disappears in Firefox on the initial hashchange when logging in. The workaround is to simply detach and re-attach the favicon link element on hashchange by overriding ApplicationPlaceManager.onValueChange, and only in Firefox by checking the user-agent. Change-Id: Ia4b0d8a0176eb9299aec01ae6772297409ef3108 Bug-Url: https://bugzilla.redhat.com/999436 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/branding/src/main/resources/META-INF/tags/obrand/favicon.tag M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/place/UserPortalPlaceManager.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/WebAdminPlaceManager.java 4 files changed, 50 insertions(+), 7 deletions(-) Approvals: Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21433 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4b0d8a0176eb9299aec01ae6772297409ef3108 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: userportal, webadmin: run favicon bug workaround in Scheduler

by vszocs＠redhat.com

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal, webadmin: run favicon bug workaround in Scheduler ...................................................................... userportal, webadmin: run favicon bug workaround in Scheduler Run the Firefox favicon bug workaround in GWT Scheduler, since GWT-P place transition implementation uses deferred commands. Change-Id: I73278382894d02970022ceef8b95d8c2f3b62ec0 Bug-Url: https://bugzilla.redhat.com/999436 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/place/ApplicationPlaceManager.java 1 file changed, 13 insertions(+), 6 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21434 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73278382894d02970022ceef8b95d8c2f3b62ec0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: gluster: Fix rebalance message to display volume name along ...

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: gluster: Fix rebalance message to display volume name along with confirmation ...................................................................... gluster: Fix rebalance message to display volume name along with confirmation Change the text as "Are you sure you want to stop the rebalance operation on the volume : <volume-name>?" Change-Id: Ic23df363c3627f9143971b6d9257f1e54b5593ba Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1021343 Signed-off-by: Timothy Asir <tjeyasin(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 3 files changed, 7 insertions(+), 11 deletions(-) Approvals: Timothy Asir: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic23df363c3627f9143971b6d9257f1e54b5593ba Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: build: ovirt-hosted-engine-setup-1.0.0-0.9.beta4

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.0.0-0.9.beta4 ...................................................................... build: ovirt-hosted-engine-setup-1.0.0-0.9.beta4 Change-Id: I672bfc268804297906a2eadd5dd4cec2cbef4b85 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 11 insertions(+), 3 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I672bfc268804297906a2eadd5dd4cec2cbef4b85 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: config broker notifications

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: config broker notifications ...................................................................... packaging: setup: config broker notifications Bug-Url: https://bugzilla.redhat.com/1030437 Bug-Url: https://bugzilla.redhat.com/1032467 Change-Id: Ib49f0534b5f8a9918558a82d40cc9828ccf87868 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/ha/Makefile.am M src/plugins/ovirt-hosted-engine-setup/ha/__init__.py A src/plugins/ovirt-hosted-engine-setup/ha/ha_notifications.py 4 files changed, 285 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib49f0534b5f8a9918558a82d40cc9828ccf87868 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Include tracebacks in QueriesCommandBase errors.

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Include tracebacks in QueriesCommandBase errors. ...................................................................... core: Include tracebacks in QueriesCommandBase errors. At present DEBUG logging is required to view a full trace of exceptions caught by the QueriesCommandBase class. These really should be present by default within the ERROR line. Change-Id: I48fa907c9e6cf7365768f90b2dd90d167114f051 Signed-off-by: Lee Yarwood <lyarwood(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java 1 file changed, 4 insertions(+), 10 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17350 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48fa907c9e6cf7365768f90b2dd90d167114f051 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin : reordered fields in rebalance status pop up

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : reordered fields in rebalance status pop up ...................................................................... webadmin : reordered fields in rebalance status pop up reordered fields in rebalance status pop up as in gluster cli. Change-Id: Ied708dd60ee7a7434cf55ad4b5f27d5579f2c318 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1023884 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21158 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ied708dd60ee7a7434cf55ad4b5f27d5579f2c318 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: config broker notifications

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: config broker notifications ...................................................................... packaging: setup: config broker notifications Bug-Url: https://bugzilla.redhat.com/1030437 Change-Id: Ib49f0534b5f8a9918558a82d40cc9828ccf87868 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/ovirt-hosted-engine-setup/ha/Makefile.am M src/plugins/ovirt-hosted-engine-setup/ha/__init__.py A src/plugins/ovirt-hosted-engine-setup/ha/ha_notifications.py 4 files changed, 285 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/21415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib49f0534b5f8a9918558a82d40cc9828ccf87868 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin : remove-brick status error handling

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin : remove-brick status error handling ...................................................................... webadmin : remove-brick status error handling Errors like, 1. If some/all the hosts forming a distribute volume with atleast 2 bricks are down, and if rebalance status is triggered on such a volume, approprite error message is displayed. 2. If any n/w related or any other exceptions are thrown,they are also handled properly. And hence the popup doesn't hang anymore. Change-Id: I57bb82ebc0318266f32262c6f9bb245e26f2ddd1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1027675 Signed-off-by: Anmol Babu <anbabu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/RemoveBrickStatusModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java 4 files changed, 58 insertions(+), 33 deletions(-) Approvals: anmolbabu: Verified Kanagaraj M: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21086 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57bb82ebc0318266f32262c6f9bb245e26f2ddd1 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: rename method in class DNS

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: rename method in class DNS ...................................................................... core: rename method in class DNS Rename to start with lowercase to solve a findbug warning Change-Id: Ib4df06aea33965a275cb20f363d15604b24a1165 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/UpdateNetworkToVdsInterfaceCommand.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/dns/Dns.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4df06aea33965a275cb20f363d15604b24a1165 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2013