Change in ovirt-engine[master]: gluster: Disable Rebalance/Remove Brick when one or more bri...
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: gluster: Disable Rebalance/Remove Brick when one or more bricks are down
......................................................................
gluster: Disable Rebalance/Remove Brick when one or more bricks are down
When one or more bricks are down in a distributed volume or one complete set
of replica pairs are down in a distribute-replicate volume, Rebalance/Remove Brick operation
should not enabled as it will anyway fail in gluster side.
Change-Id: Ib66fe531dfea6099a449fcae8c4370711ae3dd8b
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRemoveGlusterVolumeBricksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/gluster/GlusterBrickValidator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/GlusterBrickValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 183 insertions(+), 7 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Ramesh N: Verified
--
To view, visit http://gerrit.ovirt.org/19984
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib66fe531dfea6099a449fcae8c4370711ae3dd8b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: restapi: Adding details to step as statistics
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: restapi: Adding details to step as statistics
......................................................................
restapi: Adding details to step as statistics
Add detailed status information related to
external system task to Step as a Statistics
sub resource
Change-Id: Ia1f7559d5700823cd4ee0a28a826074d22679d23
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/ExternalSystemType.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StepResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractStatisticalQuery.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/StepStatisticalQuery.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/GlusterTaskStatisticalQueryTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StepMapper.java
9 files changed, 350 insertions(+), 2 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Sahina Bose: Verified
--
To view, visit http://gerrit.ovirt.org/19685
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1f7559d5700823cd4ee0a28a826074d22679d23
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: gluster: Refactored GlusterTaskSyncJob
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: gluster: Refactored GlusterTaskSyncJob
......................................................................
gluster: Refactored GlusterTaskSyncJob
Rafactored the class GlusterTaskSyncJob and moved the reusable methods
to GlusterTaskUtils class. The changes include -
1. Modified the class GlusterTaskUtils as a singleton class
2. Moved reusable code from GlusterTaskSyncJob to GlusterTaskUtils class
3. Modified the dependencies accordingly
Change-Id: I1abecae9389530324154cdc059ee717db0a61715
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRemoveGlusterVolumeBricksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java
8 files changed, 241 insertions(+), 147 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21063
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1abecae9389530324154cdc059ee717db0a61715
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine-cli[master]: cli: release 3.4.0.2-1
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: release 3.4.0.2-1
......................................................................
cli: release 3.4.0.2-1
Change-Id: I737eb7777ff5259975b4a42eac342c65da8700dc
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M Makefile
M ovirt-engine-cli.spec.in
M setup.py
3 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21286
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I737eb7777ff5259975b4a42eac342c65da8700dc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
10 years, 10 months
Change in ovirt-engine-cli[master]: cli: add missing packages in setup.py
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: add missing packages in setup.py
......................................................................
cli: add missing packages in setup.py
Change-Id: Ieb5fbe2e50a854f6fc804428fce25337607777d6
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M setup.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21285
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb5fbe2e50a854f6fc804428fce25337607777d6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
10 years, 10 months
Change in ovirt-engine[master]: core: ActiveStorageDomainCommand refactoring
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: ActiveStorageDomainCommand refactoring
......................................................................
core: ActiveStorageDomainCommand refactoring
Rearranged code in helper functions in order to reduce code duplication
Change-Id: Ib5962dab111cf2c799029081526a4344d7b15f52
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommandTest.java
1 file changed, 29 insertions(+), 25 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5962dab111cf2c799029081526a4344d7b15f52
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: preserve shmmax config on cleanup
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: packaging: setup: preserve shmmax config on cleanup
......................................................................
packaging: setup: preserve shmmax config on cleanup
Previously if you ran engine-setup; engine-cleanup; engine-setup
the final engine-setup may not properly store a persistent
configuration for shmmax in sysctl, so that a subsequent
reboot will cause postgresql to fail to come up so oVirt
is non-operational.
Now cleanup won't remove the configuration for shmmax in sysctl
just telling the user where it's placed and how to restore
default value manually. This will ensure that a working postgresql
will work also after reboot.
Change-Id: I4a95d5d9c678da80ee3f1e0a9de511309dfd4b51
Bug-Url: https://bugzilla.redhat.com/1026926
Bug-Url: https://bugzilla.redhat.com/1027605
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A packaging/setup/plugins/ovirt-engine-remove/system/__init__.py
A packaging/setup/plugins/ovirt-engine-remove/system/sysctl.py
M packaging/setup/plugins/ovirt-engine-setup/system/sysctl.py
3 files changed, 119 insertions(+), 0 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21283
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a95d5d9c678da80ee3f1e0a9de511309dfd4b51
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.3]: core: AddVM - Show an Event when exeeding the mem range
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: AddVM - Show an Event when exeeding the mem range
......................................................................
core: AddVM - Show an Event when exeeding the mem range
Change-Id: I52067ea090bb8d3b239b4dd8a6ac0b5188dbdc20
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014952
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
4 files changed, 16 insertions(+), 6 deletions(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52067ea090bb8d3b239b4dd8a6ac0b5188dbdc20
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: packaging: setup: preserve shmmax config on cleanup
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: preserve shmmax config on cleanup
......................................................................
packaging: setup: preserve shmmax config on cleanup
Previously if you ran engine-setup; engine-cleanup; engine-setup
the final engine-setup may not properly store a persistent
configuration for shmmax in sysctl, so that a subsequent
reboot will cause postgresql to fail to come up so oVirt
is non-operational.
Now cleanup won't remove the configuration for shmmax in sysctl
just telling the user where it's placed and how to restore
default value manually. This will ensure that a working postgresql
will work also after reboot.
Change-Id: I4a95d5d9c678da80ee3f1e0a9de511309dfd4b51
Bug-Url: https://bugzilla.redhat.com/1026926
Bug-Url: https://bugzilla.redhat.com/1027605
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
A packaging/setup/plugins/ovirt-engine-remove/system/__init__.py
A packaging/setup/plugins/ovirt-engine-remove/system/sysctl.py
M packaging/setup/plugins/ovirt-engine-setup/system/sysctl.py
3 files changed, 119 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21139
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a95d5d9c678da80ee3f1e0a9de511309dfd4b51
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: AddVM - Show an Event when exeeding the mem range
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: AddVM - Show an Event when exeeding the mem range
......................................................................
core: AddVM - Show an Event when exeeding the mem range
Change-Id: I52067ea090bb8d3b239b4dd8a6ac0b5188dbdc20
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014952
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
4 files changed, 16 insertions(+), 6 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52067ea090bb8d3b239b4dd8a6ac0b5188dbdc20
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
