Change in ovirt-engine[ovirt-engine-3.3]: core: Make commited_disk_size view column show total virtual...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Make commited_disk_size view column show total virtual size
......................................................................
core: Make commited_disk_size view column show total virtual size
In the storage views the commited_disk_size column is supposed to show the
total amount of the disks virtual sizes (commited size) in practice this
column shows the commited size minus the actual size of the disk, this
was fixed to show the commited size alone as the actual size is shown
already in used_disk_size and is not needed
Change-Id: Ic16b249779add146705a4e104dd93836923fbbd4
Bug-Url: https://bugzilla.redhat.com/1025294
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java
M packaging/dbscripts/create_functions.sql
M packaging/dbscripts/create_views.sql
4 files changed, 53 insertions(+), 9 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21325
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic16b249779add146705a4e104dd93836923fbbd4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.3]: core: taskcleaner.sh '-l' option does not prod...
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: taskcleaner.sh '-l' option does not prod...
......................................................................
core: taskcleaner.sh '-l' option does not prod...
Adding -L to the psql call to log command and its result.
Change-Id: Iee255ff5f929d795790088d5cf3475db0b81e04a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029177
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/setup/dbutils/taskcleaner.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified; Looks good to me, but someone else must approve
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21331
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee255ff5f929d795790088d5cf3475db0b81e04a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: avoid db deadlock and unneeded db updates for images
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: avoid db deadlock and unneeded db updates for images
......................................................................
core: avoid db deadlock and unneeded db updates for images
When adding a VM from template (as part of pool or not),
CreateSnapshotFromTemplateCommand is being executed and when the
operation ends its end method is being called for each of the disks.
In the end method there's an attempt to unlock the template image which
causes to numerous issues:
1. There are attempts to update the template disks statuses to ok,
as the updates aren't ordered and are executed for each added vm based
on that template - db deadlocks occur.
2.Currently the template disks aren't being locked at all (which
should be inspected regardless), so there's currently no point in unlocking them.
The fix which is introduced is to not update the image status if it's
already in the desired status, which will reduce the updates count in
general and will prevent possible db deadlocks in the provided
scenarios.
Change-Id: I26a09ce674cfefd59819f3edf95accab31f0e80e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=915753
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21100
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26a09ce674cfefd59819f3edf95accab31f0e80e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: Host shouldn't move to UP if it's already connected to...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Host shouldn't move to UP if it's already connected to other pool
......................................................................
core: Host shouldn't move to UP if it's already connected to other pool
When host fails to connect to the pool, it shouldn't move to UP if it's
already connected to other pool regardless of the master domain status.
Regardless of this change, the error handling in
ConnectStoragePoolVdsCommand should be changed as well as the error
handling in it's callers, this change handles InitVdsOnUp.
Change-Id: Ifd3d8268516b010f7831b59bbc6331cfd70efec1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1023732
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
1 file changed, 14 insertions(+), 4 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21095
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd3d8268516b010f7831b59bbc6331cfd70efec1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: don't send cloud-init drive automatically
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: don't send cloud-init drive automatically
......................................................................
core: don't send cloud-init drive automatically
Currently cloud init is sent automatically on first run,
just as sysprep is sent for windows vms.
The problem is that currently cloud init configuration is not stored in
the engine db, while sysprep does (in sysprep files).
Until this gap is implemented, this patch changes the logic not to send
cloud init drive automatically, only on user request.
Change-Id: I94e36467b9f9002105e3eedda34c53ec43f590e1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1014194
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Roy Golan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21329
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94e36467b9f9002105e3eedda34c53ec43f590e1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: engine: Remove redundant constant IrsBrokerCommand.BYTES_TO_GB
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: Remove redundant constant IrsBrokerCommand.BYTES_TO_GB
......................................................................
engine: Remove redundant constant IrsBrokerCommand.BYTES_TO_GB
We have a lot of similar constants across the Engine. BYTES_TO_GB is
one of them. Generic org.ovirt.engine.core.common.utils.SizeConverter
introduces BYTES_IN_GB which can be used instead of
IrsBrokerCommand.BYTES_TO_GB.
Change-Id: I0a3cede172aebab1182dca0ceec901be8553e6ae
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageDomainStatsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGListVDSCommand.java
4 files changed, 8 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21314
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0a3cede172aebab1182dca0ceec901be8553e6ae
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: engine, restapi: Remove redundant SizeConverter
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine, restapi: Remove redundant SizeConverter
......................................................................
engine, restapi: Remove redundant SizeConverter
Engine has 2 implementations of SizeConverter utility which converts
disk size from one unit to another. One of those implementations
resides in the common code and its code looks elegant therefore its
chosen to stay while other has been deleted.
Change-Id: I6a82a4a2ac199eb226b8848ac579106ca0497669
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/SizeConverterTest.java
D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/SizeConverter.java
D backend/manager/modules/restapi/interface/common/jaxrs/src/test/java/org/ovirt/engine/api/common/util/SizeConverterTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageLogicalUnitMapper.java
5 files changed, 66 insertions(+), 121 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21313
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a82a4a2ac199eb226b8848ac579106ca0497669
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.3]: core: adding utility for db objects owner change
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: adding utility for db objects owner change
......................................................................
core: adding utility for db objects owner change
This utility change objects in the engine database to be owned by the
engine user.
Related-To: https://bugzilla.redhat.com/1022691
Change-Id: I56c59c0fe749389bd110bcd1a39faae74e71174b
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/common_sp.sql
M packaging/dbscripts/dbfunctions.sh
A packaging/setup/dbutils/changedbowner.sh
3 files changed, 65 insertions(+), 3 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56c59c0fe749389bd110bcd1a39faae74e71174b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: VnicProfilesEditor to inherit AddRemoveRowWidget
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: VnicProfilesEditor to inherit AddRemoveRowWidget
......................................................................
webadmin: VnicProfilesEditor to inherit AddRemoveRowWidget
This to promote a uniform look between these similar widgets, as well
as code reuse.
Change-Id: If66c23bddada57fbfd95292dc2cc1f6c8d9df19e
Bug-Url: https://bugzilla.redhat.com/1025288
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/NewVnicProfileModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/NewNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/EditNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfilesEditor.ui.xml
11 files changed, 181 insertions(+), 179 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If66c23bddada57fbfd95292dc2cc1f6c8d9df19e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Added Linq method containsByIdentity
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Added Linq method containsByIdentity
......................................................................
webadmin: Added Linq method containsByIdentity
To be used for checking whether a specific item exists in a collection
by reference (==) rather than by value (equals()).
Change-Id: I68361e35955879efe4185c5a47d6cbcb48fd1987
Bug-Url: https://bugzilla.redhat.com/1025288
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Linq.java
1 file changed, 9 insertions(+), 0 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20948
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68361e35955879efe4185c5a47d6cbcb48fd1987
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months