Change in ovirt-engine[master]: core: Make commited_disk_size view column show total virtual...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Make commited_disk_size view column show total virtual size
......................................................................
core: Make commited_disk_size view column show total virtual size
In the storage views the commited_disk_size column is supposed to show the
total amount of the disks virtual sizes (commited size) in practice this
column shows the commited size minus the actual size of the disk, this
was fixed to show the commited size alone as the actual size is shown
already in used_disk_size and is not needed
Change-Id: Ic16b249779add146705a4e104dd93836923fbbd4
Bug-Url: https://bugzilla.redhat.com/1025294
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDAODbFacadeImpl.java
M packaging/dbscripts/create_functions.sql
M packaging/dbscripts/create_views.sql
4 files changed, 53 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20930
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic16b249779add146705a4e104dd93836923fbbd4
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: webadmin: VM GuideMe - update dialog on attach disk
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: VM GuideMe - update dialog on attach disk
......................................................................
webadmin: VM GuideMe - update dialog on attach disk
VM Guide Me:
Update 'Configure Virtual Disks' button to
'Add another Virtual Disk' after attaching a disk.
Change-Id: I21f7f8b7cd0733b2b2fc06cbe7cc39a9a42b755e
Bug-Url: https://bugzilla.redhat.com/1026308
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewGuideDiskModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java
3 files changed, 19 insertions(+), 23 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21090
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21f7f8b7cd0733b2b2fc06cbe7cc39a9a42b755e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: core: Default DC & Cluster has fixed UUIDs
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: core: Default DC & Cluster has fixed UUIDs
......................................................................
core: Default DC & Cluster has fixed UUIDs
When installing several RHEV environments and having integrated
management for the heterogeneous virtual environment.
When the integrated management program gathering information through the
rhev REST api every RHEVM installations of The 'Default' Datacenter
uuid and 'Default' Cluster uuid are the same.
These were generated uniq uuids on previous versions implementations
such as RHEV 3.0 or 3.1.
This patch removes the static DC & Cluster UUID (except from the tests)
and change all references to take the dynamic generated value that is
stored in the vdc_options table.
Change-Id: I96c96f5692a9ba113f37f0f8b082aaee244b3ed7
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026885
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StoragePoolValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M packaging/dbscripts/insert_data.sql
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-setup/config/appmode.py
9 files changed, 31 insertions(+), 21 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21040
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96c96f5692a9ba113f37f0f8b082aaee244b3ed7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: engine: unresolved placeholder in getDeviceVisibility error ...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: engine: unresolved placeholder in getDeviceVisibility error message
......................................................................
engine: unresolved placeholder in getDeviceVisibility error message
GetDeviceVisibility API verifies that all LUNs are connected to all
hosts in the data center. Up until now in case of failure this API
reported the error with unresolved placeholder '$hostName'. This patch
takes care to populate it's value.
Change-Id: I4b4b40a5296028fc8bcdc1f4a2ed156964a1b1a7
Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
1 file changed, 28 insertions(+), 21 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21246
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b4b40a5296028fc8bcdc1f4a2ed156964a1b1a7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-log-collector[ovirt-log-collector-3.3]: UX: remove alarming warning
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: UX: remove alarming warning
......................................................................
UX: remove alarming warning
After upgrading from 3.1 users was warned about a legacy config
still present in conf files if the user forgot to update .conf file
with the one provided by the package as .rpmnew.
The tool is able to use the legacy configuration so no need to
alarm the user about that.
Change-Id: I20a8ab68463e96acf5ca864c28b1d6662b734123
Bug-Url: https://bugzilla.redhat.com/1029234
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
1 file changed, 0 insertions(+), 9 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21302
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20a8ab68463e96acf5ca864c28b1d6662b734123
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-3.3
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-log-collector[master]: UX: remove alarming warning
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: UX: remove alarming warning
......................................................................
UX: remove alarming warning
After upgrading from 3.1 users was warned about a legacy config
still present in conf files if the user forgot to update .conf file
with the one provided by the package as .rpmnew.
The tool is able to use the legacy configuration so no need to
alarm the user about that.
Change-Id: I20a8ab68463e96acf5ca864c28b1d6662b734123
Bug-Url: https://bugzilla.redhat.com/1029234
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
1 file changed, 0 insertions(+), 9 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20a8ab68463e96acf5ca864c28b1d6662b734123
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: webadmin: Added hashName to pop-up windows
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: Added hashName to pop-up windows
......................................................................
webadmin: Added hashName to pop-up windows
Added missing hashNames to pop-up windows
Change-Id: I05cf8eb39096adbaafb5a1aea1d41d57446e54f0
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Sahina Bose: Verified
--
To view, visit http://gerrit.ovirt.org/21161
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05cf8eb39096adbaafb5a1aea1d41d57446e54f0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: engine: Clean up orphan gluster task references
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine: Clean up orphan gluster task references
......................................................................
engine: Clean up orphan gluster task references
Gluster tasks sync job periodically updates status
of gluster tasks in engine. However, if for some reason
(for instance, if engine was offline for a period of time)
gluster does not return a task's information, engine should
mark the job ended with task status UNKNOWN
Change-Id: I61f921109fb710dfb3f7255b54595c882c6a076c
Bug-Url: https://bugzilla.redhat.com/1022996
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTasksService.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJobTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StepDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StepDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StepDaoTest.java
M packaging/dbscripts/job_sp.sql
7 files changed, 132 insertions(+), 24 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Sahina Bose: Verified
--
To view, visit http://gerrit.ovirt.org/20954
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61f921109fb710dfb3f7255b54595c882c6a076c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: webadmin: fix feedback image visiblity issue
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: fix feedback image visiblity issue
......................................................................
webadmin: fix feedback image visiblity issue
'Feedback' section in the right-top will be hidden
if there is no feedback-url is available.
But that section is a collection images and text,
not all of them were hidden when no feedback-url supplied.
This is fixed by making the whole feedback panel
invisible if there is no feedback-url available.
Change-Id: I08c673909ba2a1c13e6bcac70a3ff19a99a1e6a3
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml
3 files changed, 17 insertions(+), 8 deletions(-)
Approvals:
Kanagaraj M: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21084
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08c673909ba2a1c13e6bcac70a3ff19a99a1e6a3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months
Change in ovirt-engine[master]: webadmin:fix rebalance status dialog disappers issues
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin:fix rebalance status dialog disappers issues
......................................................................
webadmin:fix rebalance status dialog disappers issues
Fixing the rebalance dialog disappearing issue. When user
logout and login, rebalance and remove brick related menu
items are having reference to old UI Command.
Using ActionButtonDefinition in MenuCell to dynamically
resolve the UI Command.
Change-Id: I98f8660cc080731ce8981eebc04f557c22bbbfaf
Bug-Url: https://bugzilla.redhat.com/1022946
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/MenuCell.java
3 files changed, 90 insertions(+), 36 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Ramesh N: Verified
--
To view, visit http://gerrit.ovirt.org/21259
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98f8660cc080731ce8981eebc04f557c22bbbfaf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 10 months