November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: increase AutoStartVmsRunner job frequency
by ofrenkel＠redhat.com 14 Nov '13

14 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: increase AutoStartVmsRunner job frequency ...................................................................... core: increase AutoStartVmsRunner job frequency This patch changes the default frequency of the AutoStartVmsRunner from 60 sec to 1 sec. Instead of invoking the RunVmCommand on each iteration, the AutoStartVmsRunner now try to acquire the needed VM lock first, and only if it succeed it invokes the RunVmCommand and the command release the acquired lock. The type of the internal collection of HA VMs to run in AutoStartVmsRunner job is also changed to CopyOnWriteArraySet which is a more appropriate data structure for this use-case and for the following planned enhancements. Change-Id: I0968cae554458f53a1f30643848bb8d88bd4de11 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 7 files changed, 88 insertions(+), 30 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19499 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0968cae554458f53a1f30643848bb8d88bd4de11 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fix cloud-init userData content
by iheim＠redhat.com 14 Nov '13

14 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: fix cloud-init userData content ...................................................................... core: fix cloud-init userData content some changes needed to comply with cloud-init userData requirements: * add needed #cloud-config header to userData file: this fix all commands sent in userData like timezone and cloud-init configuration settings * move password from metaData to userData root password parameter should be in userData, and not in metaData. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1004829 Change-Id: I4642aaf1d9349ebbe82b7c77e562ad5ca19ca3ee Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CloudInitHandler.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4642aaf1d9349ebbe82b7c77e562ad5ca19ca3ee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: search vms os match and ignore case
by iheim＠redhat.com 14 Nov '13

14 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: search vms os match and ignore case ...................................................................... core: search vms os match and ignore case search on os matched startsWith instead of equalsIgnoreCase * Added unit test coverage Change-Id: I739cad296389ef0356e204ed00b2546bd4d13c92 Signed-off-by: Roy Golan <rgolan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1003804 --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleter.java A backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/OsValueAutoCompleterTest.java 2 files changed, 43 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I739cad296389ef0356e204ed00b2546bd4d13c92 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: send ssh keys in cloud init
by iheim＠redhat.com 14 Nov '13

14 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: send ssh keys in cloud init ...................................................................... webadmin: send ssh keys in cloud init set to ssh keys field the correct value, probably a copy-paste error. Change-Id: Ia98613d7d235900c8b0712c7f8d3e8ce4e690f77 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1004829 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/CloudInitModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia98613d7d235900c8b0712c7f8d3e8ce4e690f77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Introducing an Enum to distinguish archs
by rgolan＠redhat.com 14 Nov '13

14 Nov '13

Roy Golan has submitted this change and it was merged. Change subject: core: Introducing an Enum to distinguish archs ...................................................................... core: Introducing an Enum to distinguish archs This introduces an Enum (called ArchitectureType) to distinguish the architecture of each supported processor. Change-Id: I5d63f0c66c2499f76b122d9c5cdbb7eebfe440e8 Signed-off-by: Vitor de Lima <vitor.lima(a)eldorado.org.br> Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa(a)eldorado.org.br> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CpuFlagsManagerHandler.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ArchitectureType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ServerCpu.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/Architecture.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/CPUMapper.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 9 files changed, 176 insertions(+), 19 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17853 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d63f0c66c2499f76b122d9c5cdbb7eebfe440e8 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa(a)eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.lima(a)eldorado.org.br> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Fix double checking
by amureini＠redhat.com 14 Nov '13

14 Nov '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix double checking ...................................................................... core: Fix double checking These getInstance() methods implement a double-checking scheme to initialize the instance static member. In order for this mechanism to operate correctly, the instance member should be defined as volatile (see, e.g., http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html) Change-Id: I6beb664980766958b3127080fdb785c6e668f6a9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6beb664980766958b3127080fdb785c6e668f6a9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: gluster: fix testcase failure in VolumeDao
by ofrenkel＠redhat.com 14 Nov '13

14 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: gluster: fix testcase failure in VolumeDao ...................................................................... gluster: fix testcase failure in VolumeDao Empty GUID will not be assigned to taskId of Volume while reading from database. Also return an empty AsnycTask if taskId is not present. Change-Id: I104f59d9dc170a1b151046e16de6ad5c35279e55 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java 2 files changed, 6 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I104f59d9dc170a1b151046e16de6ad5c35279e55 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: fix typo in w2k8r2
by iheim＠redhat.com 14 Nov '13

14 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: packaging: fix typo in w2k8r2 ...................................................................... packaging: fix typo in w2k8r2 caused sysprep floppy not to be sent to Windows 2008 R2 guests Change-Id: Ic6fa3bf93935a89a7efca2871e776a3231847a51 Bug-Url: https://bugzilla.redhat.com/1025829 Signed-off-by: Martin Polednik <mpoledni(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/config/options.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6fa3bf93935a89a7efca2871e776a3231847a51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fix stateless VM which was reverted to ram snapshot
by iheim＠redhat.com 14 Nov '13

14 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: core: fix stateless VM which was reverted to ram snapshot ...................................................................... core: fix stateless VM which was reverted to ram snapshot We were removing the memory volumes from snapshots in case the live part of the snapshot did not happen and the snapshot is set to include memory. This logic is not good because when it comes to stateless snapshots, the snapshots contain memory (the memory that was associated with the active snapshot) and it is not a live snapshot, but we don't want to remove the memory associated with it. Therefore, this patch changes the logic that is used to determine whether or not to remove the memory which is associated with snapshot when the live part of the snapshot doesn't happen, such that we'll also ask if the memory was created as part of this snapshot and only if it is, we will delete it. Change-Id: I0a4e479424757fab1107797568bc019681de8265 Bug-Url: https://bugzilla.redhat.com/1004184 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a4e479424757fab1107797568bc019681de8265 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Put back vNIC listener after flush
by iheim＠redhat.com 14 Nov '13

14 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: webadmin: Put back vNIC listener after flush ...................................................................... webadmin: Put back vNIC listener after flush Since pressing the "Advanced Mode" button in the Add VM dialog causes widgets to flush (without closing the dialog), the vNIC widget listener should be put back to still be able to handle events after the button was pressed. Change-Id: I7cc1583bd629e0cf217d7e941f6fd018032831fb Bug-Url: https://bugzilla.redhat.com/1029339 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/profile/ProfilesInstanceTypeEditor.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cc1583bd629e0cf217d7e941f6fd018032831fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0