November 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: engine: Host activate -check gluster availability
by iheim＠redhat.com 13 Nov '13

13 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Host activate -check gluster availability ...................................................................... engine: Host activate -check gluster availability If cluster supports gluster service, need to check if gluster is running, while activating host. If gluster command fails on server, the host state should not be changed to UP on activate. Change-Id: If673e32ed6480187ddcf6f9ecf8f0007e203b98d Bug-Url: https://bugzilla.redhat.com/975382 Bug-Url: https://bugzilla.redhat.com/968178 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/GlusterMonitoringStrategy.java 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21081 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If673e32ed6480187ddcf6f9ecf8f0007e203b98d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: Make the UseFqdnForRdpIfAvailable engine-config option avail...
by ofrenkel＠redhat.com 13 Nov '13

13 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: Make the UseFqdnForRdpIfAvailable engine-config option available ...................................................................... Make the UseFqdnForRdpIfAvailable engine-config option available BZ#901415 Introduced a new feature with this engine option. For convenience reasons we should expose this option within engine-config Change-Id: I913ac5463aef9d9bd9f58fdcdf588e7283d2fa99 Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- M packaging/etc/engine-config/engine-config.properties 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I913ac5463aef9d9bd9f58fdcdf588e7283d2fa99 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Allow to configure disk as read only when attach i...
by tnisan＠redhat.com 13 Nov '13

13 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Allow to configure disk as read only when attach it to VM ...................................................................... webadmin: Allow to configure disk as read only when attach it to VM Change-Id: I7bf1408371958d8522c5e6f486c75d1e32788f48 Bug-Url: https://bugzilla.redhat.com/878705 Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/VmDiskPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java 4 files changed, 56 insertions(+), 12 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20454 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bf1408371958d8522c5e6f486c75d1e32788f48 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Expose read-only disk functionality in UI.
by tnisan＠redhat.com 13 Nov '13

13 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Expose read-only disk functionality in UI. ...................................................................... webadmin: Expose read-only disk functionality in UI. Allow user to configure a read only property of a disk in the scope of VM. User can configure this property in Add/Edit VM disk popup windows and see it's value in related column under VM Disks subtab. Note that shared disk can be read only in scope of one VM and read write in scope of another therefore this property is meaningful in VM scope only. All other appearances of a disk in UI won't provide neither option to configure read only property nor visualize it's value. Change-Id: I2c8d98df5e9b7aa8130b45b1ca036219175b70bf Bug-Url: https://bugzilla.redhat.com/878705 Feature-Page-Url: http://www.ovirt.org/Features/Read_Only_Disk Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/disk_readonly.png M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/EditDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewDiskModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 11 files changed, 63 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c8d98df5e9b7aa8130b45b1ca036219175b70bf Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: backend, restapi: Add read-only disk functionality
by tnisan＠redhat.com 13 Nov '13

13 Nov '13

Tal Nisan has submitted this change and it was merged. Change subject: backend, restapi: Add read-only disk functionality ...................................................................... backend, restapi: Add read-only disk functionality All underlying components are already supporting RO disks functionlity. After that change Engine will support it either through the REST API. When adding/attaching/editing a disk to a VM, this feature adds a read-only property to the VM-Disk relationship which is persisted through VMDevice (vm_device in the DB). Floating disks continue to be RW. Note that shareable disk could be attached to one VM as RO, and to another as RW. Change-Id: I124176e8feb91b601a71e76dd63051648ec4353a Bug-Url: https://bugzilla.redhat.com/878705 Feature-Page-Url: http://www.ovirt.org/Features/Read_Only_Disk Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> Signed-off-by: Sergey Gotliv <sgotliv(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDettachVmDiskParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDisksResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/DiskMapperTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 20 files changed, 168 insertions(+), 58 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I124176e8feb91b601a71e76dd63051648ec4353a Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix stateless VM which was reverted to ram snapshot
by ofrenkel＠redhat.com 13 Nov '13

13 Nov '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix stateless VM which was reverted to ram snapshot ...................................................................... core: fix stateless VM which was reverted to ram snapshot We were removing the memory volumes from snapshots in case the live part of the snapshot did not happen and the snapshot is set to include memory. This logic is not good because when it comes to stateless snapshots, the snapshots contain memory (the memory that was associated with the active snapshot) and it is not a live snapshot, but we don't want to remove the memory associated with it. Therefore, this patch changes the logic that is used to determine whether or not to remove the memory which is associated with snapshot when the live part of the snapshot doesn't happen, such that we'll also ask if the memory was created as part of this snapshot and only if it is, we will delete it. Change-Id: I0a4e479424757fab1107797568bc019681de8265 Bug-Url: https://bugzilla.redhat.com/1004184 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a4e479424757fab1107797568bc019681de8265 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: engine: Allow updating network description & comment
by iheim＠redhat.com 13 Nov '13

13 Nov '13

Itamar Heim has submitted this change and it was merged. Change subject: engine: Allow updating network description & comment ...................................................................... engine: Allow updating network description & comment Always allow updating the description and comment fields, regardless of the network state. Change-Id: I670e862c075ec20ab6b39c63c4c140a798e19903 Bug-Url: https://bugzilla.redhat.com/1028739 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I670e862c075ec20ab6b39c63c4c140a798e19903 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: utils: pki-resources: cleanup: add final to all members
by emesika＠redhat.com 13 Nov '13

13 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: utils: pki-resources: cleanup: add final to all members ...................................................................... utils: pki-resources: cleanup: add final to all members Change-Id: I4c7fa841aefe0f6c2c482e7124529e13b396e666 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/PKIResources.java 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4c7fa841aefe0f6c2c482e7124529e13b396e666 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: bll: GetServerSSHKeyFingerprintQueryTest: cleanup: remove do...
by emesika＠redhat.com 13 Nov '13

13 Nov '13

Eli Mesika has submitted this change and it was merged. Change subject: bll: GetServerSSHKeyFingerprintQueryTest: cleanup: remove doNothing ...................................................................... bll: GetServerSSHKeyFingerprintQueryTest: cleanup: remove doNothing less complexity and one less false positive at coverity. Change-Id: Id602ca76e1069d794750789c0e2283c22639139e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQueryTest.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id602ca76e1069d794750789c0e2283c22639139e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Allowed vNIC activation when VM status is ImageLocked
by lvernia＠redhat.com 13 Nov '13

13 Nov '13

Lior Vernia has submitted this change and it was merged. Change subject: engine: Allowed vNIC activation when VM status is ImageLocked ...................................................................... engine: Allowed vNIC activation when VM status is ImageLocked Since adding VM interfaces was enabled in the add VM dialog, vNIC activation might also happen when the VM is in status ImageLocked (and not just Up or Down). Change-Id: I04d8d6478e0593f89d2c221b2222b6764fd3cbc5 Bug-Url: https://bugzilla.redhat.com/1028755 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04d8d6478e0593f89d2c221b2222b6764fd3cbc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0