Change in ovirt-engine[master]: webadmin: fixed remove brick actions disabled issue in volum...
by kmayilsa＠redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: fixed remove brick actions disabled issue in volumes tab
......................................................................
webadmin: fixed remove brick actions disabled issue in volumes tab
When user move between sub tabs, entity of the previous tabs (all in
active tabs) being null. Because of this, menu items in volumes
tab are not getting enabled. So moved the volume entity as part of
VolumeBricksListModel and removed the usage of getEntity() in
all remove brick related commands.
Change-Id: I005592a1cda7d65cc069ad88f2c46d9f68b1f368
Bug-Url: https://bugzilla.redhat.com/1022585
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
2 files changed, 19 insertions(+), 9 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Ramesh N: Verified
--
To view, visit http://gerrit.ovirt.org/21125
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I005592a1cda7d65cc069ad88f2c46d9f68b1f368
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: packaging: fix typo in w2k8r2
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: fix typo in w2k8r2
......................................................................
packaging: fix typo in w2k8r2
caused sysprep floppy not to be sent to Windows 2008 R2 guests
Change-Id: Ic6fa3bf93935a89a7efca2871e776a3231847a51
Bug-Url: https://bugzilla.redhat.com/1025829
Signed-off-by: Martin Polednik <mpoledni(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/config/options.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21172
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6fa3bf93935a89a7efca2871e776a3231847a51
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: backend: unlock images when GetImageInfo fails
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: backend: unlock images when GetImageInfo fails
......................................................................
backend: unlock images when GetImageInfo fails
In BaseImagesCommand.endSuccessfully() we try to update the image
information contacting VDSM. If VDSM is down or for any other error
we should fail gracefully (logging) and release the locks on the
image.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1018876
Change-Id: I980e60ba5ad4fcc07752d065c3eaca03af025896
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
1 file changed, 17 insertions(+), 10 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I980e60ba5ad4fcc07752d065c3eaca03af025896
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[master]: backend: prevent live storage migration on live snapshot fai...
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: backend: prevent live storage migration on live snapshot failure
......................................................................
backend: prevent live storage migration on live snapshot failure
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1018876
Change-Id: I7c69f663836e74691c968f4a15c5f3012479a8b0
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDisksTaskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java
3 files changed, 20 insertions(+), 11 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20668
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c69f663836e74691c968f4a15c5f3012479a8b0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Disable Host/Interfaces subtab refresh pre-3.1
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Disable Host/Interfaces subtab refresh pre-3.1
......................................................................
webadmin: Disable Host/Interfaces subtab refresh pre-3.1
In pre-3.1 clusters, host networking is setup through the subtab, and
refreshing the subtab (for the statistics) makes that hard to do as it
resets the row selection.
Change-Id: Idb1d14be079936eac2fb302320eb7000e970bc32
Bug-Url: https://bugzilla.redhat.com/1027597
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostInterfacePresenter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostInterfaceView.java
4 files changed, 36 insertions(+), 3 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21154
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb1d14be079936eac2fb302320eb7000e970bc32
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in ovirt-engine[ovirt-engine-3.3]: engine: Move quota to Image_storage_domain_map
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Move quota to Image_storage_domain_map
......................................................................
engine: Move quota to Image_storage_domain_map
In order to allow assigning different quota to the same image on
different storage domains, the quota id was moved from the images table
to Image_storage_domain_map table.
Backend entities were change to suit this change - so that quota is no
longer a field of Image but a field DiskImage and multiple quotas can be
assign to the same DiskImage for different Storage Domains.
Bug-Url: https://bugzilla.redhat.com/1001032
Change-Id: Icc81b077cf125de85fcb3586bc0d0f71e5e0716a
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeQuotaForDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CopyImageGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Image.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ImageStorageDomainMapId.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/image_storage_domain_map.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageStorageDomainMapDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ImageStorageDomainMapDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageStorageDomainMapDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/quota/ChangeQuotaItemView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/quota/ChangeQuotaItemView.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/quota/ChangeQuotaView.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskGeneralModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/ChangeQuotaItemModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/ChangeQuotaModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/ChangeQuotaPopupView.ui.xml
M packaging/dbscripts/create_functions.sql
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/image_storage_domain_map_sp.sql
M packaging/dbscripts/images_sp.sql
M packaging/dbscripts/quota_sp.sql
A packaging/dbscripts/upgrade/03_03_1020_move_quota_id.sql
M packaging/dbscripts/vm_templates_sp.sql
M packaging/dbscripts/vms_sp.sql
39 files changed, 305 insertions(+), 180 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/20971
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc81b077cf125de85fcb3586bc0d0f71e5e0716a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 2 months
Change in mom[master]: GuestMemory: Start memory stats collection on initialization
by agl＠us.ibm.com
Adam Litke has submitted this change and it was merged.
Change subject: GuestMemory: Start memory stats collection on initialization
......................................................................
GuestMemory: Start memory stats collection on initialization
Specify update rate of memory stats of virtio balloon driver using
new libvirt API virDomainSetMemoryStatsPeriod.
Change-Id: If90ff472d57d54edc6f22baf2a41322cb9e79448
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama(a)hds.com>
Reviewed-on: http://gerrit.ovirt.org/19199
Reviewed-by: Adam Litke <agl(a)us.ibm.com>
Tested-by: Adam Litke <agl(a)us.ibm.com>
---
M mom/Collectors/GuestMemory.py
M mom/HypervisorInterfaces/HypervisorInterface.py
M mom/HypervisorInterfaces/libvirtInterface.py
3 files changed, 20 insertions(+), 0 deletions(-)
Approvals:
Adam Litke: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19199
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If90ff472d57d54edc6f22baf2a41322cb9e79448
Gerrit-PatchSet: 5
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Tomoki Sekiyama <tomoki.sekiyama(a)hds.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tomoki Sekiyama <tomoki.sekiyama(a)hds.com>
11 years, 2 months
Change in mom[master]: libvirtInterface: Convert some keys of mem_stats in getVmMem...
by agl＠us.ibm.com
Adam Litke has submitted this change and it was merged.
Change subject: libvirtInterface: Convert some keys of mem_stats in getVmMemoryStats()
......................................................................
libvirtInterface: Convert some keys of mem_stats in getVmMemoryStats()
libvirtInterface.mem_stats is a dictionary to convert keys of mem_stats
from libvirt internal name to that of used in mom rules, but its value was
not actually used. This patch fixes this.
Change-Id: I9281a332419f4a7a52764e4def265d742080252c
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama(a)hds.com>
Reviewed-on: http://gerrit.ovirt.org/19198
Reviewed-by: Adam Litke <agl(a)us.ibm.com>
Tested-by: Adam Litke <agl(a)us.ibm.com>
---
M mom/HypervisorInterfaces/libvirtInterface.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Adam Litke: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/19198
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9281a332419f4a7a52764e4def265d742080252c
Gerrit-PatchSet: 5
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Tomoki Sekiyama <tomoki.sekiyama(a)hds.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tomoki Sekiyama <tomoki.sekiyama(a)hds.com>
11 years, 2 months
Change in mom[master]: policy: Fix balloon policy syntax and semantics
by agl＠us.ibm.com
Adam Litke has submitted this change and it was merged.
Change subject: policy: Fix balloon policy syntax and semantics
......................................................................
policy: Fix balloon policy syntax and semantics
This patch fixes two issues in the current balloon policy:
1) In shrink_guest, guest_free_percent should be
min_guest_free_percent. This was causing a runtime error for users.
2) When calculating balloon_min, we want to choose whichever number is
higher between guest.balloon_min and the calculated value.
Otherwise, guest.balloon_min cannot act as a floor value as it is
intended to.
Change-Id: I8fba77bb5c42b29ab479752e335cbc11ed0a298b
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
Reviewed-on: http://gerrit.ovirt.org/19416
Reviewed-by: Saggi Mizrahi <smizrahi(a)redhat.com>
Reviewed-by: Martin Sivák <msivak(a)redhat.com>
---
M doc/balloon.rules
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Adam Litke: Verified; Looks good to me, approved
Martin Sivák: Looks good to me, but someone else must approve
Saggi Mizrahi: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/19416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fba77bb5c42b29ab479752e335cbc11ed0a298b
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
11 years, 2 months
Change in mom[master]: Add tests to MANIFEST.in and run them during an rpm build
by agl＠us.ibm.com
Adam Litke has submitted this change and it was merged.
Change subject: Add tests to MANIFEST.in and run them during an rpm build
......................................................................
Add tests to MANIFEST.in and run them during an rpm build
Change-Id: I298e3719ee461e747fb47fa681b326578bf26d85
Signed-off-by: Martin Sivak <msivak(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/16883
Reviewed-by: Adam Litke <agl(a)us.ibm.com>
Tested-by: Adam Litke <agl(a)us.ibm.com>
---
M MANIFEST.in
M mom.spec.in
2 files changed, 13 insertions(+), 10 deletions(-)
Approvals:
Adam Litke: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16883
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I298e3719ee461e747fb47fa681b326578bf26d85
Gerrit-PatchSet: 5
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
11 years, 2 months