November 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core: prevent split brain caused by fence commands

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: prevent split brain caused by fence commands ...................................................................... core: prevent split brain caused by fence commands This fix aims to run fence command mutually exclusive. RestartVds is running Stop, FenceManually and Start. This flow is marking VMs as down and playing them again on other hosts. 2 parallel calls to this flow or interleacing RestartVds with other Stop or FenceManaually could end up marking again VMs whic currently starting up by flow 1 as down, causing them to start and new instance on other host and leading to 2 instances of the same VM. To Achieve this mutually exclusive run: * Added exclusive lock on VDS_FENCE + vdsId on RestartVds, Stop, FenceManually and Start commands * Shared the lock from parent RestartVds with childs Stop, FenceManually and start * overriden freeLock() method of Stop, FenceManually and Start to release the lock only if we have been invoked without RestartVds as a parent command Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1026811 Change-Id: Iaf021010188e3c3662fbf8a057da4c58f2600c02 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsNotRespondingTreatmentCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 136 insertions(+), 9 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf021010188e3c3662fbf8a057da4c58f2600c02 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: support pin-to-any

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: core: support pin-to-any ...................................................................... core: support pin-to-any Fixing a regression that forces to specify a host for non-migratable VMs. Change-Id: I10d60bb9db2506a63a19f5e75446ddac32b8dc3e Bug-Url: https://bugzilla.redhat.com/1021574 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PinToHostPolicyUnit.java 1 file changed, 11 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20829 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10d60bb9db2506a63a19f5e75446ddac32b8dc3e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: export vm - perform space checks only for relevant disks

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: export vm - perform space checks only for relevant disks ...................................................................... core: export vm - perform space checks only for relevant disks Currently the space check on export vm will be done for the image disks, including shareable and snapshot disks that aren't part of the export. In this patch the check is changed so that the needed space would be checked only for the exported disks. Change-Id: I8d7b8eae635ac88af5c3e1ffbe08be7fcdf9da72 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029038 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 2 files changed, 22 insertions(+), 7 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d7b8eae635ac88af5c3e1ffbe08be7fcdf9da72 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: fix of export without tasks and snapshot collapse

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: fix of export without tasks and snapshot collapse ...................................................................... core: fix of export without tasks and snapshot collapse The following patch handles the following issues: *The loop should be performed for disks relevant to the snapshot only. *The populated image id's list should contain only exported images. *When exporting a vm with no created tasks and collapse, the collapse operations should be done - otherwise we will never have the snapshots collapsed when there are no created tasks. *The unlock of the vm should be the last step, as otherwise the vm configuration might change during the run and yield to inconsistent results. Change-Id: I1bfc2761a5483d6f0b274d064cbc7e155562573f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=922475 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 3 insertions(+), 14 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bfc2761a5483d6f0b274d064cbc7e155562573f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: rename method in ExportVmCommand

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: rename method in ExportVmCommand ...................................................................... core: rename method in ExportVmCommand Rename the method endDiskRelatedActions to be less obscure and reflect what it actually does i.e. populating the VM disks & devices data Change-Id: I468fc1875d8f6045dba376beec2636a144a17efe Related to Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=922475 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I468fc1875d8f6045dba376beec2636a144a17efe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: export vm - removal of unneeded for loop

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: export vm - removal of unneeded for loop ...................................................................... core: export vm - removal of unneeded for loop All the disks that are part of the export are already being iterated over, their id's can be added during that loop. Furthermore, there's no need to include id's that aren't part of the export (of shareable/snapshot disks). Change-Id: I8f6c3b2ae192674e7edc86840253d6f8ef02d5c0 Related to Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=922475 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f6c3b2ae192674e7edc86840253d6f8ef02d5c0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: core: Fix task polling when exporting vm command with memory...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: core: Fix task polling when exporting vm command with memory snapshots ...................................................................... core: Fix task polling when exporting vm command with memory snapshots When exporting vm with memory snapshots that tasks are not polled, causing to the command end method to be called possibly too early and to the tasks to never be cleared. Change-Id: Ief3b3a361fd0ff175f333c7ac2935ce6993ae4b2 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1029324 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/20896 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief3b3a361fd0ff175f333c7ac2935ce6993ae4b2 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: setup: generate answerfile readable by user only

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: generate answerfile readable by user only ...................................................................... packaging: setup: generate answerfile readable by user only fix file mode of previous stored answer files at state. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1028748 Change-Id: I3c1ca00b7a56216d7051c7625c5e983d422caab9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-common/core/answerfile.py M packaging/setup/plugins/ovirt-engine-setup/upgrade/__init__.py A packaging/setup/plugins/ovirt-engine-setup/upgrade/answerfile_fixup.py 3 files changed, 65 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3c1ca00b7a56216d7051c7625c5e983d422caab9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: move network validations on run vm to RunVmValidator

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: move network validations on run vm to RunVmValidator ...................................................................... core: move network validations on run vm to RunVmValidator Move the network validations from RunVmCommand to RunVmValidator, where this kind of validations should reside. The methods that were moved were changed to return ValidationResult instead of boolean to conform the standard. Change-Id: I6aff70b45617e90deac826f2a873c1604c9a4241 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 3 files changed, 103 insertions(+), 88 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6aff70b45617e90deac826f2a873c1604c9a4241 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: fix for stop remove brick issue in status popup

by kmayilsa＠redhat.com

Kanagaraj M has submitted this change and it was merged. Change subject: webadmin: fix for stop remove brick issue in status popup ...................................................................... webadmin: fix for stop remove brick issue in status popup Removing the unnecessary selected items check in onStopRemoveBrick method which blocks stop remove brick action from status pop up launched from volumes tab. Change-Id: If116f08fd99d42126ecf725fd50d8d7f51d2eceb Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Kanagaraj M: Looks good to me, approved Ramesh N: Verified -- To view, visit http://gerrit.ovirt.org/21126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If116f08fd99d42126ecf725fd50d8d7f51d2eceb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2013