November 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: AttachNetworkToVdsGroupTest.getNetworkList

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: AttachNetworkToVdsGroupTest.getNetworkList ...................................................................... core: AttachNetworkToVdsGroupTest.getNetworkList Removed unused method. Change-Id: I90ea9ca806d500e07c88964b5288ffe381f1dcaa Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommandTest.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21749 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90ea9ca806d500e07c88964b5288ffe381f1dcaa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: rm unused Quotable interface

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: rm unused Quotable interface ...................................................................... core: rm unused Quotable interface Change-Id: Id3ec01d83eb98c5bf35aba5a4ebe4e68adab454c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/Quotable.java 1 file changed, 0 insertions(+), 18 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21752 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3ec01d83eb98c5bf35aba5a4ebe4e68adab454c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: ExternalTrustStoreInitializer.FILE_URL_PREFIX

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: ExternalTrustStoreInitializer.FILE_URL_PREFIX ...................................................................... core: ExternalTrustStoreInitializer.FILE_URL_PREFIX Remove unused constant. Change-Id: I8df083543c95d1d89348becffa2f14a83dedc14a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/ExternalTrustStoreInitializer.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8df083543c95d1d89348becffa2f14a83dedc14a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-hosted-engine-ha[master]: agent, broker: progressive score penalty for high cpu load

by gpadgett＠redhat.com

Greg Padgett has submitted this change and it was merged. Change subject: agent, broker: progressive score penalty for high cpu load ...................................................................... agent, broker: progressive score penalty for high cpu load Penalize the host score progressively based on cpu load and duration of that load. The host load used doesn't count the load incurred by the engine vm, in order to help keep host scores stable if the vm changes hosts. Additional related changes include not considering memory used by the vm in the memory score, as well as logging changes to make it easier to tell what the various factors were in generating the current score. Change-Id: I9cb205f5eb3729a17692b8ab854c58ddfe862b2f Bug-Url: https://bugzilla.redhat.com/1034205 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/hosted_engine.py M ovirt_hosted_engine_ha/broker/submonitors/Makefile.am M ovirt_hosted_engine_ha/broker/submonitors/cpu_load.py A ovirt_hosted_engine_ha/broker/submonitors/cpu_load_no_engine.py M ovirt_hosted_engine_ha/env/config.py 6 files changed, 285 insertions(+), 35 deletions(-) Approvals: Greg Padgett: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cb205f5eb3729a17692b8ab854c58ddfe862b2f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: further handling of unmanaged disk devices

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: further handling of unmanaged disk devices ...................................................................... core: further handling of unmanaged disk devices When attempting to restore vm configuration from a snapshot, unmanaged disk devices can be removed as well and restored from the snapshot if needed like other unmanaged devices. Change-Id: Ia0cd3a95de9b04d49cc655981e15abed4f1adab7 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0cd3a95de9b04d49cc655981e15abed4f1adab7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: Do not overwrite 10-setup-database.conf if not re...

by iheim＠redhat.com

Itamar Heim has submitted this change and it was merged. Change subject: packaging: Do not overwrite 10-setup-database.conf if not required ...................................................................... packaging: Do not overwrite 10-setup-database.conf if not required Without this change, engine-backup --mode=restore and without --change-db-credentials will empty 10-setup-database.conf . Bug-Url: https://bugzilla.redhat.com/1002401 Change-Id: I5b2e4d0e291e8c5a8afabd7d8cca29f289154b0a Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b2e4d0e291e8c5a8afabd7d8cca29f289154b0a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: unlock VM on failure to migrate it to server

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: unlock VM on failure to migrate it to server ...................................................................... core: unlock VM on failure to migrate it to server Recently we changed the MigrateVmCommand to lock the VM for the whole migration process. When the VM was migrated to server and the migration failed, we didn't release that lock and the VM would remain locked. The fact that the handling of failed migrations was spread over the code, made it more error-prone - things that were added for regular migrations could have been missing for migrations to server. This patch extracts the code that should be executed when migration fails to separate method, and this method is called when migrations to server fail as well. In particular, the acquired lock is released and therefore the bug that was previously described is solved. Change-Id: I282a1fec8ed3f12a8377b2eca8deadc7985d2f66 Bug-Url: https://bugzilla.redhat.com/1033932 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java 2 files changed, 18 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I282a1fec8ed3f12a8377b2eca8deadc7985d2f66 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: fix audit log on migration rerun failure case

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix audit log on migration rerun failure case ...................................................................... core: fix audit log on migration rerun failure case In a specific case where migration fails, thus the VM is switched back to Up state in the source and then goes down in the source, we used to print an audit log message saying that it will be rerun although we won't try to rerun. So this patch fix that audit log to be the one that says the migration process failed. Change-Id: I8e608cbdac5d38f7c3468f57cc563b8a3715359e Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e608cbdac5d38f7c3468f57cc563b8a3715359e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: simplify MigrateVmCommand#getAuditLogTypeValue

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: simplify MigrateVmCommand#getAuditLogTypeValue ...................................................................... core: simplify MigrateVmCommand#getAuditLogTypeValue This method used to contain a ternary-if statement with 3 and 4 levels which made it less readable. By extracting the those levels to separate methods, the highest level within that ternary-if statement was reduced to 2 and now it is more readable. Change-Id: I54f4e026199187212a872eaef27933a845194b55 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java 1 file changed, 20 insertions(+), 7 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54f4e026199187212a872eaef27933a845194b55 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

11 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix balloon check so it supports more than 2TB of RAM

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Fix balloon check so it supports more than 2TB of RAM ...................................................................... core: Fix balloon check so it supports more than 2TB of RAM All BalloonInfo fields are Longs so it does not make sense to compare them as Ints. Moreover the VM has more than about 2TB of RAM then Int (32 bits) overflows. Change-Id: I69c7ccf6d58cbf000d95e3448c75eb986ba39b0a Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21793 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69c7ccf6d58cbf000d95e3448c75eb986ba39b0a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>

11 years, 1 month

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2013