Change in ovirt-engine-sdk-java[master]: sdk: arguments name fixing
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: arguments name fixing
......................................................................
sdk: arguments name fixing
Change-Id: I3cb00b57eff2486f207db7d372cbadbbfb5467a2
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPool.java
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/IdleConnectionMonitorThread.java
2 files changed, 14 insertions(+), 14 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/22510
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3cb00b57eff2486f207db7d372cbadbbfb5467a2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years
Change in ovirt-engine[master]: core, frontend: show template name also for cloned VMs
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: core,frontend: show template name also for cloned VMs
......................................................................
core,frontend: show template name also for cloned VMs
If the template provisioning of the VM is clone, the general subtab
of the VM/Pool shows that the "Template"'s value is Blank.
This patch changes this to the following behavior:
- for cloned provisioning the "Template" field shows:
"templateName (Clone/Independent)"
- for thin provisioning the "Template" field shows:
"templateName (Thin/Dependent)"
- for VMs created from Blank template the "Template" field shows:
"templateName"
- for VMs created before this feature added the "Template" field shows:
"templateName"
Same logic apply for the Storage main tab -> VM Import subtab ->
Template column
The implementation:
Two new fields added to the vm_static table:
- original_template_id: never changes
- original_template_name: changes when the template on which this VM
is based on changes the name. This is checked during VM/template import
and during template update
The original_template_name field is there and maintained "by hand" (instead of
having a reference to the template in original_template_id) is because this
field has to be shown even after the original template has been deleted.
Change-Id: Ieea4ad7c1ed845d3ff57aaafc19f0830ab72b2d1
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1042784
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolGeneralModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGeneralModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmTemplateNameRenderer.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageVmBackupView.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_04_0280_add_original_template_to_vm_static.sql
M packaging/dbscripts/vms_sp.sql
22 files changed, 263 insertions(+), 15 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21047
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieea4ad7c1ed845d3ff57aaafc19f0830ab72b2d1
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: rest: fix xsd validation for Payload
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: rest: fix xsd validation for Payload
......................................................................
rest: fix xsd validation for Payload
volume id is optional parameter for payload,
so setting minOccurs to 0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1031960
Change-Id: Ib74b032753a11f972ea82b89a69044d68b3c76ed
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21962
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib74b032753a11f972ea82b89a69044d68b3c76ed
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Block profile creation even if network's flushed
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: webadmin: Block profile creation even if network's flushed
......................................................................
webadmin: Block profile creation even if network's flushed
A previous fix neglected the fact that the Edit Network dialog could
be flushed but remain open, e.g. as in the case of a failed backend
action. This patch disables the profile creation logic in that case as
well.
Change-Id: Ia099ce1af15393cb498775afd0b435069fc0e0f1
Bug-Url: https://bugzilla.redhat.com/1043386
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkModel.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/22508
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia099ce1af15393cb498775afd0b435069fc0e0f1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
11 years
Change in ovirt-reports[master]: ovirt-reports: Add ReportsStatus to makefile
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: ovirt-reports: Add ReportsStatus to makefile
......................................................................
ovirt-reports: Add ReportsStatus to makefile
Add ReportsStatus maven artifact to Makefile
so it can be picked up by rpm build process
Change-Id: I19ebc8063dc76195379da60bdd317639fe0b83ab
Bug-Url: https://bugzilla.redhat.com/1037667
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M Makefile
M manifest/ovirt-reports-manifest.csv
M reports/jars/ReportsStatus/pom.xml
3 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Ravi Nori: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19ebc8063dc76195379da60bdd317639fe0b83ab
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years
Change in ovirt-engine[master]: core: remove redundant checks when running vm
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: remove redundant checks when running vm
......................................................................
core: remove redundant checks when running vm
Three checks are removed from RunVmCommand#initVm:
1. Check if the VM is null
2. Check if snapshot is being taken for the VM
3. Check if the VM status is not imageLocked or imageIllegal
Those checks are already tested in the canDoAction method (by the
validations that are made by RunVmValidator), and since the VM is
locked in the execute phase, it should be enough.
Change-Id: I396b3322c551af3414268f5fe16a1ccaf5ccf1bd
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
6 files changed, 49 insertions(+), 76 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22075
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I396b3322c551af3414268f5fe16a1ccaf5ccf1bd
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: engine: Change few methods visibility of NetworkConfigurator
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Change few methods visibility of NetworkConfigurator
......................................................................
engine: Change few methods visibility of NetworkConfigurator
There can be a reuse of NetworkConfigurator methods
by the UpdateNetworkCommand, therefore their visibility
should be changed to allow it.
Change-Id: Ic329a2dc08c39ff971aca6b327a29372e1164f43
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/NetworkConfigurator.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22050
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic329a2dc08c39ff971aca6b327a29372e1164f43
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: engine: Extract method for network sync-ness
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Extract method for network sync-ness
......................................................................
engine: Extract method for network sync-ness
A method is extract in order to provide the ability
to use the check if a network configured on host is
synchronized with its logical definition.
Change-Id: I91668eacbde561ff0392a86c8fc29c35ead6ac9d
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I91668eacbde561ff0392a86c8fc29c35ead6ac9d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: engine: Refactor of propagateFailure(VdcReturnValueBase)
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Refactor of propagateFailure(VdcReturnValueBase)
......................................................................
engine: Refactor of propagateFailure(VdcReturnValueBase)
The method will be used from few commands, therefore it
is being pulled into a higher level in the hierarchy tree.
Change-Id: Ie18a9b7e168d7637c98f7915f5ba93bac9970364
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java
2 files changed, 13 insertions(+), 7 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22395
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie18a9b7e168d7637c98f7915f5ba93bac9970364
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: engine: Introduce ParallelMultipleActionsRunner
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Introduce ParallelMultipleActionsRunner
......................................................................
engine: Introduce ParallelMultipleActionsRunner
The ParallelMultipleActionsRunner designed to execute
multiple actions in parallel. Since there is not boundary
to the number of parallel threads, it should be used wisely.
Change-Id: I03a381eb9e3e9d26aeba324fe568a16a44ecef80
Signed-off-by: Moti Asayag <masayag(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ParallelMultipleActionsRunner.java
2 files changed, 46 insertions(+), 6 deletions(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03a381eb9e3e9d26aeba324fe568a16a44ecef80
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years