Change in ovirt-engine[master]: core: rename methods to lowercase in XmlRpcObjectDescriptor
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: rename methods to lowercase in XmlRpcObjectDescriptor
......................................................................
core: rename methods to lowercase in XmlRpcObjectDescriptor
Rename 3 methods to start with lowercase - per Java naming
conventions. Solves findbugs warnings.
Change-Id: I9b218d4220a7b80d2482935e16bf5179a62f76db
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVmsInfoReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/OneImageInfoReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StoragePoolInfoReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/DevicesVisibilityMapReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStorageDomainStatsVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/LUNListReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainInfoReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneStorageDomainStatsReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/OneVGReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ServerConnectionStatusReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskInfoListReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskStatusListReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VGListReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcObjectDescriptor.java
15 files changed, 22 insertions(+), 22 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21920
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b218d4220a7b80d2482935e16bf5179a62f76db
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: compat: remove unused methods in several classes
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: compat: remove unused methods in several classes
......................................................................
compat: remove unused methods in several classes
Change-Id: Iece4ed1a69e0e648413468c229d4f2f05e5b172d
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DateTime.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/IntegerCompat.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NotImplementedException.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java
6 files changed, 0 insertions(+), 100 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21918
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iece4ed1a69e0e648413468c229d4f2f05e5b172d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: engine: Show waiting for gluster tasks
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Show waiting for gluster tasks
......................................................................
engine: Show waiting for gluster tasks
When a gluster task is run on a volume for
the second time, before gluster returns the
newly created task, the view was fetching the
previous task's status.
Changed the view where condition to fetch the
status correctly.
Also, the view should only return job status
related to gluster async tasks.
Change-Id: Ia3a2ac3ddc2f46f24b84628cf52f3a193cdebf31
Bug-Url: https://bugzilla.redhat.com/1025304
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M packaging/dbscripts/create_views.sql
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21907
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3a2ac3ddc2f46f24b84628cf52f3a193cdebf31
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-hosted-engine-ha[master]: build: ovirt-hosted-engine-ha-0.1.0-0.8.beta1
by gpadgett＠redhat.com
Greg Padgett has submitted this change and it was merged.
Change subject: build: ovirt-hosted-engine-ha-0.1.0-0.8.beta1
......................................................................
build: ovirt-hosted-engine-ha-0.1.0-0.8.beta1
Change-Id: I3b2955175c615bc30d6fd298496f34e510139104
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M configure.ac
M ovirt-hosted-engine-ha.spec.in
2 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Greg Padgett: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21960
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b2955175c615bc30d6fd298496f34e510139104
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: uicompat: rename 2 methods in PreparingEnlistment
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: uicompat: rename 2 methods in PreparingEnlistment
......................................................................
uicompat: rename 2 methods in PreparingEnlistment
Rename methods to start with lowercase per Java standard.
Resolves findbugs warnings.
Also, remove commented out code that mentions the renamed methods.
Change-Id: I57997edd34600e2a28582c1cd1a0652459f32e7a
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddStorageDomainRM.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ChangeHostClusterRM.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/PreparingEnlistment.java
5 files changed, 16 insertions(+), 87 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Alissa Bonas: Verified
--
To view, visit http://gerrit.ovirt.org/21922
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57997edd34600e2a28582c1cd1a0652459f32e7a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[master]: core: rename method to lowercase in Ticketing class
by oourfali＠redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: core: rename method to lowercase in Ticketing class
......................................................................
core: rename method to lowercase in Ticketing class
Rename GenerateOTP to start with lowercase.
Solves a findbugs warning.
Change-Id: I49ee7ee583d839d2b27383ff4a67b7b46366b5bf
Signed-off-by: Alissa Bonas <abonas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Ticketing.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/TicketingTest.java
5 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21898
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I49ee7ee583d839d2b27383ff4a67b7b46366b5bf
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-hosted-engine-ha[master]: agent, lib: agent compatibility with metadata updates
by gpadgett＠redhat.com
Greg Padgett has submitted this change and it was merged.
Change subject: agent, lib: agent compatibility with metadata updates
......................................................................
agent, lib: agent compatibility with metadata updates
When the metadata version changes, both old and new agents should
recognize this and behave appropriately. The desired behavior is
described in this comment from constants.py.in:
The range of valid metadata versions for this host is from
METADATA_PARSE_VERSION <= version <= METADATA_FEATURE_VERSION. If an
incompatible change is made to the metadata, both the parse and feature
versions should be raised beyond the current feature version. This will
ensure that a) the old agent will recognize that it has been superseded
and shut down the vm, and b) the newer agents will ignore the older
agents' reported scores, thus assuming control of the vm.
Change-Id: I2357ce26aeb20439dec161c7b8ee46d94a4b3e3d
Bug-Url: https://bugzilla.redhat.com/1036710
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/constants.py.in
M ovirt_hosted_engine_ha/agent/hosted_engine.py
M ovirt_hosted_engine_ha/lib/exceptions.py
M ovirt_hosted_engine_ha/lib/metadata.py
4 files changed, 71 insertions(+), 10 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, but someone else must approve
Greg Padgett: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21912
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2357ce26aeb20439dec161c7b8ee46d94a4b3e3d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.3]: restapi: cloud-init - rest api for start vm
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: restapi: cloud-init - rest api for start vm
......................................................................
restapi: cloud-init - rest api for start vm
Support using cloud-init to perform initial setup of virtual machines.
Further details available at:
http://www.ovirt.org/Features/Cloud-Init_Integration
This patch adds support for specifying Cloud-Init configuration when
starting a VM using the REST API.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=990572
Change-Id: I6ad0bfeca23cf8d4b2887010081d63c258032611
Signed-off-by: Greg Padgett <gpadgett(a)redhat.com>
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PayloadEncoding.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/CloudInitValidator.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/VmValidator.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java
9 files changed, 353 insertions(+), 9 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21447
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ad0bfeca23cf8d4b2887010081d63c258032611
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.3]: core: fixing dual sequential PM scenario
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: fixing dual sequential PM scenario
......................................................................
core: fixing dual sequential PM scenario
In case that dual sequential power management cards are defined PM
operations attempt to use the first card (primary) first and only if
that
failed attempt to use the second card (secondary).
When the primary card is not defined correctly the secondary PM fails to
take place.
This patch fixes this issue by insuring that we have a valid proxy host
prior to the secondary PM card operation.
Change-Id: Id88b22f06241c02f12dbc0efe32eb7f04063ed06
Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1013654
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
1 file changed, 23 insertions(+), 16 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21899
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id88b22f06241c02f12dbc0efe32eb7f04063ed06
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months
Change in ovirt-engine[ovirt-engine-3.3]: core: unlock VM on failure to migrate it to server
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: unlock VM on failure to migrate it to server
......................................................................
core: unlock VM on failure to migrate it to server
Recently we changed the MigrateVmCommand to lock the VM for the whole
migration process. When the VM was migrated to server and the migration
failed, we didn't release that lock and the VM would remain locked.
The fact that the handling of failed migrations was spread over the code,
made it more error-prone - things that were added for regular migrations
could have been missing for migrations to server.
This patch extracts the code that should be executed when migration fails
to separate method, and this method is called when migrations to server
fail as well. In particular, the acquired lock is released and therefore
the bug that was previously described is solved.
Change-Id: I282a1fec8ed3f12a8377b2eca8deadc7985d2f66
Bug-Url: https://bugzilla.redhat.com/1033932
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java
2 files changed, 18 insertions(+), 15 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21814
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I282a1fec8ed3f12a8377b2eca8deadc7985d2f66
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 5 months