Change in ovirt-engine[ovirt-engine-3.3]: core: fix audit log on migration rerun failure case
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: fix audit log on migration rerun failure case
......................................................................
core: fix audit log on migration rerun failure case
In a specific case where migration fails, thus the VM is switched back
to Up state in the source and then goes down in the source, we used to
print an audit log message saying that it will be rerun although we
won't try to rerun. So this patch fix that audit log to be the one that
says the migration process failed.
Change-Id: I8e608cbdac5d38f7c3468f57cc563b8a3715359e
Bug-Url: https://bugzilla.redhat.com/1033932
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e608cbdac5d38f7c3468f57cc563b8a3715359e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: engine : Fix for coverity issues introduced in SizeConverter
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: engine : Fix for coverity issues introduced in SizeConverter
......................................................................
engine : Fix for coverity issues introduced in SizeConverter
Fixed warnings due to boxing and then immediately unboxing a primitive
in sizeconverter.
Change-Id: I570e4e69ea6229346c1d20e8f917994c6875eb49
Signed-off-by: Anmol Babu <anbabu(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java
1 file changed, 9 insertions(+), 11 deletions(-)
Approvals:
anmolbabu: Verified
Kanagaraj M: Looks good to me, approved
Sergey Gotliv: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I570e4e69ea6229346c1d20e8f917994c6875eb49
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine-cli[master]: cli: support automatic auth session invalidation #1018561
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: support automatic auth session invalidation #1018561
......................................................................
cli: support automatic auth session invalidation #1018561
Change-Id: I1b8d7400406f8ab918dca01363b9acc5fc0b5224
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1018561
---
M src/ovirtcli/command/connect.py
M src/ovirtcli/infrastructure/options.py
M src/ovirtcli/infrastructure/settings.py
3 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/21945
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b8d7400406f8ab918dca01363b9acc5fc0b5224
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
11 years
Change in ovirt-engine-sdk[master]: sdk: support automatic auth session invalidation #1018559
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: support automatic auth session invalidation #1018559
......................................................................
sdk: support automatic auth session invalidation #1018559
Change-Id: Ibea9edd61b619888210400bc15f07b03a565c641
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1018559
---
M src/codegen/templates/entrypointmethodstemplate
M src/codegen/templates/entrypointtemplate
M src/ovirtsdk/api.py
M src/ovirtsdk/web/connection.py
4 files changed, 44 insertions(+), 15 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21822
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibea9edd61b619888210400bc15f07b03a565c641
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years
Change in ovirt-engine[master]: webadmin: fix remove brick status error message
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: webadmin: fix remove brick status error message
......................................................................
webadmin: fix remove brick status error message
Fixing the error message displayed when remove brick
status is failed. Error message lists the bricks name instead
of volume name. Corrected it to show the volume name.
Change-Id: I8f66f7c7703d5ee6977375f33993a23e1c8d2677
Bug-Url: https://bugzilla.redhat.com/1035146
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Ramesh N: Verified
--
To view, visit http://gerrit.ovirt.org/21906
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f66f7c7703d5ee6977375f33993a23e1c8d2677
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: add validation for DC and SD names
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: add validation for DC and SD names
......................................................................
packaging: setup: add validation for DC and SD names
Change-Id: I1e133b874a1c9ce6bafb2a9f2d18c0400de06e05
Bug-Url: https://bugzilla.redhat.com/1031993
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 80 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e133b874a1c9ce6bafb2a9f2d18c0400de06e05
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-1.0
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-hosted-engine-setup[master]: packaging: setup: add validation for DC and SD names
by sbonazzo@redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: add validation for DC and SD names
......................................................................
packaging: setup: add validation for DC and SD names
Change-Id: I1e133b874a1c9ce6bafb2a9f2d18c0400de06e05
Bug-Url: https://bugzilla.redhat.com/1031993
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M src/plugins/ovirt-hosted-engine-setup/storage/storage.py
1 file changed, 80 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21775
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e133b874a1c9ce6bafb2a9f2d18c0400de06e05
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[ovirt-engine-3.3]: Adding support for user types cleanup
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: Adding support for user types cleanup
......................................................................
Adding support for user types cleanup
The following patch adds support for user-types cleanup in the database.
Call had been added as well to the cleandb function.
Change-Id: I1a7d5a644895be7374febec081e4931be1902962
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1034201
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/common_sp.sql
M packaging/dbscripts/dbfunctions.sh
M packaging/setup/ovirt_engine_setup/database.py
3 files changed, 23 insertions(+), 6 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a7d5a644895be7374febec081e4931be1902962
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: gluster: Show the wait icon if task status UNKNOWN
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: gluster: Show the wait icon if task status UNKNOWN
......................................................................
gluster: Show the wait icon if task status UNKNOWN
Modified to display the question mark icon if the task
status of rebalance / remove bricks is UNKNOWN.
This is required if task is in progress and because of storage nodes
down the status is returned as UNKNOWN.
Change-Id: I525231ea4127b247350fcb1f282a8592ae08a895
Bug-Url: https://bugzilla.redhat.com/1035601
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VolumeActivityStatusCell.java
2 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Kanagaraj M: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/21914
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I525231ea4127b247350fcb1f282a8592ae08a895
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: anmolbabu <anbabu(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years
Change in ovirt-engine[master]: restapi: add replica count parameter to rsdl for remove brick
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: restapi: add replica count parameter to rsdl for remove brick
......................................................................
restapi: add replica count parameter to rsdl for remove brick
Adding replica count as an optional parameter to remove brick
action in rsdl. Bricks resource is using this parameter but
it is missing in RSDL
Change-Id: Ice0271453cef97cef67d1ca8e767aa1558d6bb3a
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Ramesh N: Verified
--
To view, visit http://gerrit.ovirt.org/21824
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice0271453cef97cef67d1ca8e767aa1558d6bb3a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years