December 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: restapi: Remove restriction of vnic profile's network
by iheim＠redhat.com 04 Dec '13

04 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: restapi: Remove restriction of vnic profile's network ...................................................................... restapi: Remove restriction of vnic profile's network The schema shouldn't restrict the minimal occurrences of the vnic profile's network property. Change-Id: Id17697e1e87c7240bec85056896d8151c39667c8 Bug-Url: https://bugzilla.redhat.com/1031925 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22032 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id17697e1e87c7240bec85056896d8151c39667c8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: Only carry on with import if network added
by lvernia＠redhat.com 04 Dec '13

04 Dec '13

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Only carry on with import if network added ...................................................................... webadmin: Only carry on with import if network added When importing a network from a provider, a sequence of backend commands is triggered; first creation of a network, then attachment to cluster and in the end creation of a default vNIC profile. Previously the succeess of the network creation wasn't verified, leading to confusing errors from the succeeding backend commands. This is fixed here. Change-Id: Ie718f92f724f71e6e9d02ad19e4c7912efe5bb94 Bug-Url: https://bugzilla.redhat.com/1031366 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie718f92f724f71e6e9d02ad19e4c7912efe5bb94 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: make method and field names start with lowercase lette...
by emesika＠redhat.com 04 Dec '13

04 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: make method and field names start with lowercase letter in vdsbroker ...................................................................... core: make method and field names start with lowercase letter in vdsbroker Change-Id: I9cd54e80f13525e0cd09f09ba05eb64e8681c32d Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CreateVmFromSysPrepVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceStatusReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/FenceVdsVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetAllTasksInfoVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetAllTasksStatusesVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetTaskStatusVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskInfoListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskStatusListReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/TaskStatusReturnForXmlRpc.java 10 files changed, 19 insertions(+), 19 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/22033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cd54e80f13525e0cd09f09ba05eb64e8681c32d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename to lowercase methods in bll and vdsbroker
by emesika＠redhat.com 04 Dec '13

04 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: rename to lowercase methods in bll and vdsbroker ...................................................................... core: rename to lowercase methods in bll and vdsbroker Change-Id: Iee716e612e43a77e7ed668654a858c42c51b2a9f Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 4 files changed, 6 insertions(+), 6 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee716e612e43a77e7ed668654a858c42c51b2a9f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.3]: rest: fix rsdl for cloud-init parameters
by iheim＠redhat.com 04 Dec '13

04 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: rest: fix rsdl for cloud-init parameters ...................................................................... rest: fix rsdl for cloud-init parameters fix error with brackets in cloud init parameters for run vm rsdl definition. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=990572 Change-Id: Ia030c57d7315f8c55e384c79e207144bc5f7e4a9 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia030c57d7315f8c55e384c79e207144bc5f7e4a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Remove restriction of vnic profile's network
by masayag＠redhat.com 04 Dec '13

04 Dec '13

Moti Asayag has submitted this change and it was merged. Change subject: restapi: Remove restriction of vnic profile's network ...................................................................... restapi: Remove restriction of vnic profile's network The schema shouldn't restrict the minimal occurrences of the vnic profile's network property. Change-Id: Id17697e1e87c7240bec85056896d8151c39667c8 Bug-Url: https://bugzilla.redhat.com/1031925 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id17697e1e87c7240bec85056896d8151c39667c8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi(a)eldorado.org.br> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix typos in comments
by emesika＠redhat.com 04 Dec '13

04 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fix typos in comments ...................................................................... core: fix typos in comments Change-Id: I83a7bd55f84379d63355fa144698c4cb1db60c6d Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22025 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83a7bd55f84379d63355fa144698c4cb1db60c6d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: fix uppercase methods
by emesika＠redhat.com 04 Dec '13

04 Dec '13

Eli Mesika has submitted this change and it was merged. Change subject: core: fix uppercase methods ...................................................................... core: fix uppercase methods This patch renames OnTimer to onTimer in different scheduled tasks in the engine. Change-Id: I5028bc025c540c1eefec00f63e512e5ec8d91c8a Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AuditLogCleanupManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 4 files changed, 15 insertions(+), 15 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5028bc025c540c1eefec00f63e512e5ec8d91c8a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: supress 2 findbugs in ConfigDaoImpl
by oourfali＠redhat.com 04 Dec '13

04 Dec '13

Oved Ourfali has submitted this change and it was merged. Change subject: engine: supress 2 findbugs in ConfigDaoImpl ...................................................................... engine: supress 2 findbugs in ConfigDaoImpl Supress (exclude) 2 findbugs warnings in ConfigDaoImpl since they are not correct. Change-Id: I979843feb986b5424d986f00abdd0d442817c066 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/tools/exclude-filters.xml 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Alissa Bonas: Verified Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22027 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I979843feb986b5424d986f00abdd0d442817c066 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: Revert "Adding support for user types cleanup"
by iheim＠redhat.com 04 Dec '13

04 Dec '13

Itamar Heim has submitted this change and it was merged. Change subject: Revert "Adding support for user types cleanup" ...................................................................... Revert "Adding support for user types cleanup" This reverts commit d953002370f78293ee5e9783f60e30aa0a5336d1. The user_defined_types view was added in 9.2 only , we shall find a workaround for that in versions below 9.2 http://www.postgresql.org/docs/9.2/static/infoschema-user-defined-types.html Change-Id: I6f9cf106759da4e2fb2ca632c3d8a5acf86b50a9 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M packaging/dbscripts/common_sp.sql M packaging/dbscripts/dbfunctions.sh M packaging/setup/ovirt_engine_setup/database.py 3 files changed, 6 insertions(+), 23 deletions(-) Approvals: Itamar Heim: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6f9cf106759da4e2fb2ca632c3d8a5acf86b50a9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0