February 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine-sdk[master]: codegen: implement generic URI processing

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: codegen: implement generic URI processing ...................................................................... codegen: implement generic URI processing Change-Id: I36d3914a0b8f639d0d6a32d1cc3ef18e6fb63541 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/rsdl/rsdlcodegen.py M src/ovirtsdk/infrastructure/brokers.py 2 files changed, 53 insertions(+), 18 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36d3914a0b8f639d0d6a32d1cc3ef18e6fb63541 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

11 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix test break in LiveMigrateVmDisksCommand

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: Fix test break in LiveMigrateVmDisksCommand ...................................................................... core: Fix test break in LiveMigrateVmDisksCommand Change-Id Ifefe823faa8e546eba3e9d34c4b46609085baad8 changed the semantics of how storage domains were validated, which broke the unit test. This patch mocks the storage domain ID on the image correctly, so the test can continue functioning. Change-Id: I79162cffafcfd385fdced56e23e6e005828c21f9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I79162cffafcfd385fdced56e23e6e005828c21f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

11 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: AsyncTask manger part 2 - vms scenario

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: engine: AsyncTask manger part 2 - vms scenario ...................................................................... engine: AsyncTask manger part 2 - vms scenario The following fix should solve a following paroblem: 1. Part of vm scenarios are creating async task with out parent and child task thats why appropriate check should be added to EntityAsyncTask 2. Fixing also VdcActionParametersBase accordingly, because of imageParameters are not passed to DB Change-Id: I43320dfb32a2477308cd881cb7d27c49f3f9f346 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java 4 files changed, 16 insertions(+), 29 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43320dfb32a2477308cd881cb7d27c49f3f9f346 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Fix audit log for network on multiple interfaces

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Fix audit log for network on multiple interfaces ...................................................................... engine: Fix audit log for network on multiple interfaces The patch fixes the place holder name inside the properties file to be a correlated with the parameter within the code. Change-Id: Ibda3f6e6d78a0fed2ea2b5d7879d717f859793e8 Bug-Url: https://bugzilla.redhat.com/881055 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibda3f6e6d78a0fed2ea2b5d7879d717f859793e8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

11 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Refactoring in unassign network from cluster command

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Refactoring in unassign network from cluster command ...................................................................... engine: Refactoring in unassign network from cluster command Refactored some code in DetachNetworkToVdsGroupCommand to reuse code from NetworkValidator. As part of the refactoring added to the error message the list of VMs/templates using the network, if it was used, simply by using the internal implementation of the validation in NetworkValidator. Change-Id: I127615d9144084ad093ac1d20841979be8163a12 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=746912 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkToVdsGroupCommand.java 1 file changed, 38 insertions(+), 67 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/10683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I127615d9144084ad093ac1d20841979be8163a12 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

11 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Refactored code into NetworkValidator class

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Refactored code into NetworkValidator class ...................................................................... engine: Refactored code into NetworkValidator class The NetworkValidator class handles network validation on the data center level, and is instantiated on a per-network basis. This validation had previously been performed by the NetworkCommon class and its derived classes, but now the NetworkValidator may be used as a service provider. A corresponding test class is added. While refactoring fixed inconsistency bug related to add/update network commands. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=905479 Change-Id: Icf40d81f0481c6b6dec141a71363888dc9e9a941 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java 7 files changed, 582 insertions(+), 201 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/10940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf40d81f0481c6b6dec141a71363888dc9e9a941 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

11 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Failed to add VM network interface from User Porta...

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Failed to add VM network interface from User Portal ...................................................................... webadmin: Failed to add VM network interface from User Portal ConfigurationValues.ManagementNetwork doesn't have ConfigAuthType.User. It means user role can't determine this value. The user shouldn't know what is the management network. If the management network can't be determined the default network should be the first network in the list. Change-Id: I77a15bd0d9d290c8f7e2673f0e0039d70f125c1b Bug-Url: https://bugzilla.redhat.com/912005 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmInterfaceModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12137 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77a15bd0d9d290c8f7e2673f0e0039d70f125c1b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

11 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Cleanup of GetSystemStatisticsQuery

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Cleanup of GetSystemStatisticsQuery ...................................................................... core: Cleanup of GetSystemStatisticsQuery Replaced all hard coded strings with contstants, extracted logic to separate methods, renamed variables by Java standard and other minor changes Change-Id: Ibb87448c24c6ac32838ae2e381856f478c27ea52 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetSystemStatisticsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/QueryConstants.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java 3 files changed, 77 insertions(+), 77 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb87448c24c6ac32838ae2e381856f478c27ea52 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

11 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core, restapi: Replaced system stats query fields with const...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core, restapi: Replaced system stats query fields with constants ...................................................................... core, restapi: Replaced system stats query fields with constants Replaced the hard coded String fields returning in GetSystemStatistics query to constants, also changed the call to this query in the REST to use the contstants when parsing the result Change-Id: I1a2e3fc22c4c8228ec9362d1fb2a608c4db4746c Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetSystemStatisticsQuery.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/constants/QueryConstants.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java 3 files changed, 40 insertions(+), 19 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12143 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a2e3fc22c4c8228ec9362d1fb2a608c4db4746c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

11 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: MigrateVmDisks - get source domain by disk

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: MigrateVmDisks - get source domain by disk ...................................................................... core: MigrateVmDisks - get source domain by disk LiveMigrateVmDisksCommand - source storage domain should be retrieved from the operated disk instead of the command parameters (only a disk that resides on a single storage domain can be moved). Change-Id: Ifefe823faa8e546eba3e9d34c4b46609085baad8 Bug-Url: https://bugzilla.redhat.com/883871 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 1 file changed, 9 insertions(+), 11 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifefe823faa8e546eba3e9d34c4b46609085baad8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

11 years, 7 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits February 2013