Change in ovirt-engine[master]: core: Fix UpdateVm permissions check for Quota
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: Fix UpdateVm permissions check for Quota
......................................................................
core: Fix UpdateVm permissions check for Quota
Quota permissions were checked regardless of the vm state
(running/stopped), the quota enforcement mode (Audit/enforcing) and the
change in quota selection box.
addQuotaPermissionSubject was change to check for quota consumption permissions only
if the quota was changed & quota is Enforced & vm is running.
Otherwise, User could edit vm without having quota consumption
permissions.
Change-Id: Ib55016efcbed22b003eaddf5c4f8f62aec88928e
Bug-Url: https://bugzilla.redhat.com/904105
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
2 files changed, 14 insertions(+), 3 deletions(-)
Approvals:
ofri masad: Verified
Gilad Chaplik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11418
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib55016efcbed22b003eaddf5c4f8f62aec88928e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core:Use audit log on disk finish action
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Use audit log on disk finish action
......................................................................
core:Use audit log on disk finish action
Direct lun disk should only log it finished the action, since there is no
use of tasks in the process.
We also should log when remove disk ends for all type of disks.
Change-Id: I22b145fbc12481e40eaa8329eb8ce35f7c39a320
Bug-Url: https://bugzilla.redhat.com/910693
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
3 files changed, 21 insertions(+), 4 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12011
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I22b145fbc12481e40eaa8329eb8ce35f7c39a320
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: liron aravot <liron.aravot(a)gmail.com>
11 years, 7 months
Change in ovirt-engine[master]: engine: AsyncTaskManager - restart fix part 1 (Logic)
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: AsyncTaskManager - restart fix part 1 (Logic)
......................................................................
engine: AsyncTaskManager - restart fix part 1 (Logic)
The following fix should change a current behaviour which is:
During creation child command which is asynchronious a parameters of parent
command are saved in DB (this ok), but parameters of parent comand also contains a list
of parameters of child commands (sic!).
So a first child command created we save a parent command with list of one command,
second command created list with two commands and etc...
After a restart and random child is choosen, so we have a random number of child parameters.
By the way , if list of child parameters is updated after saving a task to db, we will never have a correct list
(Example can be seen in one of the next patches)
Solution, save to DB parent parameters and appropriate child command parameter, during endAction() bnuild a list
of parameters.
One of the known bugs (a lot of unknown): During preview on vm after all task are send to host, perform restart.
All task are send, all task finished successfully, but disk still left in status Locked and the number of disks is
random
Benefits:
1. Bug is solved
2. Reduced serialization and desirialization (by current situation we have O(n^2) serialization/deserialization operations)
3. Most of the logic moved to the same place, no need to copy paste it all over a project
4. No need to make work arounds all over a project
What is still not solved:
If we will fail in the middle of task creation, we will not know if all task that we have that all tak that we wanted to start,
the fix is easy and will be send soon
Change-Id: I06507f537b2de0dc358a59aa27e62cbb042ccbb1
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskFactory.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java
6 files changed, 40 insertions(+), 19 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12128
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I06507f537b2de0dc358a59aa27e62cbb042ccbb1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: engine: AsyncTaskManager - fix restart part 1 (DB)
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: AsyncTaskManager - fix restart part 1 (DB)
......................................................................
engine: AsyncTaskManager - fix restart part 1 (DB)
The following patch contains a changes for DB schema which is required in order to solve
a problem.
The changes are: added a new two collums to async_task table.
Those columns are respresenting a parameters of command which is associated with task
Change-Id: I3beb5c4a675c567abdf789f40c26fd9fa0a1fb4d
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/dbscripts/async_tasks_sp.sql
A backend/manager/dbscripts/upgrade/03_02_0460_add_async_task_task_parameters.sql
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AsyncTaskDAOTest.java
4 files changed, 41 insertions(+), 11 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12129
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3beb5c4a675c567abdf789f40c26fd9fa0a1fb4d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: engine: AsyncTaskManager - fix restart part 1 (Clean ups)
by mkublin＠redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: AsyncTaskManager - fix restart part 1 (Clean ups)
......................................................................
engine: AsyncTaskManager - fix restart part 1 (Clean ups)
The following patch contains a clean ups, the following code is not needed anymore
after introducing a fix.
Also at some classes like AddVmFromTemplateCommand we can see that child parameters are
added to list only after persist of the task to DB, so after a restart we will never have
a task which have a parent parameters with all list of child parameters (sic!)
Change-Id: I2c8c26b79df08a139c6bd19b28dd376ba69829ca
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/IEndedTaskVisitor.java
D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/SetTaskGroupStatusVisitor.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonVdcActionParametersBaseMixIn.java
20 files changed, 6 insertions(+), 62 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12130
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c8c26b79df08a139c6bd19b28dd376ba69829ca
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core: Add VDSM missing error messages.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add VDSM missing error messages.
......................................................................
core: Add VDSM missing error messages.
Add missing VDSM messages to the engine.
After this fix, ReleaseLockFailure and AcquireHostIdFailure will cause fail over,
while the other errors will not.
Change-Id: Id8395c75bbba1f66d08bcd9c21fdeacc7f5e6d4f
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
4 files changed, 37 insertions(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8958
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8395c75bbba1f66d08bcd9c21fdeacc7f5e6d4f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core: Add storage space validation to removeSnapshot
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add storage space validation to removeSnapshot
......................................................................
core: Add storage space validation to removeSnapshot
Today there is no validation in RemoveSnapshotCommand to ensure there is enough
space on the domain to merge the disk snapshots.
This space is needed on remove snapshot process since VDSM creates a new
temporary volume, as part of the merge process, which might be large as
the volume's actual size.
The proposed fix introduces a new validation in the command which
validates whether each storage domain has enough free space to perform removeSnapshot.
Change-Id: Ifbebc5af8e7489bccfa5d8e79695fe21c5371ec9
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java
4 files changed, 217 insertions(+), 3 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11849
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbebc5af8e7489bccfa5d8e79695fe21c5371ec9
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core: remove unneeded set of parameters member
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: remove unneeded set of parameters member
......................................................................
core: remove unneeded set of parameters member
During ImportVm, the addStorageDomainMapping flag is set without need,
it's ignored during the execute phase of move or copy all image group
command when the parent command is import vm command and can cause to
unneeded deletion of source image mapping during the endWithFailure method.
Change-Id: I55bed0b63faef266cfc30fd8193238ee9dc1163d
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12151
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I55bed0b63faef266cfc30fd8193238ee9dc1163d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 7 months
Change in ovirt-engine[master]: core: Added LexoNumericComparator utility
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Added LexoNumericComparator utility
......................................................................
core: Added LexoNumericComparator utility
This utility helps to sort strings which include numeric subsequences
according to sensible ordering - sorting numeric subsequences
numerically, and the rest lexicographically.
A corresponding test class is added.
Change-Id: I8c68446ea6f1865a51455a0a359df339bfb15bba
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/LexoNumericComparator.java
A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/LexoNumericComparatorTest.java
2 files changed, 179 insertions(+), 0 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/11996
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c68446ea6f1865a51455a0a359df339bfb15bba
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 7 months
Change in ovirt-engine-cli[master]: cli: ovirt-shell misleading help for command "connect"(#9079...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: ovirt-shell misleading help for command "connect"(#907943)
......................................................................
cli: ovirt-shell misleading help for command "connect"(#907943)
ovirt-shell does not allow the use of show command before being
connected to the engine. The help connect message however has
refernce to see show command for more details.
This patch corrects the help message for connect by removing the
refernce to the show command
Change-Id: Ifcea649dcd44c87c9f9dff0fa4b65ac9c2449c32
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=907943
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M src/ovirtcli/command/connect.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11939
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcea649dcd44c87c9f9dff0fa4b65ac9c2449c32
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
11 years, 7 months