February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine-cli[master]: Use vncviewer passwordFile instead of passwdInput
by mpastern＠redhat.com 10 Feb '13

10 Feb '13

Michael Pasternak has submitted this change and it was merged. Change subject: Use vncviewer passwordFile instead of passwdInput ...................................................................... Use vncviewer passwordFile instead of passwdInput Fedora 18 has dropped the patch to add passwdInput option to tigervnc Change-Id: I76178f15217c421d88879c88534d7cb3a7583426 Signed-off-by: Sander Hoentjen <sander(a)hoentjen.eu> --- M src/cli/messages.py M src/ovirtcli/platform/posix/vnc.py 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Looks good to me, approved Ewoud Kohl van Wijngaarden: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11857 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76178f15217c421d88879c88534d7cb3a7583426 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Sander Hoentjen <sander(a)hoentjen.eu> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Sander Hoentjen <sander(a)hoentjen.eu>

1 0

Change in ovirt-engine[master]: core: Add isEmpty Check to MacPoolManager
by masayag＠redhat.com 10 Feb '13

10 Feb '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Add isEmpty Check to MacPoolManager ...................................................................... core: Add isEmpty Check to MacPoolManager This patch adds an isEmpty() check to the freeMacs method, in the MacPoolManager, to avoid entering a synchronized block when unnecessary. Change-Id: Id34bae38c0a05e1e148267950ca1ca464b36daea Bug-Url: https://bugzilla.redhat.com/903572 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java 1 file changed, 12 insertions(+), 10 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id34bae38c0a05e1e148267950ca1ca464b36daea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove Mac Addresses When DC Removed
by masayag＠redhat.com 10 Feb '13

10 Feb '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove Mac Addresses When DC Removed ...................................................................... core: Remove Mac Addresses When DC Removed This patch removes the Mac Addresses of the vNics that are under the Data Center that is being removed. Change-Id: I5b6d473b4921de12fbd68bdaf2fc058662ed3a06 Bug-Url: https://bugzilla.redhat.com/903572 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/dbscripts/network_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoDbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 7 files changed, 101 insertions(+), 2 deletions(-) Approvals: Muli Salem: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11796 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b6d473b4921de12fbd68bdaf2fc058662ed3a06 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: notifier: resource leak using all available db connections
by yzaslavs＠redhat.com 08 Feb '13

08 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: notifier: resource leak using all available db connections ...................................................................... notifier: resource leak using all available db connections Only initialize the data source once instead of each event loop, preventing existing connections from being orphaned. Change-Id: Ib7db8bdd66ca8f6412b1ef709c141b0b97dffbfb Bug-Url: https://bugzilla.redhat.com/905709 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java 1 file changed, 1 insertion(+), 16 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7db8bdd66ca8f6412b1ef709c141b0b97dffbfb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Empty SetupNetworksCommand isn't sent to VDSM
by masayag＠redhat.com 07 Feb '13

07 Feb '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Empty SetupNetworksCommand isn't sent to VDSM ...................................................................... engine: Empty SetupNetworksCommand isn't sent to VDSM Changed the SetupNetworksCommand so that if it doesn't change anything in a host's network configuration, it does nothing (instead of sending an empty command to VDSM) and returns success. Change-Id: Ib68eeb1e7e75aea7b0730ee4650675fd2b9d37cd Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=904743 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksCommand.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Lior Vernia: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11750 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib68eeb1e7e75aea7b0730ee4650675fd2b9d37cd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: packaging: Updated fetching db params from pgpass
by kroberts＠redhat.com 07 Feb '13

07 Feb '13

Keith Robertson has submitted this change and it was merged. Change subject: packaging: Updated fetching db params from pgpass ...................................................................... packaging: Updated fetching db params from pgpass Change-Id: Ic28e0d1da86bc1a8c7ba909aad3cd541bab80e36 Bug-Url: https://bugzilla.redhat.com/908129 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M src/__main__.py 1 file changed, 35 insertions(+), 30 deletions(-) Approvals: Keith Robertson: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic28e0d1da86bc1a8c7ba909aad3cd541bab80e36 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-reports[master]: reports: added branded tab icon
by ydary＠redhat.com 07 Feb '13

07 Feb '13

Yaniv Dary has submitted this change and it was merged. Change subject: reports: added branded tab icon ...................................................................... reports: added branded tab icon Change-Id: Ib6596a6bb244529c199de831851566e66b640b14 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A server-customizations/favicon.ico 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11848 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib6596a6bb244529c199de831851566e66b640b14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: slave interfaces are being overridden
by masayag＠redhat.com 07 Feb '13

07 Feb '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: slave interfaces are being overridden ...................................................................... engine: slave interfaces are being overridden When the client provides a bond with its slaves, the slaves are being reloaded from the engine, causing the information not provided by the client to be populated by the engine's nics data. In order to unset previously configured slave configuration, the client need to specifically override it so the unsupported slave's configuration will be unset, if the slave was previously configured with any of the following properties: network name, vlan notation, boot protocol, IP address, gateway or netmask. An attempt to provide a slave which isn't configured properly will be blocked by the engine with a can-do-action message. Change-Id: I4f38bc399059ad19e93fcad0f360957636ac7045 Bug-Url: https://bugzilla.redhat.com/907240 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 44 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f38bc399059ad19e93fcad0f360957636ac7045 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: align luns volume_group_id
by amureini＠redhat.com 07 Feb '13

07 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: align luns volume_group_id ...................................................................... core: align luns volume_group_id LUNs that were previously persisted using REST might have a null volume group id while the current value used in the engine is "", this patch fixes it and set it to "" as well. Change-Id: Ia3f3055ae1496a4ad5f041933fcabbd1dadee2b1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=906360 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0400_align_lun_volume_group_id.sql M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/LunDAOTest.java 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/11807 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia3f3055ae1496a4ad5f041933fcabbd1dadee2b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core,ui: fix test duplicate keys
by derez＠redhat.com 07 Feb '13

07 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: core,ui: fix test duplicate keys ...................................................................... core,ui: fix test duplicate keys Fix path of DuplicateKeysTest so it will work properly in Windows environment too. Change-Id: Id0467adc8a9b03c300aeb60dc752bf685c50b128 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- R frontend/webadmin/modules/webadmin/src/test/java/org/ovirt/engine/ui/webadmin/DuplicateKeysTest.java 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11842 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0467adc8a9b03c300aeb60dc752bf685c50b128 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0