February 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: engine: Replace NetworkDaoDbFacadeImpl.getByName()

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Replace NetworkDaoDbFacadeImpl.getByName() ...................................................................... engine: Replace NetworkDaoDbFacadeImpl.getByName() Old call was using an archaic API, replace by the standard way to run JDBCTemplate queries. Change-Id: I18ced945229f34ce6a042ae6f46970e6b2b0f395 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoDbFacadeImpl.java 1 file changed, 3 insertions(+), 10 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18ced945229f34ce6a042ae6f46970e6b2b0f395 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Add management network validation

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add management network validation ...................................................................... engine: Add management network validation This check will make sure that if we're attaching or editing a management network's attachment on a cluster, then the attachment will be properly validated (i.e. the network must be required). Change-Id: I1e035f009796f989072601cc67a51fd8bbd6947b Bug-Url: https://bugzilla.redhat.com/875488 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/UpdateNetworkOnClusterCommand.java 2 files changed, 22 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e035f009796f989072601cc67a51fd8bbd6947b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Add validator for NetworkCluster

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Add validator for NetworkCluster ...................................................................... engine: Add validator for NetworkCluster This validator will hold checks that are necessary to perform on this entity, such as making sure the management network attachment is valid. Change-Id: Iba58dfbd9950176ba26790ff6a50244d554fd9b3 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/NetworkClusterValidatorTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 74 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba58dfbd9950176ba26790ff6a50244d554fd9b3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Added management network check

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Added management network check ...................................................................... engine: Added management network check Added a method for determining if a network is a management network. Change-Id: I27844da800326e338ec193b4ffd1fb2ee6aef034 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/cluster/AttachNetworkToVdsGroupCommandTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NetworkUtilsTest.java 3 files changed, 57 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27844da800326e338ec193b4ffd1fb2ee6aef034 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Fix ValidationResult

by mkolesni＠redhat.com

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Fix ValidationResult ...................................................................... engine: Fix ValidationResult 1. Changed equals not to use instanceof since the class is final. 2. Added variable replacements to the TSEHC (toString/equals/hashCode) methods since it's part of the object's identity. Change-Id: I6faefd9926c241055fc4957ce3c639308ef5833f Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicValidatorTest.java 3 files changed, 24 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11834 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6faefd9926c241055fc4957ce3c639308ef5833f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: allow interactive NFS exports cleanup with engine...

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: allow interactive NFS exports cleanup with engine-cleanup ...................................................................... packaging: allow interactive NFS exports cleanup with engine-cleanup When running engine-cleanup the user will be asked for removing any configuration made by engine-setup in /etc/exports and for removing the directories that were previously exported. When running in unattended mode use the -n and -e options for deciding what to do about the NFS exports. If any change is made to /etc/exportfs, the NFS exports will be refreshed and the file will be backed up. Change-Id: I0548ab358d0cbed32ceff3ceacefc57f1c068df4 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=904149 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/nfsutils.py 2 files changed, 99 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0548ab358d0cbed32ceff3ceacefc57f1c068df4 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Add login action group to NetworkUser role

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Add login action group to NetworkUser role ...................................................................... core: Add login action group to NetworkUser role For the sake of consistency with the other predefined roles, the NetworkUser is being extended with Login action group (code 1300). Therefore with this patch users with NetworkUser role only will be capable to login into the User Portal. Change-Id: Ib31ebaeabbe4f3b8bebae09dd451f9ef8b507e47 Bug-Url: https://bugzilla.redhat.com/894698 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0410_add_login_permission_to_network_user_role.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib31ebaeabbe4f3b8bebae09dd451f9ef8b507e47 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix Device and Network Unit Test

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix Device and Network Unit Test ...................................................................... core: Fix Device and Network Unit Test Change-Id: Ifde7b681e94328f4b6c0a63cff48bc588c0cddb6 Bug-Url: https://bugzilla.redhat.com/903572 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11875 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifde7b681e94328f4b6c0a63cff48bc588c0cddb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Remove ObjectCompareUtils class

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove ObjectCompareUtils class ...................................................................... core: Remove ObjectCompareUtils class The class was used at the time of moving from C# to Java in order to maintain compatability, now it's no longer needed Change-Id: I11ee527a1825c2d88b2a812b784638de06108079 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectCompareUtils.java 1 file changed, 0 insertions(+), 150 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11809 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11ee527a1825c2d88b2a812b784638de06108079 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Remove UTF8EncodingCompat class

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove UTF8EncodingCompat class ...................................................................... core: Remove UTF8EncodingCompat class The class was used at the time of moving from C# to Java in order to maintain compatability, now it's no longer needed Change-Id: I0eaa28f0b5df5a1992b19371d133c5f8f489359f Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/UTF8EncodingCompat.java 1 file changed, 0 insertions(+), 23 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0eaa28f0b5df5a1992b19371d133c5f8f489359f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

11 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits February 2013