February 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: Bypassing findbugs issue of incorrect lazy initial...

by asaf＠redhat.com

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Bypassing findbugs issue of incorrect lazy initialization. ...................................................................... webadmin: Bypassing findbugs issue of incorrect lazy initialization. Findbug is referencing a potential threading issue where in a multi thread environment, there would be potential situation where the lazy initialization of windowsOsTypes in AsyncDataProvider:getWindowsOsTypes() will creat more than once instnace. With GWT, synchronizing the method has no meaning except bypassing findbugs warning as the code compiles to javascript and is executed in single thread anyway. Change-Id: I599d8418bf6e326564354e6173603fd974af1a7a Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I599d8418bf6e326564354e6173603fd974af1a7a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

11 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: A NPE check in SetupNetworksModel:onEdit

by asaf＠redhat.com

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: A NPE check in SetupNetworksModel:onEdit ...................................................................... webadmin: A NPE check in SetupNetworksModel:onEdit There's a possible branch of statement, that if executed a null value will be dereferenced. this patch verifies that the model editPopup is not null before dereferenced. Change-Id: I165a3f298bc306d65cefceef3a8dfd24dc366774 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I165a3f298bc306d65cefceef3a8dfd24dc366774 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

11 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: A NPE check in ImportVmModel:init method.

by asaf＠redhat.com

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: A NPE check in ImportVmModel:init method. ...................................................................... webadmin: A NPE check in ImportVmModel:init method. There's a possible branch of statement, that if executed a null value will be dereferenced. this patch verifies that the var dataCenter is not null before using it. Change-Id: Icdba43d13299d0768c1449c450de61cb6b0a3df9 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11723 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdba43d13299d0768c1449c450de61cb6b0a3df9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

11 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Check for NPE in AsyncDataProvider:GetInterfaceOpt...

by asaf＠redhat.com

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Check for NPE in AsyncDataProvider:GetInterfaceOptionsForEditNetwork ...................................................................... webadmin: Check for NPE in AsyncDataProvider:GetInterfaceOptionsForEditNetwork There's a possible branch of statement, that if executed a null value will be dereferenced. this patch verifies that the var is not null before using it. Change-Id: Iba10d8a40e414e18fa6a87024dad9e1ed6a69bc7 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11722 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba10d8a40e414e18fa6a87024dad9e1ed6a69bc7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

11 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Non-VM networks not being detached from cluster

by alkaplan＠redhat.com

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Non-VM networks not being detached from cluster ...................................................................... webadmin: Non-VM networks not being detached from cluster Non-vm network property wasn't cloned when cloning network. It caused some bugs- - The user couldn't detach non-vm network from the cluster. - Non-VM networks shown as VM networks on cluster attachment dialog. Change-Id: I69415097f4c7d253225cb57f545df398b36d0261 Bug-Url: https://bugzilla.redhat.com/906291 Bug-Url: https://bugzilla.redhat.com/906289 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69415097f4c7d253225cb57f545df398b36d0261 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

11 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Fixing infinent loop in NewGuideVmInterfaceModel.

by asaf＠redhat.com

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Fixing infinent loop in NewGuideVmInterfaceModel. ...................................................................... webadmin: Fixing infinent loop in NewGuideVmInterfaceModel. Fix for the static invocation of NewGuideVmInterfaceModel.createInstance from the same method, which causes an infinent loop. Change-Id: I94b0db601a0b88b8083eabd5e285bdb1b3168d38 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewGuideVmInterfaceModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94b0db601a0b88b8083eabd5e285bdb1b3168d38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>

11 years, 4 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Renamed EventListModel.forceRefresh->forceRefreshW...

by asaf＠redhat.com

Asaf Shakarchi has submitted this change and it was merged. Change subject: webadmin: Renamed EventListModel.forceRefresh->forceRefreshWithoutTimers. ...................................................................... webadmin: Renamed EventListModel.forceRefresh->forceRefreshWithoutTimers. Renamed EventListModel.forceRefresh() to forceRefreshWithoutTimers() to avoid confusion with ForceRefresh:ForceRefresh(). Change-Id: Ic3fa5c0aea31163099c26ff980439b4446b5471e Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/SubTabEventListModel.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11720 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3fa5c0aea31163099c26ff980439b4446b5471e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

11 years, 4 months

1
0
0 / 0

Change in ovirt-engine[engine_3.2]: compat: convert to base64 without line feed

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: compat: convert to base64 without line feed ...................................................................... compat: convert to base64 without line feed This is regression of change Ie7a540d9c69, as the ticketing base64 conversion should not contain line feed. Change-Id: I33790b47ede99eade178b488a66cd8cc280cb872 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/engineencryptutils/src/main/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/Ticketing.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11611 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33790b47ede99eade178b488a66cd8cc280cb872 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 4 months

1
0
0 / 0

Change in ovirt-engine[engine_3.2]: host-deploy: use tar instead of python tarfile

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: host-deploy: use tar instead of python tarfile ...................................................................... host-deploy: use tar instead of python tarfile python usage was introduced when fedora-18 alpha lacked tar utility, now fedora-18 has tar utility and the python implementation is too buggy. It does not treat trailing zeros of tarfile correctly, causing the deployment to fail. Change-Id: I9ece009af7d0c1800eb69b1ca99930892903fe9f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ece009af7d0c1800eb69b1ca99930892903fe9f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

11 years, 4 months

1
0
0 / 0

Change in ovirt-engine[engine_3.2]: engineencryptutils: test: add encrypt/decrypt test

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: engineencryptutils: test: add encrypt/decrypt test ...................................................................... engineencryptutils: test: add encrypt/decrypt test Change-Id: Ia0e623ac0d88a2244c49173f76afa454f39090e3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/engineencryptutils/src/test/java/org/ovirt/engine/core/engineencryptutils/EncryptionUtilsTest.java A backend/manager/modules/engineencryptutils/src/test/resources/key.p12 2 files changed, 66 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11533 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0e623ac0d88a2244c49173f76afa454f39090e3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 4 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits February 2013