February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove user_sessions table
by amureini＠redhat.com 10 Feb '13

10 Feb '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove user_sessions table ...................................................................... core: Remove user_sessions table The user_sessions table is part of the old login/logout mechanism, which is no longer in use. Before this patch, the table still existed, as well as code that queries it and deletes from it, but no occurrences of inserting or updating it, which means it was effectively useless. This patch drops it from the database, and removes any remnants of code that still reference it, including the session_count column of the users table (and the corresponding members of the DbUser class). Change-Id: I46952752950dcfeb4f917d532b80f15df7ff19c6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0420_remove_user_session.sql M backend/manager/dbscripts/user_sp.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/session/SessionDataContainer.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/session/SessionDataContainerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/user_sessions.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/user_sessions_id.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DbUserDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DbUserDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 12 files changed, 18 insertions(+), 647 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46952752950dcfeb4f917d532b80f15df7ff19c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix typos in method names, log and comments
by tnisan＠redhat.com 10 Feb '13

10 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix typos in method names,log and comments ...................................................................... core: Fix typos in method names,log and comments Fix typos in method names (and the places which use those methods), comments and log statements in several commands. Change-Id: I2dce88f1ef0ab7ce3b57dce14142e08ce838c70d Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmToServerCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OvfDataUpdater.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java 13 files changed, 26 insertions(+), 26 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dce88f1ef0ab7ce3b57dce14142e08ce838c70d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding exclusive lock (by name) to ImportVmCommand
by yzaslavs＠redhat.com 10 Feb '13

10 Feb '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Adding exclusive lock (by name) to ImportVmCommand ...................................................................... core: Adding exclusive lock (by name) to ImportVmCommand In order to solve the above bug, an exclusive lock by name is acquired. The lock is removed after a vm is added to the DB. Change-Id: I298f7f277a2000537f0edcdd0fcfd8aedd8037d1 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=907132 signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11815 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I298f7f277a2000537f0edcdd0fcfd8aedd8037d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Removed the ResXResourceReader class
by tnisan＠redhat.com 10 Feb '13

10 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Removed the ResXResourceReader class ...................................................................... core: Removed the ResXResourceReader class Removed the class ResXResourceReader from the compat module, this class was used to load the audit log messages from the properties file, it was used only in AuditLogDirector, the logic in the class was improved and moved to a method inside AuditLogDirector Change-Id: If60caa71d0b66d79279409ca534a419b89dcba75 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/ResXResourceReader.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 2 files changed, 626 insertions(+), 650 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11827 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If60caa71d0b66d79279409ca534a419b89dcba75 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove DateFormatCompat class and its usages
by tnisan＠redhat.com 10 Feb '13

10 Feb '13

Tal Nisan has submitted this change and it was merged. Change subject: core: Remove DateFormatCompat class and its usages ...................................................................... core: Remove DateFormatCompat class and its usages Change-Id: Ibd6bd390367af4ac4946b036d670844e50c91f37 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DateFormatCompat.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java 2 files changed, 4 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd6bd390367af4ac4946b036d670844e50c91f37 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: gluster: Modify calls to fnSplitterUuid
by sanjal＠redhat.com 10 Feb '13

10 Feb '13

Shireesh Anjal has submitted this change and it was merged. Change subject: gluster: Modify calls to fnSplitterUuid ...................................................................... gluster: Modify calls to fnSplitterUuid Patch http://gerrit.ovirt.org/9825 changed the definition of the SP fnSplitterUuid in such a way that the older calls to this SP, that looked like: select ID from fnSplitterUuid(v_ids) no longer work, and now need to be changed to something like: select * from fnSplitterUuid(v_ids) While this change was done in most of the *_sp.sql scripts, it was missed out in gluster_volumes_sp.sql Changing it now in gluster_volumes_sp.sql Change-Id: I824aedc908cfc0a67ea2fa5ea57dd14eecb865ce Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=901531 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/dbscripts/gluster_volumes_sp.sql 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11799 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I824aedc908cfc0a67ea2fa5ea57dd14eecb865ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use storage helper to fetch (related to BZ882825)
by mlipchuk＠redhat.com 10 Feb '13

10 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Use storage helper to fetch (related to BZ882825) ...................................................................... core: Use storage helper to fetch (related to BZ882825) Added engine support for connecting LUN with multiple connections of different storage types. Change-Id: Ida526dd9e08bc9881e65a529cb1b00aee0786af1 Related-to: https://bugzilla.redhat.com/882825 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StorageHelperBaseTest.java 3 files changed, 126 insertions(+), 8 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10141 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida526dd9e08bc9881e65a529cb1b00aee0786af1 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix edit cluster policy for new cluster
by alkaplan＠redhat.com 10 Feb '13

10 Feb '13

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Fix edit cluster policy for new cluster ...................................................................... webadmin: Fix edit cluster policy for new cluster When Creating a new cluster the cluster policy data was not saved because of different view initialization process. Added a bounding between the clusterPolicyModel in the view and ClusterModel (which was missing in the 'New Cluster' flow). Change-Id: I305a71e888e72e35cd40dd1055b6ad22d6111678 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I305a71e888e72e35cd40dd1055b6ad22d6111678 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: change VdsRefreshTimeout to 3 seconds
by emesika＠redhat.com 10 Feb '13

10 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core: change VdsRefreshTimeout to 3 seconds ...................................................................... core: change VdsRefreshTimeout to 3 seconds The current value of 2 seconds is a bit low. The UI refreshes every 5 seconds. It was agreed to increase this value in order to reduce CPU load. Change-Id: Id84c8b8bbc939559ff8be4f86b8adbe1ed6f450c Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908745 --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11877 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id84c8b8bbc939559ff8be4f86b8adbe1ed6f450c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change PM delay for Start/Stop operations
by emesika＠redhat.com 10 Feb '13

10 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Change PM delay for Start/Stop operations ...................................................................... core: Change PM delay for Start/Stop operations currently when a Start/Stop operation is invoked, the default number of retries is 3 while the delay between retries is 60 sec. That means that if when we initially check the status after a Start/Stop operation it does not reach on/off status we will have to wait 60 seconds to sample the status again A shorter delay of 10 seconds while keeping the total default waiting time untouched (means modifying default number of retries to 18 will improve user experience in PM operations Default config values were changed to: FenceStartStatusDelayBetweenRetriesInSec=10 FenceStartStatusRetries=18 FenceStopStatusDelayBetweenRetriesInSec=10 FenceStopStatusRetries=18 Since those values are not exposed to engine-config, we can simply override the installed value. Change-Id: I876d98013e2c3874680660940f78b8f14778fa92 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=908778 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11876 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I876d98013e2c3874680660940f78b8f14778fa92 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0