Change in ovirt-engine[master]: engine-manage-domains: Adding man page
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine-manage-domains: Adding man page
......................................................................
engine-manage-domains: Adding man page
Fix change I26e69ce141 engine-manage-domains.8
Change-Id: Icd979479d40c0cdae1db17bfbcffb0ecca5cd0b2
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=742421
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M Makefile
M packaging/fedora/spec/ovirt-engine.spec.in
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd979479d40c0cdae1db17bfbcffb0ecca5cd0b2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Streamline RemoveExternalEvent canDoAction()
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Streamline RemoveExternalEvent canDoAction()
......................................................................
core: Streamline RemoveExternalEvent canDoAction()
Streamlined and cleaned up RemoveExternalEventCommand's canDoAction()
method by using the early return pattern and overriding
setActionMessageParameters().
A nice side effect of this cleanup was do solve the possible
NullPointerExcetion FindBugs was complaining about, as the function
would not terminate if the event was null.
Change-Id: I3d2110e40ad17aea852e1002fe1de5e576dc8248
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java
1 file changed, 12 insertions(+), 13 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11641
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d2110e40ad17aea852e1002fe1de5e576dc8248
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Don't check equality in BE setters
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Don't check equality in BE setters
......................................................................
core: Don't check equality in BE setters
Some old business entities used the change-check idiom in their setters:
public void setXXX (Object newValue) {
if (!newValue.equals(dataMember) {
dataMember = newValue;
}
}
This was probably produced by the C# conversion, but is completely
useless in Java - in any event, at the end of the setXXX method the
dataMember's value will be equal to the one passed, and the equality
check is more expensive than just assigning the new value.
This patch removes this old idiom from the code.
As a nice side-bonus, it also removes a couple of StringHelper usages
from the code, as part of the ongoing effort to get rid of this class.
Change-Id: Iafac9ca646c6c988470bf49d0596d973531c4616
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_domains.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java
4 files changed, 4 insertions(+), 15 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11638
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafac9ca646c6c988470bf49d0596d973531c4616
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Don't use EqOp on constants in commons
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Don't use EqOp on constants in commons
......................................................................
core: Don't use EqOp on constants in commons
This patch removes the usage on StringHelper.EqOp for string constants
from the commons package, and replaces them with the standard JDK string
equality checks such as equals and equalsIgnoreCase.
Note that the EqOp is just redundant in these cases, since a string
constant is known not to be null.
Change-Id: Id0936f213025c76b8c34df6d447e8067500a9887
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceStatusReturnValue.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java
3 files changed, 3 insertions(+), 5 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11639
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0936f213025c76b8c34df6d447e8067500a9887
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Remove domains member from storage_pool
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove domains member from storage_pool
......................................................................
core: Remove domains member from storage_pool
Removed the private member "domains" from the storage_pool class. This
member was never updated (in fact, there are no methods to modify it!),
and never queried (no such methods exists either), and was only used in
the equals(Object) and hashCode() methods. Since its value is always
null, it's useless to continue holding it.
Change-Id: Iee2b595457d14d8b5c7d6f1697d4dca1236fd1a5
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java
1 file changed, 1 insertion(+), 11 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11642
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee2b595457d14d8b5c7d6f1697d4dca1236fd1a5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: DEFAULT_PRESTARTED_VMS constant as static
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: DEFAULT_PRESTARTED_VMS constant as static
......................................................................
core: DEFAULT_PRESTARTED_VMS constant as static
Changed the DEFAULT_PRESTARTED_VMS constant in vm_pools to be
static, as per java's conventions for constants.
Change-Id: I47cf4450bdedfebc49fc5ec49af80d586e972a52
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vm_pools.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11646
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47cf4450bdedfebc49fc5ec49af80d586e972a52
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: HOST_DEFAULT_SPM_PRIORITY constant as static
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: HOST_DEFAULT_SPM_PRIORITY constant as static
......................................................................
core: HOST_DEFAULT_SPM_PRIORITY constant as static
Changed the HOST_DEFAULT_SPM_PRIORITY constant in VdsStatic to be
static, as per java's conventions for constants.
Change-Id: I504c3550713e78915fb2230fdbdb3ae402a19c7d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11645
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I504c3550713e78915fb2230fdbdb3ae402a19c7d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: VmPayload: efficient map iteration
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: VmPayload: efficient map iteration
......................................................................
core: VmPayload: efficient map iteration
Replaced a keySet() iteration with a more efficient entrySet()
iteration in the VmPayload class.
Change-Id: Idb7d010c8744a161bf49d03fe9fc1b6c1c0fc32f
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11644
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb7d010c8744a161bf49d03fe9fc1b6c1c0fc32f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Remove userGroup member from tags
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove userGroup member from tags
......................................................................
core: Remove userGroup member from tags
Removed the private member "userGroup" from the tags class. This
member was never updated (in fact, there are no methods to modify it!),
and never queried.
Its only use was in its getter, which was never used anywhere in the
code. Thus, it's useless to continue holding it.
Change-Id: I9e965c455a426afbd894caa85059d3d39159b84e
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11643
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e965c455a426afbd894caa85059d3d39159b84e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 10 months
Change in ovirt-engine[master]: core: Clean up RemoveStoragePool.canDoAction
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Clean up RemoveStoragePool.canDoAction
......................................................................
core: Clean up RemoveStoragePool.canDoAction
General Java cleanup to RemoveStorageDomain.canDoAction() - moved action
type setting to setActionMessageParameters(), used getXXXDao() methods
where available and removed redundant null check.
Change-Id: I8aa157b7589b3ae5039c71ca07c3dc11ff88ce0d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
1 file changed, 17 insertions(+), 14 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11634
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8aa157b7589b3ae5039c71ca07c3dc11ff88ce0d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 10 months