Change in ovirt-engine[master]: core: removal unneeded boolean and finally block from recove...
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: removal unneeded boolean and finally block from recovery command.
......................................................................
core: removal unneeded boolean and finally block from recovery command.
When running reconstruct as internal command, there's no need to the
finally block as exceptions won't be thrown - therefore the finally
block and the used boolean can be removed safely.
Change-Id: I5c14601c1b9f5097c600c0139f785cbe43f4a588
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java
1 file changed, 37 insertions(+), 41 deletions(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Liron Aravot: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11620
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c14601c1b9f5097c600c0139f785cbe43f4a588
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: use return value instead of a shared boolean in recove...
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: use return value instead of a shared boolean in recovery
......................................................................
core: use return value instead of a shared boolean in recovery
This patch adds the use of return value to return whether reconstruct command got
to execute ReconstructMasterVDS, rather then use a shared boolean - this allows
also to execute reconstruct from recovery as internal command rather then
super.execute() which is less trivial and can cause to some issues.
NOTE: execution of reconstruct from recovery was reverted in commit
I9423d880a7d10a5bfa917e415fe41651f9d7e7f1 because of some issues that it
caused, this patch fixes those issues.
Change-Id: I880361ebe3f23a098a4ede760310c1f0148ae5c6
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RecoveryStoragePoolCommand.java
2 files changed, 28 insertions(+), 19 deletions(-)
Approvals:
Maor Lipchuk: Looks good to me, approved
Liron Aravot: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11619
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I880361ebe3f23a098a4ede760310c1f0148ae5c6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: Fix multiple domains to support useDnsLookup flag
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Fix multiple domains to support useDnsLookup flag
......................................................................
core: Fix multiple domains to support useDnsLookup flag
Even if useDnsLookup flag is set to true at
/etc/ovirt-engine/engine-manage-domains/engine-manage-domains.conf
The [domain_realm] with domain realm mapping must exist in case there is more than one managed domain.
Change-Id: Iebad744a40370c970d9462fb628092d9ebed13b1
bug-url: https://bugzilla.redhat.com/905291
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebad744a40370c970d9462fb628092d9ebed13b1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: Find bugs fix at manage-domains
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Find bugs fix at manage-domains
......................................................................
core: Find bugs fix at manage-domains
Change-Id: Iebad744a40370c970d9462fb628092d9ebed13b0
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11653
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iebad744a40370c970d9462fb628092d9ebed13b0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: start 'prestarted VMs' immediately after update
by mkublin@redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: start 'prestarted VMs' immediately after update
......................................................................
core: start 'prestarted VMs' immediately after update
This patch solves a bug in which after increasing the number of
prestarted VMs of a pool, it takes a while (which is defined by the
configuration value "VmPoolMonitorIntervalInMinutes") to start
more VMs to meet the updated number of prestarted VMs.
The solution is to trigger the pool monitoring job to run immediately,
after UpdateVmPoolWithVmsCommand updates the new properties of the
pool.
Change-Id: I636f496b241c042962cfec10880fbee00ce2bab4
Bug-Url: https://bugzilla.redhat.com/888396
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/dbscripts/vms_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmPoolWithVmsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/interfaces/BackendInternal.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
10 files changed, 89 insertions(+), 16 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I636f496b241c042962cfec10880fbee00ce2bab4
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: core: executing squartz job immediately
by mkublin@redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: executing squartz job immediately
......................................................................
core: executing squartz job immediately
This patch adds an option in the SchedulerUtil API to execute
scheduled job immediately.
SchedulerUtil#triggerJob method, that executes immediately the job with
the given id, was added.
Relevant unit test was added and set to be disabled like the rest of
the similar tests which already exists.
Change-Id: I4661691ae970e7517a4e3a43ae87736ebd1cc15f
Bug-Url: https://bugzilla.redhat.com/888396
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/beans/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java
M backend/manager/modules/beans/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java
M backend/manager/modules/beans/scheduler/src/test/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartsImplTest.java
3 files changed, 70 insertions(+), 0 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4661691ae970e7517a4e3a43ae87736ebd1cc15f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: webadmin: Frontend class formatting
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Frontend class formatting
......................................................................
webadmin: Frontend class formatting
Change-Id: I346993b83db0985903933bc09e39ba4b72f78d5d
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
1 file changed, 57 insertions(+), 49 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11269
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I346993b83db0985903933bc09e39ba4b72f78d5d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: webadmin: Cleanup of Frontend class
by tnisan@redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Cleanup of Frontend class
......................................................................
webadmin: Cleanup of Frontend class
- Remove of unused methods and members
- Remove return types from unsupported sync methods and mark them as deprecated
Change-Id: I2799eed79b4534d103fbbc53a6658ecc950c43f0
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/FindDesktopModel.java
5 files changed, 23 insertions(+), 129 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11268
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2799eed79b4534d103fbbc53a6658ecc950c43f0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine: Disable global transaction at ExtendSANStorageDomain
by mkublin@redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Disable global transaction at ExtendSANStorageDomain
......................................................................
engine: Disable global transaction at ExtendSANStorageDomain
During investigation on some bug, I noticed that we have too many transaction time out
exceptions on ExtendSANStorageDomainCommand.
The problem is that following command is trying to open a global transaction, this is a mistake,
transaction is a global resource and should be kept as short as possible.
The change is:
1. Disable global transaction
2. Start to use compensation in order to keep flow correct
Change-Id: I78c4c43c259a58c746caa0402bf5beb004e9a8c2
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ExtendSANStorageDomainCommand.java
1 file changed, 34 insertions(+), 18 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11648
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I78c4c43c259a58c746caa0402bf5beb004e9a8c2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: engine-manage-domains: Adding man page
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine-manage-domains: Adding man page
......................................................................
engine-manage-domains: Adding man page
Adding engine-manage-domains.8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=742421
Change-Id: I26e69ce1410ce1ffd0c8ce242ea519ff3c5daee6
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M Makefile
A packaging/engine-manage-domains.8
2 files changed, 52 insertions(+), 0 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/11175
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26e69ce1410ce1ffd0c8ce242ea519ff3c5daee6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
11 years, 8 months