February 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Display warning before overtaking spice console
by tjelinek＠redhat.com 04 Feb '13

04 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: Display warning before overtaking spice console ...................................................................... engine: Display warning before overtaking spice console This patch adds a displaying popup window when an user is overtaking (Spice or VNC) console that has been already in use. The popup window is displayed if these conditions hold: - "allow console reconnect" feature is disabled - there is a user currently connected to the console and following conditions hold: - the user currently connected to the console is different from the user who is trying to connect - the user currently connected to the console has not permissions to reconnect (steal) console Changes on backend: - Added command for checking whether an ad element has permission that allows console reconnect. - Removed UpdateVmConsoleData command and parameters. This command served only for unsetting console user on console disconnect. This is done by VdsEventListener. - Removed console related fields from VdsUpdateRuntimeInfo. Changes on frontend: - Added methods for checking safeness of console connecting operation and displaying confirm popup. Change-Id: Iffce89a0c7bdd0cccb71943f398f0f907fbed002 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=868297 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CanUpdateFieldGenericQuery.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HasAdElementReconnectPermissionQuery.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmConsoleDataCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmConsoleDataParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/HasAdElementReconnectPermissionParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 14 files changed, 191 insertions(+), 112 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10770 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffce89a0c7bdd0cccb71943f398f0f907fbed002 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : avoid failover on resource timeout error
by mlipchuk＠redhat.com 04 Feb '13

04 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core : avoid failover on resource timeout error ...................................................................... core : avoid failover on resource timeout error Change-Id: If2208a29c19e61eee3222361b8c2672f673ec3fc Bug-url: https://bugzilla.redhat.com/show_bug.cgi?id=891562 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/BrokerCommandBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/11688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If2208a29c19e61eee3222361b8c2672f673ec3fc Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: GWT dependencies cleanups
by asaf＠redhat.com 04 Feb '13

04 Feb '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: build: GWT dependencies cleanups ...................................................................... build: GWT dependencies cleanups - Defined GWT maven plugin in root POM plugin management section. - Defined GWT dependencies in root POM dependency management section. - Versioned and scopes are inherited from root pom for all sub modules. - uicommonweb module is self dependent on gwt-user dependency. - Removed POM changes that are in comments for long time. Change-Id: Iffb753cd6fb4f669b82a40fd0da5f37d15d18e5f Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M pom.xml 8 files changed, 29 insertions(+), 62 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffb753cd6fb4f669b82a40fd0da5f37d15d18e5f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: upgrade postgres jdbc
by lhornyak＠redhat.com 04 Feb '13

04 Feb '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: upgrade postgres jdbc ...................................................................... engine: upgrade postgres jdbc - Upgrades PostgreSQL JDBC to version 9.1-901.jdbc4 - Removed postgresql.version from the pom, it was redundant with postgres.jdbc.version Change-Id: I57065e43dee7fcae363174750a959757f438d915 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M pom.xml 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57065e43dee7fcae363174750a959757f438d915 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: build: Removal of unsed gwt maven plugin repo.
by asaf＠redhat.com 04 Feb '13

04 Feb '13

Asaf Shakarchi has submitted this change and it was merged. Change subject: build: Removal of unsed gwt maven plugin repo. ...................................................................... build: Removal of unsed gwt maven plugin repo. The removed repo is unused as the gwt maven plugin is 2.3.0 while currently this plugin repo points to 2.1.0.M3 plugin version, The current gwt maven plugin is publicly available in the standard maven repositories thus a special plugin repo is unncessary. Change-Id: Ifa83712955757ac3dd3f0478bd352ab5b2ca9ba4 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M pom.xml 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11226 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa83712955757ac3dd3f0478bd352ab5b2ca9ba4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: attach sd - avoid failover in case of export domain
by mlipchuk＠redhat.com 04 Feb '13

04 Feb '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: attach sd - avoid failover in case of export domain ...................................................................... core: attach sd - avoid failover in case of export domain When attaching an export storage domain and having a failure which isn't spm/master domain related, avoid failover. Change-Id: Iea8ae06d5327e46b5cdb7ed73239744a1ba6ffc3 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=896484 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/AttachStorageDomainVDSCommand.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/11677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea8ae06d5327e46b5cdb7ed73239744a1ba6ffc3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix mispelling in class Messages
by derez＠redhat.com 04 Feb '13

04 Feb '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Fix mispelling in class Messages ...................................................................... webadmin: Fix mispelling in class Messages Fix mispelling in word storage in class Messages Change-Id: Ibe79165bfa5affc6281b972cfdf024e77dbad62a Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11678 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe79165bfa5affc6281b972cfdf024e77dbad62a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: Hosts from another data center displayed when...
by emesika＠redhat.com 04 Feb '13

04 Feb '13

Eli Mesika has submitted this change and it was merged. Change subject: Hosts from another data center displayed when... ...................................................................... Hosts from another data center displayed when... Hosts from another data center displayed when clicked on Hosts in tree view for cluster names with a single difference The way the ESCAPE character is used was changed between 8.4 and 9.x The '_' character is considered as regexp '?' character in the case ilike is used as the condition operator, therefore, we are forced to sign it as a normal character that is part of the string However, it seems that PG 8.4 forces us to use double ESCAPE character for that while it will not find any matching with one ESCAPE character and PG 9.1 is exactly the opposite , one ESCAPE character works while double ESCAPE characters will bring no data. The patch adds a new configuration variable PgMajorRelease that is computed when the 0000_config.sql script is running. The value of this variable is used to determine how to skip the special character '_' if found in the value string. Change-Id: I808fe02553b5554b76f08b43a30fb0ffd7d99973 Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=874660 --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java 3 files changed, 50 insertions(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11541 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I808fe02553b5554b76f08b43a30fb0ffd7d99973 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: prestarted VM and increase num of VMs restyled
by tjelinek＠redhat.com 04 Feb '13

04 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: prestarted VM and increase num of VMs restyled ...................................................................... webadmin: prestarted VM and increase num of VMs restyled Edit pool dialog, prestarted VMs and increase num of VMs incorreclty styled. The sizes where hard coded. The problem become visible after the dialog has been shrinked. After unfolding the "Advanced Parameters", the scroll bar appeared effectivly shrinking the width of the dialog. The hard-coded widths where not able to respond to this. Change-Id: Iaa4130b1076162a09a3189f569b0a6a3da434d39 Bug-Url: https://bugzilla.redhat.com/879334 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 1 file changed, 5 insertions(+), 16 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa4130b1076162a09a3189f569b0a6a3da434d39 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: shrink VM, Pool, Template window
by tjelinek＠redhat.com 04 Feb '13

04 Feb '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: shrink VM,Pool,Template window ...................................................................... userportal,webadmin: shrink VM,Pool,Template window Shrinked the window so it fits to 1024x768 resolution. Change-Id: I84598f10564b8069077db6f67e977a049c8b946c Bug-Url: https://bugzilla.redhat.com/879329 Bug-Url: https://bugzilla.redhat.com/879331 Bug-Url: https://bugzilla.redhat.com/879334 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84598f10564b8069077db6f67e977a049c8b946c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0