March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: Optimize basic view
by ecohen＠redhat.com 01 Mar '13

01 Mar '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal: Optimize basic view ...................................................................... userportal: Optimize basic view 1. Fixed VmPool.equals method 2. Added UserPortalItemModel.entityStateEqualTo method containing VM/Pool entity state comparison logic 3. Fixed related NPE in UserPortalListModel that occured when items == null, and added break statement to optimize selected item handling loop 4. UserPortalBasicListModel provider now includes original optimization logic: * on first data update, just proceed to refresh UI * on subsequent data update, proceed to refresh UI only if there's (any) change in items 5. VM/Pool list presenter widget includes additional optimization logic: * reuse item presenter widgets (avoid recreating item views) for existing items * properly unbind/remove item presenter widgets whose items are absent within new data 6. VM/Pool item presenter widget's setModel method and related code refactored to allowed repeated setModel invocations Change-Id: I17b92858345de398dbc89d9141468ccea67963fe Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/basic/UserPortalBasicListProvider.java 7 files changed, 218 insertions(+), 89 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17b92858345de398dbc89d9141468ccea67963fe Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: stop basic list provider on extended tab
by ecohen＠redhat.com 01 Mar '13

01 Mar '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal: stop basic list provider on extended tab ...................................................................... userportal: stop basic list provider on extended tab - Modified how listener is attached - Fix UserPortalConfigurator getSpiceFullScreen Change-Id: I18e24cfcb5a477df3d3017b2f72409a37162ea64 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/place/UserPortalPlaceManager.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/AbstractModelActivationPresenter.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java 3 files changed, 23 insertions(+), 21 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18e24cfcb5a477df3d3017b2f72409a37162ea64 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Non-plugin automatic invocation of console session
by tjelinek＠redhat.com 01 Mar '13

01 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: Non-plugin automatic invocation of console session ...................................................................... frontend: Non-plugin automatic invocation of console session This patch adds a native way of connecting to a (SPICE and VNC) console from WA/UP using external viewer (virt-viewer) installed on client system. It is achieved by implementing a servlet that generates a config file (with all needed information to connect) for virt-viewer that is served to the client afterwards. The old way of invoking console viewer (browser plugin) is still kept, the configuration is set in the database. The behavior for SPICE is driven by configuration. There are three modes of behavior: - Plugin - The "old" way - spice-xpi is used. - Native - The native client is used. - Auto - If plugin is installed, it is used. Otherwise "native" implementation is used. As for VNC - it is set to use the native implementation by default (i.e. there is no VNC connection info popup dialog). Frontend changes: - removed classes that deal with displaying VNC connection info popup - added SpiceNativeImpl (implements ISpice) for invoking request for spice client configuration file - renamed SpiceInterfaceImpl to SpicePluginImpl - added marking interfaces to these two implementations - added class AbstractSpice that contains common properties of ISpice implementations - added ClientConsoleMode enum for representing console mode configuration (Auto, Native, Plugin) Change-Id: Ib31e870deb7ecb3dac4cff25e49a3ebca4706a25 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=843410 --- A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/IVncImpl.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceNativeImpl.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpiceNative.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpicePlugin.java D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/IVnc.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VncConsoleModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/console/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/console/ConsolePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 19 files changed, 1,001 insertions(+), 972 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/11703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib31e870deb7ecb3dac4cff25e49a3ebca4706a25 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Non-plugin automatic invocation of console session
by tjelinek＠redhat.com 01 Mar '13

01 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: core: Non-plugin automatic invocation of console session ...................................................................... core: Non-plugin automatic invocation of console session This patch adds a native way of connecting to a (SPICE and VNC) console from WA/UP using external viewer (virt-viewer) installed on client system. It is achieved by implementing a servlet that generates a config file (with all needed information to connect) for virt-viewer that is served to the client afterwards. The old way of invoking console viewer (browser plugin) is still kept, the configuration is set in the database. The behavior for SPICE is driven by configuration. There are three modes of behavior: - Plugin - The "old" way - spice-xpi is used. - Native - The native client is used. - Auto - If plugin is installed, it is used. Otherwise "native" implementation is used. As for VNC - it is set to use the native implementation by default (i.e. there is no VNC connection info popup dialog). Backend changes: - Added servlets for serving console configuration. - Added ClientConsoleMode to vdc_options (default setting is 'Auto') and modified related enums. Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=843410 --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java A backend/manager/modules/root/src/main/java/org/ovirt/engine/core/GetAttachmentServlet.java M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml 5 files changed, 73 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/11702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18b9d2efad15f5e9bb98a8176112b721c810205f Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: ignore the NetworkUser role
by tjelinek＠redhat.com 01 Mar '13

01 Mar '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: ignore the NetworkUser role ...................................................................... userportal: ignore the NetworkUser role Since 97e84c622a7cfa9f709eb4d814d42d90448edc91 there is a NetworkUser role and this role is assigned to everyone. Since the engineUser does not contain this role, UP evaluates, that this specific user has more roles than the engineUser so he is an admin and should see the extended tab. Fixed by ignoring the NetworkUser in this algorithm the same way as e.g. the QuotaConsumer is. Change-Id: Iaf696b51159ba016d88124b789d5bbbab7b736fe Bug-Url: https://bugzilla.redhat.com/916328 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/auth/ApplicationGuids.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf696b51159ba016d88124b789d5bbbab7b736fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0