March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[sdk_3.2]: sdk: session based authentication for /localhost is broken #...
by mpastern＠redhat.com 03 Mar '13

03 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: session based authentication for /localhost is broken #916285 ...................................................................... sdk: session based authentication for /localhost is broken #916285 detailed explanation: ===================== REST-API introduced new functionality at #876641 to JSESSION based authentication, if HTTP header Prefer:persistent-auth is set and client sends the Authorization header as well, - will be re-initiated new JSESSION, what is made all clients sending both Prefer and Authorization headers to get authorised again using Authorization header and not JSESSION, correct behaviour is: ==================== 1. send Authorization & Prefer headers 2. store JSESSION returned in cookie 3. use for authorization Prefer header & JSESSION cookie disabling session based authentication: ====================================== 1. omit from request Prefer header 2. add Authorization header https://bugzilla.redhat.com/show_bug.cgi?id=916285 Change-Id: Ief0ed86c26c2e74b8cc8f46d68b01f904c50d0e2 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/proxy.py M src/ovirtsdk/web/connection.py 2 files changed, 68 insertions(+), 12 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief0ed86c26c2e74b8cc8f46d68b01f904c50d0e2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: session based authentication for /localhost is broken #...
by mpastern＠redhat.com 03 Mar '13

03 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: session based authentication for /localhost is broken #916285 ...................................................................... sdk: session based authentication for /localhost is broken #916285 detailed explanation: ===================== REST-API introduced new functionality at #876641 to JSESSION based authentication, if HTTP header Prefer:persistent-auth is set and client sends the Authorization header as well, - will be re-initiated new JSESSION, what is made all clients sending both Prefer and Authorization headers to get authorised again using Authorization header and not JSESSION, correct behaviour is: ==================== 1. send Authorization & Prefer headers 2. store JSESSION returned in cookie 3. use for authorization Prefer header & JSESSION cookie disabling session based authentication: ====================================== 1. omit from request Prefer header 2. add Authorization header https://bugzilla.redhat.com/show_bug.cgi?id=916285 Change-Id: Ief0ed86c26c2e74b8cc8f46d68b01f904c50d0e2 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/proxy.py M src/ovirtsdk/web/connection.py 2 files changed, 68 insertions(+), 12 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12520 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief0ed86c26c2e74b8cc8f46d68b01f904c50d0e2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix ArithmeticException when adding host with no swap ...
by mkublin＠redhat.com 03 Mar '13

03 Mar '13

Michael Kublin has submitted this change and it was merged. Change subject: core: fix ArithmeticException when adding host with no swap space ...................................................................... core: fix ArithmeticException when adding host with no swap space stat.getswap_total() will be divisor in checkVdsSwapThreshold(), But when adding host which doesn't have swap space, it will return zero Change-Id: If4ad3d8b13cf2a784fcbb714434a676aba971102 Signed-off-by: plysan <plysab(a)gmail.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12540 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4ad3d8b13cf2a784fcbb714434a676aba971102 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ly pan <plysab(a)gmail.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: ly pan <plysab(a)gmail.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi: Omit of prefer header doesn't turn off session base...
by mpastern＠redhat.com 03 Mar '13

03 Mar '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Omit of prefer header doesn't turn off session based authentication #916582 ...................................................................... restapi: Omit of prefer header doesn't turn off session based authentication #916582 This patch makes sure we take the http session in case it exists, even if the prefer auth header isn't set. That way, the last request without the prefer header will succeed, and then we would log out. Also, the first request with the prefer header will create a new session, as expected. Requests without the prefer header will not create a session, and no cookie will be returned. Change-Id: Ie61285212c4050bc6dc2c744b3d281648ea542ca Bug-Url: https://bugzilla.redhat.com/916582 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie61285212c4050bc6dc2c744b3d281648ea542ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: rest: after creating a REST session request without Prefer r...
by oourfali＠redhat.com 03 Mar '13

03 Mar '13

Oved Ourfali has submitted this change and it was merged. Change subject: rest: after creating a REST session request without Prefer returns 401 ...................................................................... rest: after creating a REST session request without Prefer returns 401 This patch makes sure we take the http session in case it exists, even if the prefer auth header isn't set. That way, the last request without the prefer header will succeed, and then we would log out. Also, the first request with the prefer header will create a new session, as expected. Requests without the prefer header will not create a session, and no cookie will be returned. Change-Id: Ie61285212c4050bc6dc2c744b3d281648ea542ca Bug-Url: https://bugzilla.redhat.com/916582 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie61285212c4050bc6dc2c744b3d281648ea542ca Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImagesHandler: filterImageDisks readability
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImagesHandler: filterImageDisks readability ...................................................................... core: ImagesHandler: filterImageDisks readability Improved readability of ImagesHandler.filterImageDisks: 1. Reordered the evaluated conditions 2. Changed the terminology from "filter", which may be ambiguous to "allowOnly". Change-Id: I7cc2fc314e05fda6b1c6cdf39365b64fa0cfe345 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 12 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cc2fc314e05fda6b1c6cdf39365b64fa0cfe345 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImageHandlerTest - add missing annotation
by amureini＠redhat.com 03 Mar '13

03 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImageHandlerTest - add missing annotation ...................................................................... core: ImageHandlerTest - add missing annotation Added the missing @Test annotation to testGetAllStorageIdsForImageIds(). Change-Id: I695456e660b7c4debfb3bc1de03b22420d976a8e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I695456e660b7c4debfb3bc1de03b22420d976a8e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: change shared-lock msg of AddVmFromTemplate
by ofrenkel＠redhat.com 03 Mar '13

03 Mar '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: change shared-lock msg of AddVmFromTemplate ...................................................................... core: change shared-lock msg of AddVmFromTemplate This patch adds a custom error message for the scenario in which a command fails to run because of the shared-lock that AddVmFromTemplate command acquires on its given template. The new error message says that the command cannot be executed because the template is used for creation of VM, and shows the name of that VM. Change-Id: I9fcc4d70bd5ca28c87ca7834bf2b699da5140fc5 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommandBaseTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 74 insertions(+), 3 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fcc4d70bd5ca28c87ca7834bf2b699da5140fc5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Upgrade from 3.1 to 3.2 fails
by emesika＠redhat.com 03 Mar '13

03 Mar '13

Eli Mesika has submitted this change and it was merged. Change subject: core:Upgrade from 3.1 to 3.2 fails ...................................................................... core:Upgrade from 3.1 to 3.2 fails Upgrade failed on 3.1.3 to 3.2 on both PG 8.4.x and 9.x On 8.4.x : Problem was that attempt to drop the uuid generation support functions was done with ${USERNAME}. since postgres is the owner of those functions the user engine assigned to ${USERNAME} has no permissions to drop those functions. Solution was to run the script that drops those functions with user postgres. on 9.x : The DROP EXTENSION statement tried to drop uuid-ossp. In postgres the '-' functions as '?' in regular expressions so I had to wrap the name with double quotes. Change-Id: I70eff71a8367879eae53ad3b003a050e289bc73e Signed-off-by: Eli Mesika <emesika(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=916728 --- M backend/manager/dbscripts/dbfunctions.sh M backend/manager/dbscripts/drop_old_uuid_functions.sql 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I70eff71a8367879eae53ad3b003a050e289bc73e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: add isCancel to command in quota
by gchaplik＠redhat.com 03 Mar '13

03 Mar '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: add isCancel to command in quota ...................................................................... webadmin: add isCancel to command in quota In quota model and quota list model the Cancel command was not set with the isCancel attribute resaulting in problems when trying to use the ESC key to clsoe it. Change-Id: Ifb28b8c52b958f4d7ee62009e0d5114bf5268f50 Bug-Url: https://bugzilla.redhat.com/915759 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Looks good to me, approved Noam Slomianko: Verified -- To view, visit http://gerrit.ovirt.org/12582 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb28b8c52b958f4d7ee62009e0d5114bf5268f50 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0