April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: less intrusive method for httpd integration
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: less intrusive method for httpd integration ...................................................................... packaging: less intrusive method for httpd integration CURRENT IMPLEMENTATION ovirt-engine proxy all requests, disallow any additional application to be hosted on the same web server. NEW IMPLEMENTATION proxy only ovirt-engine URI prefixes. By default ovirt-engine is at: http://host/ovirt-engine Optionally add redirect from / to /ovirt-engine during setup. SIDE EFFECTS In order to handle redirects of 404.html, we require some valid URI to redirect into, as a result the welcome page of root will not be index.html but ovirt-engine.html, same for style.css which was renamed to ovirt-engine-style.css Change-Id: I89a47a99e28de0905183dc502cb0b35c80f77e6d Signed-off-by: Alex Lourie <alourie(a)redhat.com> Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile M backend/manager/modules/root/src/main/webapp/404.html M backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml R backend/manager/modules/root/src/main/webapp/ovirt-engine-style.css R backend/manager/modules/root/src/main/webapp/ovirt-engine.html M frontend/webadmin/modules/userportal-gwtp/src/main/webapp/404.html M frontend/webadmin/modules/webadmin/src/main/webapp/404.html M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py M packaging/fedora/setup/ovirt-engine-proxy.conf.in A packaging/fedora/setup/ovirt-engine-root-redirect.conf.in 14 files changed, 127 insertions(+), 43 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89a47a99e28de0905183dc502cb0b35c80f77e6d Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: fix of I33d8e4b4
by tjelinek＠redhat.com 09 Apr '13

09 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: fix of I33d8e4b4 ...................................................................... userportal: fix of I33d8e4b4 this patch fixes broken build caused by I33d8e4b4. Change-Id: I69558a8e6482b654fb87a70fec3879bcb2ac3169 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/utils/ConnectAutomaticallyManager.java 1 file changed, 2 insertions(+), 7 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/13734 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69558a8e6482b654fb87a70fec3879bcb2ac3169 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: use simplified template when handling ovirt-engin...
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: use simplified template when handling ovirt-engine-proxy.conf.in ...................................................................... packaging: use simplified template when handling ovirt-engine-proxy.conf.in Change-Id: I7031884c602e2bd5dfffb34b42e5925cf2f39afa Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/ovirt-engine-proxy.conf.in 3 files changed, 10 insertions(+), 21 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7031884c602e2bd5dfffb34b42e5925cf2f39afa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: clean /var/tmp in upgrade and cle...
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: clean /var/tmp in upgrade and cleanup ...................................................................... packaging: engine-service: clean /var/tmp in upgrade and cleanup previous service implementation used mixed ownership of root/ovirt in /var/tmp/ovirt-engine, /var/lib/ovirt-engine/deployments. the /var/tmp/ovirt-engine was not cleared if daemon exited so likely to remain. new service implementation does not run under root account, so having root owned resources is not healthy. during upgrade setup correct setting, during setup remove leftovers, as engine-cleanup not to be trusted as it does not actually revert to initial state. Change-Id: If0efa0b8a71673140490e2c363af7d3ba6044ffe Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/setup/output_messages.py 4 files changed, 27 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0efa0b8a71673140490e2c363af7d3ba6044ffe Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: remove unused dos2unix
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: remove unused dos2unix ...................................................................... packaging: remove unused dos2unix Change-Id: If6f3e9728d1b578dae1224a9b165fee13f6cc029 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6f3e9728d1b578dae1224a9b165fee13f6cc029 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup plugins should not be executable
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: setup plugins should not be executable ...................................................................... packaging: setup plugins should not be executable Change-Id: I4d92a3af2d071780a8ec9f19e4c6e7debf6074d0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d92a3af2d071780a8ec9f19e4c6e7debf6074d0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: build: support subst more than once in line
by juan.hernandez＠redhat.com 09 Apr '13

09 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: build: support subst more than once in line ...................................................................... packaging: build: support subst more than once in line Change-Id: Ie91ea6bb2765825c022ba699ddf1d7660298265f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile 1 file changed, 16 insertions(+), 16 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie91ea6bb2765825c022ba699ddf1d7660298265f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: renamed ImageType to ImageFileType
by ofrenkel＠redhat.com 09 Apr '13

09 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: engine: renamed ImageType to ImageFileType ...................................................................... engine: renamed ImageType to ImageFileType Renamed, because the ImageType conflicts with the upcomning Instance Type feature, where there will be this entities: ImageType InstanceType TemplateType Change-Id: I5e72e98776631755e5c0296fa5c255118fb39a54 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetImagesListByStoragePoolIdQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ImageFileType.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ImageType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RepoFileMetaData.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListByStoragePoolIdParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListParametersBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RepoFileMetaDataDAOTest.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendFilesResource.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageIsoListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java 18 files changed, 114 insertions(+), 114 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5e72e98776631755e5c0296fa5c255118fb39a54 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Auto-Connect to RDP on Win 8 and Win 2012-64bit
by tjelinek＠redhat.com 09 Apr '13

09 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: Auto-Connect to RDP on Win 8 and Win 2012-64bit ...................................................................... userportal: Auto-Connect to RDP on Win 8 and Win 2012-64bit Connect automatically doesn't take in effect that for Windows 8/2012 RDP is default. Steps to Reproduce: 1. Windows 8/2012 VM for user in the UP 2. Connect with auto-connect enabled from the login screen Spice console appears instead of RDP one. (As there is performance issue with unaccelerated SPICE console, RDP was agreed to be default for Windows 8/2012. So make auto-connect to check this correctly.) Fixed by utilizing ConsoleUtils and ConsoleManager classes which are used for connecting to console in regular use case. These classes take into account that spice is unsupported on the mentioned platforms. Change-Id: I33d8e4b4701f25bb64a7410512f17c266f872a86 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=918605 --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/utils/ConnectAutomaticallyManager.java 3 files changed, 18 insertions(+), 6 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Frank Kobzik: Verified -- To view, visit http://gerrit.ovirt.org/13218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33d8e4b4701f25bb64a7410512f17c266f872a86 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: English locale to en_US
by ecohen＠redhat.com 08 Apr '13

08 Apr '13

Einav Cohen has submitted this change and it was merged. Change subject: userportal, webadmin: English locale to en_US ...................................................................... userportal, webadmin: English locale to en_US - Changed the English locale to be en_US to match the location pointed to by the documentation. Change-Id: I8fb5ac34f0e587b533c09bf26c24dcba81e9b41f Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=947176 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13703 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fb5ac34f0e587b533c09bf26c24dcba81e9b41f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: PRD32 - RFE: Multi-Tier fencing in RHEV-M
by emesika＠redhat.com 08 Apr '13

08 Apr '13

Eli Mesika has submitted this change and it was merged. Change subject: core: PRD32 - RFE: Multi-Tier fencing in RHEV-M ...................................................................... core: PRD32 - RFE: Multi-Tier fencing in RHEV-M 1) Removing the status check in the canDoAction such that for sequential multiple agents secondary agent will still be used even tough the primary agent is not reachable. Also added an Alert in case that a primary agent failed to function and a secondary agent is used in the case of sequential multiple agents. Change-Id: Ieb5a3a8edeb58f74f0e74d3e54911f0cdb614762 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=773108 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 12 insertions(+), 14 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13698 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb5a3a8edeb58f74f0e74d3e54911f0cdb614762 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: clean RemoveStorageDomainCommand
by amureini＠redhat.com 08 Apr '13

08 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: clean RemoveStorageDomainCommand ...................................................................... core: clean RemoveStorageDomainCommand Renamed connect/disconnect methods to start with lowercase (java convention) and remove unused methods. Change-Id: I2d15ce79acf17ed05108fdd7a4f00aa6470be3ad Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java 1 file changed, 4 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d15ce79acf17ed05108fdd7a4f00aa6470be3ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: DLS in DragDropEventBase.getData
by amureini＠redhat.com 08 Apr '13

08 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: DLS in DragDropEventBase.getData ...................................................................... webadmin: DLS in DragDropEventBase.getData Removed the DLs regarding the dataTransfer in said method. Change-Id: I9c93490d018bf1cba5b78f096cf78e9ab2fcd346 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/com/google/gwt/event/dom/client/DragDropEventBase.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9c93490d018bf1cba5b78f096cf78e9ab2fcd346 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: DLS in MangeDomains.getConfiguration()
by amureini＠redhat.com 08 Apr '13

08 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: tools: DLS in MangeDomains.getConfiguration() ...................................................................... tools: DLS in MangeDomains.getConfiguration() Removed the DLs regarding the currentAuthorizationMethod in said method. Change-Id: If20c91e0af26154cab1b469a6240e3c79d20c400 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If20c91e0af26154cab1b469a6240e3c79d20c400 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove LdapSeachGroupsByQuery.initFromDb
by amureini＠redhat.com 08 Apr '13

08 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove LdapSeachGroupsByQuery.initFromDb ...................................................................... core: Remove LdapSeachGroupsByQuery.initFromDb Removed LdapSeachGroupByQueryCommand.initFromDb, since all it did was query an LdapGroup and save it into a local variable that was never used again. Note that this patch solves a DLS_DEAD_LOCAL_STORE FindBugs warning on this class. Change-Id: I581fab9aa581a3a5093f98cc48edeaffc9080c44 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchGroupsByQueryCommand.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I581fab9aa581a3a5093f98cc48edeaffc9080c44 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Locate data source in a loop
by juan.hernandez＠redhat.com 08 Apr '13

08 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Locate data source in a loop ...................................................................... core: Locate data source in a loop The deployment of the data source usually finishes before the application is started, but in some situations, for example with slow DNS, it can finish after the application has started, thus we can't assume that it has already been deployed. Change-Id: I72c99c61d05e8a1619c7d1fb70af956d1050eb3a Bug-Url: https://bugzilla.redhat.com/879904 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java 1 file changed, 141 insertions(+), 33 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72c99c61d05e8a1619c7d1fb70af956d1050eb3a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : AddVmFromSnapshot - use device information from snaps...
by amureini＠redhat.com 08 Apr '13

08 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core : AddVmFromSnapshot - use device information from snapshot. ...................................................................... core : AddVmFromSnapshot - use device information from snapshot. When adding a vm from snapshot (clone of a snapshot), the device information was taken from the vm current state and not from the snapshot configuration - which caused the cloned vm to not be in the desired state and possibly have missing devices. Change-Id: I0611bbbef00fd2c2390ead5f3110e56dcaacd579 BUg-Url: https://bugzilla.redhat.com/show_bug.cgi?id=882644 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 2 files changed, 25 insertions(+), 20 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0611bbbef00fd2c2390ead5f3110e56dcaacd579 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: move java compatiblity symlink where it can be cr...
by juan.hernandez＠redhat.com 08 Apr '13

08 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: move java compatiblity symlink where it can be created ...................................................................... packaging: move java compatiblity symlink where it can be created Change-Id: I5f25123f492b78aa1f2a311c053aca12ec86c4bd Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13700 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f25123f492b78aa1f2a311c053aca12ec86c4bd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: tools: added rpm to hypervisors sosreport
by knesenko＠redhat.com 08 Apr '13

08 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: tools: added rpm to hypervisors sosreport ...................................................................... tools: added rpm to hypervisors sosreport Provides information about rpms installed on hypervisors. (cherry picked from commit cd611d1555d206bf89ed78ea91d8145ea677fc4f) Change-Id: I57bc036b3a13f44be14d194555a448f9005b9e78 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/__main__.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57bc036b3a13f44be14d194555a448f9005b9e78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: OvfReader - set IsManaged to true for managed devices
by mlipchuk＠redhat.com 08 Apr '13

08 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: OvfReader - set IsManaged to true for managed devices ...................................................................... core: OvfReader - set IsManaged to true for managed devices When reading ovf data, managed devices were added to the managed devices map - but the isManaged flag wasn't set to true, causing that possibly wrong data would be persisted/used. Related to Bug-Url: https://bugzilla.redhat.com/882644 Change-Id: Ifa51f5aa6655b5b9ae6fd1a8c5e0c206fa9630e6 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/13370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa51f5aa6655b5b9ae6fd1a8c5e0c206fa9630e6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: allow to perform hotplug/unplug/attach when vm is paus...
by mlipchuk＠redhat.com 08 Apr '13

08 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: allow to perform hotplug/unplug/attach when vm is paused. ...................................................................... core: allow to perform hotplug/unplug/attach when vm is paused. When a VM is paused there's no reason not to allow hot plugging/unplugging/attaching a disk. Change-Id: I6d950a1e7945e43ec5ee5ffa0f79c5f9536473a6 Bug-Url: https://bugzilla.redhat.com/918498 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Ar: Verified -- To view, visit http://gerrit.ovirt.org/12986 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d950a1e7945e43ec5ee5ffa0f79c5f9536473a6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Console connect button availability fix
by tjelinek＠redhat.com 08 Apr '13

08 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Console connect button availability fix ...................................................................... webadmin: Console connect button availability fix This patch fixes the behavior of console button availability broken by I00158bbd. For the availability check, the ConsoleUtils is used. It also removes the event for connecting to console (it was needed because uicommonweb is not under gin management). Now the UiCommonDefaultTypeResolver is used for resolving needed classes (adding new interfaces/moving classes was needed to make this possible). The signature of the methods of the console options persister is changed - the console context parameter was removed because it's redundant (can be infered from the model parameter). Change-Id: If102303d6b5c5ac45959b87a540c8ea278c227c3 Signed-off-by: Frantisek Kobzik <fkobzik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/BaseSystemModule.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/AsyncCallFailureHandler.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ErrorPopupManagerImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendFailureEventListener.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpicePluginImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/UiCommonDefaultTypeResolver.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleManagerImpl.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtilsImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleOptionsFrontendPersister.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ConsoleUtils.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/ErrorPopupManager.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/HasConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RdpConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UtilsModule.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicListItemPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/basic/MainTabBasicListItemView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/extended/vm/ConsoleButtonCell.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/UtilsModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/ReportPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabVirtualMachinePresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 37 files changed, 394 insertions(+), 299 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If102303d6b5c5ac45959b87a540c8ea278c227c3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-3.2]: sos - fixed behaviour when -a option is used
by knesenko＠redhat.com 08 Apr '13

08 Apr '13

Kiril Nesenko has submitted this change and it was merged. Change subject: sos - fixed behaviour when -a option is used ...................................................................... sos - fixed behaviour when -a option is used calling sosreport -a -o postgresql set all the postgresql plugin options to True which was an unexpected and unhandled value. Fixed also some minor issues like wrong indentation, instance attribute declaration out of __init__, file built-in redefinition. (cherry picked from commit 4b1c6eb7b4ba44c30ea9e6fb5841e2eaf619dcc4) Change-Id: Ifcebf02bd96bec18094175d97013bee1c54b5e34 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M src/sos/plugins/postgresql.py 1 file changed, 40 insertions(+), 18 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, but someone else must approve Kiril Nesenko: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifcebf02bd96bec18094175d97013bee1c54b5e34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix VM pop-up Host tab
by gchaplik＠redhat.com 08 Apr '13

08 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix VM pop-up Host tab ...................................................................... webadmin: Fix VM pop-up Host tab In the VM pop-up view, host tab - the logic of the UI visibility and availability is wrong. CPU pinning topology textbox should always be visible. Both 'Use Host CPU' and 'CPU Pinning topology' are unavailable for clusters with compatibility version under 3.2. Logic of the flags 'Use Host CPU' and 'CPU Pinning topology' should be as follows: A = 'cpu pinning' available B = 'use host cpu' available For RHEV: Any Selected Host Host ------------------------------------------------------------- Allow auto migration Allow Man. migration B Do not allow migration B A+B For oVirt: Any Selected Host Host ------------------------------------------------------------- Allow auto migration A Allow Man. migration B A Do not allow migration B A+B Change-Id: Ibe691e0292a6bf99521629f04d292698ba1027e5 Bug-Url: https://bugzilla.redhat.com/905831 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 4 files changed, 38 insertions(+), 22 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13546 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibe691e0292a6bf99521629f04d292698ba1027e5 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added validation for bond name format
by masayag＠redhat.com 08 Apr '13

08 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Added validation for bond name format ...................................................................... core: Added validation for bond name format Added enforcement for bond names of the form "^bond\d*$", the format assumed and used by VDSM. This is to enable adding new bonds from the engine. Change-Id: Id4ea20997c03c35c1f47d9ab12a49a39dd9c778a Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Bond.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 19 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13480 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4ea20997c03c35c1f47d9ab12a49a39dd9c778a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added validation for host NIC name length
by masayag＠redhat.com 08 Apr '13

08 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: core: Added validation for host NIC name length ...................................................................... core: Added validation for host NIC name length Linux apparently limits NIC names to be at most 15 characters long, so I enforced that rule on our corresponding entities. Change-Id: I901734ef19ae63c5879c19022bb2ed229a23b3a3 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I901734ef19ae63c5879c19022bb2ed229a23b3a3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: redo patch 12748: show the correct VM's console ...
by tjelinek＠redhat.com 08 Apr '13

08 Apr '13

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal: redo patch 12748: show the correct VM's console type ...................................................................... userportal: redo patch 12748: show the correct VM's console type The console type presented in VMs lists at the user-portal (basic + extended) is based on the default display type defined for the VMs, which is not always right because VM can be run in Run-Once mode with a display type which is different from the default. This patch ensure that the right console type is displayed for each VM in the user portal by changing the way the console type is determined - if the VM is running then we determine the console type according to the actual display type (presented by the display type field in VmDynamic), and according to the default display type, as before, only if the VM is not running. Change-Id: I488ceeba48c02e21b19762260a21d0efe1a2eab9 Bug-Url: https://bugzilla.redhat.com/907776 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsoleModelsCache.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I488ceeba48c02e21b19762260a21d0efe1a2eab9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: connect --help will log the user out of the disconnecte...
by mpastern＠redhat.com 08 Apr '13

08 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: connect --help will log the user out of the disconnected cli ...................................................................... cli: connect --help will log the user out of the disconnected cli Running connect --help in a disconnect cli will print help message and log user off cli. This patch uses a regex to convert command --help to help command and execute it. Change-Id: Icffe101260edc5072aec4c8d2a6df0f763591f8b Bug-Url: https://bugzilla.redhat.com/890340 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M src/ovirtcli/shell/engineshell.py 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/13494 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icffe101260edc5072aec4c8d2a6df0f763591f8b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: major cleanup
by juan.hernandez＠redhat.com 08 Apr '13

08 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: major cleanup ...................................................................... packaging: engine-service: major cleanup Last patch in series of engine-service, after all core issues merged into existing implementation, this introduce python only rework and cleanups. 1. Removal global variable. 2. Previous patch already use python subprocess instead of direct exec. 3. Use python logging instead of direct syslog calls. 4. Add debug log. 5. Add debug parameter. 6. Add gettext support. 7. Modular functional. 8. Remove one time used variables. 9. Remove replication of configuration variable into local variables. 10. Remove dead code. 11. pyflakes free 12. pep8 complaint. Change-Id: Iea45e8131190f41171e937699ec2e261939c4bd9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in M packaging/fedora/engine-service.systemd.in M packaging/fedora/engine-service.sysv.in 3 files changed, 887 insertions(+), 601 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea45e8131190f41171e937699ec2e261939c4bd9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: fix systemd packaging per fedora ...
by juan.hernandez＠redhat.com 08 Apr '13

08 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: fix systemd packaging per fedora requirements ...................................................................... packaging: engine-service: fix systemd packaging per fedora requirements Change-Id: I84d290d2cc389450be183cd85fb91ee1e58e4e9a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 28 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84d290d2cc389450be183cd85fb91ee1e58e4e9a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: move service to backend subpackag...
by juan.hernandez＠redhat.com 08 Apr '13

08 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: move service to backend subpackage ...................................................................... packaging: engine-service: move service to backend subpackage Change-Id: I3df9c0f0d221d883c7a49b0c7f953a2ffde211c0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3df9c0f0d221d883c7a49b0c7f953a2ffde211c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: remove unused tmpfiles config
by juan.hernandez＠redhat.com 08 Apr '13

08 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: remove unused tmpfiles config ...................................................................... packaging: engine-service: remove unused tmpfiles config Change-Id: I81175c21f018be180157ffcaadef1dd28ee8801c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in D packaging/resources/ovirt-tmpfilesd 2 files changed, 0 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I81175c21f018be180157ffcaadef1dd28ee8801c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: do not clean environment
by juan.hernandez＠redhat.com 08 Apr '13

08 Apr '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: engine-service: do not clean environment ...................................................................... packaging: engine-service: do not clean environment the init system may put important variables in environment. add LC_ALL as java is effected by AC_CTYPE per defaults of string conversions, as if it is set by init it will effect us. in practice we should only set LC_CTYPE or use jnu.encoding, when we are sure that no default locale is used for conversions within application. Change-Id: Ia8231b343574df83e65c55d9ffa75698a3f2d692 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/engine-service.py.in 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8231b343574df83e65c55d9ffa75698a3f2d692 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:restore.sh fails to drop existing database...
by yzaslavs＠redhat.com 08 Apr '13

08 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core:restore.sh fails to drop existing database... ...................................................................... core:restore.sh fails to drop existing database... restore.sh fails to drop existing database and continues running Adding a check on the dropdb command status and existing if not succeeded. Change-Id: If9d33e0011cdac6bb0d9b153cc4f4a118c7b4aaf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=929359 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/restore.sh 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13498 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9d33e0011cdac6bb0d9b153cc4f4a118c7b4aaf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in otopi[master]: core: use single function for early debug
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: use single function for early debug ...................................................................... core: use single function for early debug Change-Id: I246b1602fa51bb005925b0dca0dc505849bc221f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/otopi/context.py 1 file changed, 13 insertions(+), 12 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I246b1602fa51bb005925b0dca0dc505849bc221f Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: core: support more complex sequence relationships
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: support more complex sequence relationships ...................................................................... core: support more complex sequence relationships perform before/after multiple times to allow list to be synchronized. Change-Id: I28ca4fdf48f657feaf72c928d61f4f8a5996bad8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/otopi/context.py 2 files changed, 30 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28ca4fdf48f657feaf72c928d61f4f8a5996bad8 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: doc: ChangeLog: fix spelling
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: ChangeLog: fix spelling ...................................................................... doc: ChangeLog: fix spelling Change-Id: Ib98caa8fc026c47199dfbdfe6b304005a319f074 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib98caa8fc026c47199dfbdfe6b304005a319f074 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[otopi-1.0]: doc: ChangeLog: fix spelling
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: ChangeLog: fix spelling ...................................................................... doc: ChangeLog: fix spelling Change-Id: Ia5f17b396e329771e7f4c38a9b1b86084a7b1c2a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia5f17b396e329771e7f4c38a9b1b86084a7b1c2a Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix build error
by rgolan＠redhat.com 07 Apr '13

07 Apr '13

Roy Golan has submitted this change and it was merged. Change subject: core: fix build error ...................................................................... core: fix build error Change-Id: I669480a591095e84ebdb0b4624424bd3ba177ac6 Bug-Url: http://bugzilla.redhat.com/922490 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13684 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I669480a591095e84ebdb0b4624424bd3ba177ac6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: monitoring - don't handle devices for MigratingTo VMs
by rgolan＠redhat.com 07 Apr '13

07 Apr '13

Roy Golan has submitted this change and it was merged. Change subject: core: monitoring - don't handle devices for MigratingTo VMs ...................................................................... core: monitoring - don't handle devices for MigratingTo VMs There is no point of trying to update devices of migrating VM. This could wait when the VM will be up. its consistent with the same behaviour of ignoring the state of VMs with status MigratingTo. Change-Id: I33087d86c4f41d781331d1879297350d3483728f Signed-off-by: Roy Golan <rgolan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/922490 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33087d86c4f41d781331d1879297350d3483728f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Removed unused import that broke the build
by mpastern＠redhat.com 07 Apr '13

07 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Removed unused import that broke the build ...................................................................... restapi: Removed unused import that broke the build Not sure how it got there... Change-Id: I71d6c34cdf29ab63efb4f0553cb58b84e9b3b5ac Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/13680 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71d6c34cdf29ab63efb4f0553cb58b84e9b3b5ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Added mapping to derived classes of VdsNetworkInter...
by mpastern＠redhat.com 07 Apr '13

07 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Added mapping to derived classes of VdsNetworkInterface ...................................................................... restapi: Added mapping to derived classes of VdsNetworkInterface The mapping now uses Bond, Vlan and Nic. This to enable specific bean validation, etc. Change-Id: Iaabecc4d723923506e98cd3bc397ad406c4ef5c0 Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/13556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaabecc4d723923506e98cd3bc397ad406c4ef5c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove StringHelper usages in types module
by amureini＠redhat.com 07 Apr '13

07 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove StringHelper usages in types module ...................................................................... core: Remove StringHelper usages in types module Removed all the usages of the deprecated StringHelper class and replaced them with standard calls to StringUtils. Change-Id: If571a276077252672577f63b160a95c81f8bdeb4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/CdRomMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostNicMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 5 files changed, 15 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If571a276077252672577f63b160a95c81f8bdeb4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove StringHelper usages in jaxrs module
by amureini＠redhat.com 07 Apr '13

07 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove StringHelper usages in jaxrs module ...................................................................... core: Remove StringHelper usages in jaxrs module Removed all the usages of the deprecated StringHelper class and replaced them with standard calls to StringUtils. Change-Id: I86d4266462bb936db9be551a1a321cdcb8f5929f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResourceBase.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUsersResourceBase.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BaseBackendResource.java 4 files changed, 11 insertions(+), 14 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86d4266462bb936db9be551a1a321cdcb8f5929f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Use DbUser.isGroup() properly
by amureini＠redhat.com 07 Apr '13

07 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Use DbUser.isGroup() properly ...................................................................... restapi: Use DbUser.isGroup() properly Replaced an explicit string check on DbUser's user name with the BE's method isGroup(). This achieves two goals: 1. It's easier to understand. 2. It removes a dependency on the deprecated StringHelper. Change-Id: Ib17d50003d2b1425db9a2fc17c206da2d4db5de7 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java 1 file changed, 5 insertions(+), 8 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13653 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib17d50003d2b1425db9a2fc17c206da2d4db5de7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-host-deploy[ovirt-host-deploy-1.0]: doc: fix wrong setting for fake and development
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: doc: fix wrong setting for fake and development ...................................................................... doc: fix wrong setting for fake and development Change-Id: I3ac15f934f821be73f96065e7de938b1dec28d0d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13674 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ac15f934f821be73f96065e7de938b1dec28d0d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: ovirt-host-deploy-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[otopi-1.0]: dialog: support tuple in addition to list
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: dialog: support tuple in addition to list ...................................................................... dialog: support tuple in addition to list Change-Id: I781d452d62c6524c1435fa9910eadb7143dc3cdf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/otopi/dialog/human.py M src/plugins/otopi/dialog/machine.py 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13673 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I781d452d62c6524c1435fa9910eadb7143dc3cdf Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[otopi-1.0]: dialog: human: accept empty note text
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: dialog: human: accept empty note text ...................................................................... dialog: human: accept empty note text Change-Id: I739d19094423e694b738ddb8c99eb13c7718fe85 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/otopi/dialog/human.py 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13672 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I739d19094423e694b738ddb8c99eb13c7718fe85 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : Error when adding/removing permissions with filter...
by yzaslavs＠redhat.com 07 Apr '13

07 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: restapi : Error when adding/removing permissions with filtered api(#919686) ...................................................................... restapi : Error when adding/removing permissions with filtered api(#919686) Internal server error when UserVmManager adds a User role permission on a VM, the permission gets added. Insufficent privileges error when removing the permission which was added. Change-Id: I47cbb6e06599fc64afcb491bef15b46a82afd681 Bug-Url: https://bugzilla.redhat.com/919686 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java 2 files changed, 9 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47cbb6e06599fc64afcb491bef15b46a82afd681 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in otopi[master]: dialog: support tuple in addition to list
by Alon Bar-Lev 07 Apr '13

07 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: dialog: support tuple in addition to list ...................................................................... dialog: support tuple in addition to list Change-Id: I781d452d62c6524c1435fa9910eadb7143dc3cdf Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/otopi/dialog/human.py M src/plugins/otopi/dialog/machine.py 3 files changed, 3 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I781d452d62c6524c1435fa9910eadb7143dc3cdf Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0