April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: truncated text in VMs-Disks sub-tab
by derez＠redhat.com 21 Apr '13

21 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: truncated text in VMs-Disks sub-tab ...................................................................... webadmin: truncated text in VMs-Disks sub-tab Fixed truncated headers VMs -> Disks sub-tab. Change-Id: I2e9c4853bdd6da18801be7c04a0c201331afb7a4 Bug-Url: https://bugzilla.redhat.com/952457 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseVmDiskListModelTable.java 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14026 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e9c4853bdd6da18801be7c04a0c201331afb7a4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : name is invalid argument segment error when adding...
by mpastern＠redhat.com 21 Apr '13

21 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : name is invalid argument segment error when adding tag with parent id(#950450) ...................................................................... restapi : name is invalid argument segment error when adding tag with parent id(#950450) add tag --name newtag --parent-name ooo2 Results in error: "name" is invalid argument segment. the command should be add tag --name newtag --parent-tag-name ooo2 Change-Id: I904888aa9cadb8cfcf9f7119f1bc4ac301cee7f9 Bug-Url: https://bugzilla.redhat.com/950450 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I904888aa9cadb8cfcf9f7119f1bc4ac301cee7f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: restapi : missing sync option for action vm import in RSDL(#...
by mpastern＠redhat.com 21 Apr '13

21 Apr '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : missing sync option for action vm import in RSDL(#949881) ...................................................................... restapi : missing sync option for action vm import in RSDL(#949881) No sync option in cli for action vm import. Change-Id: I84799bf942dd87956cb2f42c5b57201687d32fda Bug-Url: https://bugzilla.redhat.com/949881 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84799bf942dd87956cb2f42c5b57201687d32fda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: truncated text in Storage main-tab
by derez＠redhat.com 21 Apr '13

21 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: truncated text in Storage main-tab ...................................................................... webadmin: truncated text in Storage main-tab Fixed truncated headers in Storage main-tab. Change-Id: I31820f0820767cd993b21c57711b25a310706d97 Bug-Url: https://bugzilla.redhat.com/950019 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31820f0820767cd993b21c57711b25a310706d97 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: engine : ovirt-node enter installing status when the install...
by yzaslavs＠redhat.com 21 Apr '13

21 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine : ovirt-node enter installing status when the install fails ...................................................................... engine : ovirt-node enter installing status when the install fails When ovirt-node installation fails because of missing iso file the status of the host is left as Installing. This patch adds VdsDynamic data to compensation context if can do action of InstalllVdsCommand fails. The status is reverted back to the previous status in compensation logic. The error messages are added to the return values CanDoActionMessages so the message can be displayed in cli Change-Id: I2d74e946cb68d2b9dbc11fc5c6bed9f63ba35fe2 Bug-Url: https://bugzilla.redhat.com/947982 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsCommand.java 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2d74e946cb68d2b9dbc11fc5c6bed9f63ba35fe2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Host General sub-tab unlocalized strings found
by gchaplik＠redhat.com 21 Apr '13

21 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Host General sub-tab unlocalized strings found ...................................................................... webadmin: Host General sub-tab unlocalized strings found changes are described in bugzilla. Change-Id: I59b0ba281c912d1a9e09b9ab3dde1be93b0c7e56 Bug-Url: https://bugzilla.redhat.com/952091 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskStatusColumn.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/disk/SubTabDiskVmView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralView.java 12 files changed, 69 insertions(+), 35 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14059 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59b0ba281c912d1a9e09b9ab3dde1be93b0c7e56 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-upgrade - log DB upgrade in the right plac...
by oschreib＠redhat.com 21 Apr '13

21 Apr '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-upgrade - log DB upgrade in the right place ...................................................................... packaging: engine-upgrade - log DB upgrade in the right place DB Upgrade script should be run with the wanted log location, otherwise, it creates the upgrade log in the dbscripts directory (currently, in /usr/share) Change-Id: I15cb1e0d7ce12a27ae07c92025db6b21636957c9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=947344 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15cb1e0d7ce12a27ae07c92025db6b21636957c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Improve message when network is mis-configured
by masayag＠redhat.com 21 Apr '13

21 Apr '13

Moti Asayag has submitted this change and it was merged. Change subject: engine: Improve message when network is mis-configured ...................................................................... engine: Improve message when network is mis-configured The patch adds a specific message to the host general sub tab for the case of a VM network isn't implemented so on the host. In addition, it adjusts the indicator of the same error in the event log to warning so it could be noticeable easily. Change-Id: I0f51fdc0d66cc55020858391dabd026b88e4fe35 Bug-Url: https://bugzilla.redhat.com/951920 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 7 files changed, 32 insertions(+), 21 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/14082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f51fdc0d66cc55020858391dabd026b88e4fe35 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Extract SD validations from ImagesHandler
by amureini＠redhat.com 19 Apr '13

19 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Extract SD validations from ImagesHandler ...................................................................... core: Extract SD validations from ImagesHandler Extracted the logic to perform validations on Storage Domains from ImagesHandler.PerformImagesChecks, and made the relevant commands use it directly. In order to do this, a new type of validator was introduced, MultipleStorageDomainsValidator, which aggregates validations from individual StorageDomainValidators in a fast-fail pattern. This is done for performance reasons, so there is no need to load all the storage domains from the database preemptively. This refactoring removes three parameters from PerformImagesChecks: * checkStorageDomain and diskSpaceCheck - are now done directly by MultipleStorageDomainsValidator. * storageDomainId - is used by the previous two checks, and by the image existence check. However, it is always equal to the storage domain id member of the DiskImage, so it is redundant as an additional parameter. The changes in the commands are as follows: * The parameters detailed above were removed from the ImagesHandler.PerformImagesCheck calls. * Wherever appropriate, a direct call to StorageDomainValidator or MultipleStorageDomainsValidator was added. Change-Id: I4cfc895dceed4de520476ed5e3fa9c1c7cfd78f4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/MultipleStorageDomainsValidatorTest.java 19 files changed, 356 insertions(+), 123 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12249 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4cfc895dceed4de520476ed5e3fa9c1c7cfd78f4 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove PerformImagesChecks from AddDisk
by amureini＠redhat.com 19 Apr '13

19 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove PerformImagesChecks from AddDisk ...................................................................... core: Remove PerformImagesChecks from AddDisk Several previous patches have removed checks not related to DiskImages from PerformImagesChecks (The last one being change id I4cfc895dceed4de520476ed5e3fa9c1c7cfd78f4, that removed storage domain validation). Now, since PerformImagesChecks only checks DiskImages, passing an emptyList() to it is meaningless, and can safely be removed. Change-Id: I457dee7645dd16c430eda6886e03df77c7e91383 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java 2 files changed, 0 insertions(+), 13 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I457dee7645dd16c430eda6886e03df77c7e91383 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0