April 2013 - Engine-commits - oVirt List Archives

Change in otopi[otopi-1.0]: packaging: spec: add newline after each changelog entry
by Alon Bar-Lev 17 Apr '13

17 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: spec: add newline after each changelog entry ...................................................................... packaging: spec: add newline after each changelog entry Change-Id: I3b1e51246b8826bfa6466426805b7f20bcfe6ca8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M otopi.spec.in 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b1e51246b8826bfa6466426805b7f20bcfe6ca8 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: otopi-1.0 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packaging: spec: add newline after each changelog entry
by Alon Bar-Lev 17 Apr '13

17 Apr '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: spec: add newline after each changelog entry ...................................................................... packaging: spec: add newline after each changelog entry Change-Id: I933027c541bbd0f1514ab726886d1962dbf741b5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M otopi.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13960 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I933027c541bbd0f1514ab726886d1962dbf741b5 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: notifier startup script startup directory
by yzaslavs＠redhat.com 17 Apr '13

17 Apr '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: notifier startup script startup directory ...................................................................... tools: notifier startup script startup directory The notification daemon startup script attempts to change to the ovirt user home directory to avoid permissions errors. This directory doesn't always exist, so it will now use / as a fallback. Change-Id: Iba8b163881bd31eeb970da82003dd184ffcad9b9 Bug-Url: https://bugzilla.redhat.com/949975 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/tools/src/main/shell/engine-notifier-service.sh 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13959 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba8b163881bd31eeb970da82003dd184ffcad9b9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: test for AddVdsCommand
by lhornyak＠redhat.com 16 Apr '13

16 Apr '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: test for AddVdsCommand ...................................................................... engine: test for AddVdsCommand Adds test for canDoAction. Change-Id: Iaa8b31e3bb4f96e34d7ea7e97ec8c4c5b1f19984 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVdsCommandTest.java 2 files changed, 78 insertions(+), 10 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa8b31e3bb4f96e34d7ea7e97ec8c4c5b1f19984 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: enable/disable hooks -use GlusterMultipleActionRunne...
by sanjal＠redhat.com 16 Apr '13

16 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: enable/disable hooks -use GlusterMultipleActionRunner ...................................................................... engine: enable/disable hooks -use GlusterMultipleActionRunner Changed factory to use GlusterMulitpleActionRunner for Enable/Disable hooks Change-Id: I702296e95491cb9770dc235bd2f4f0cb1eaa822e Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunnersFactory.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13832 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I702296e95491cb9770dc235bd2f4f0cb1eaa822e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Disable gluster hook command
by sanjal＠redhat.com 16 Apr '13

16 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Disable gluster hook command ...................................................................... engine: Disable gluster hook command Added bll command to disable gluster hook on all servers in a cluster. This command extends from GlusterHookStatusChangeCommand which does the work of calling the VDS command for each of the server in the cluster. The command succeeds if atleast one of the servers returns success. Refactored enable and disable hook tests to extend from a common class. Change-Id: I6fb3e034013d2ceb3590a61efc9bc46b1c3f378f Signed-off-by: Selvasundaram <sesubram(a)redhat.com> Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DisableGlusterHookCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookStatusChangeCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DisableGlusterHookCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/EnableGlusterHookCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties 7 files changed, 317 insertions(+), 145 deletions(-) Approvals: Shireesh Anjal: Looks good to me, approved Sahina Bose: Verified -- To view, visit http://gerrit.ovirt.org/11073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fb3e034013d2ceb3590a61efc9bc46b1c3f378f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: VDS disable gluster hook command
by sanjal＠redhat.com 16 Apr '13

16 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: VDS disable gluster hook command ...................................................................... engine: VDS disable gluster hook command Added VDS command to disable a gluster hook on a server given the hook details - gluster command, stage and hook name Change-Id: I65c11b9406673d5dd5bcf648f2ce18b8e9f9d259 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/DisableGlusterHookVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 6 files changed, 39 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65c11b9406673d5dd5bcf648f2ce18b8e9f9d259 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Disable gluster hook - constants and messages
by sanjal＠redhat.com 16 Apr '13

16 Apr '13

Shireesh Anjal has submitted this change and it was merged. Change subject: engine: Disable gluster hook - constants and messages ...................................................................... engine: Disable gluster hook - constants and messages Adding constants and messages required by disable gluster hook BLL and VDS commands. Change-Id: I8776106ee00441b82f29a1fb9282123805369d66 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 11 files changed, 33 insertions(+), 0 deletions(-) Approvals: Shireesh Anjal: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13553 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8776106ee00441b82f29a1fb9282123805369d66 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Unused field in ConfigureLocalStorageModel
by amureini＠redhat.com 16 Apr '13

16 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: Unused field in ConfigureLocalStorageModel ...................................................................... webadmin: Unused field in ConfigureLocalStorageModel Removed the unused field ConfigureLocalStorageModel.Context.candidate. Change-Id: Ic90f950dfc9b02f1e7beb7939814b0f0c82e2c66 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/ConfigureLocalStorageModel.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic90f950dfc9b02f1e7beb7939814b0f0c82e2c66 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GetAgentFenceOptions2Query
by amureini＠redhat.com 16 Apr '13

16 Apr '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetAgentFenceOptions2Query ...................................................................... core: Remove GetAgentFenceOptions2Query GetAgentFenceOptionsQuery and GetAgentFenceOptions2Query are completely identical except for the usage of different APIs of VdsFenceOptions. Since GetAgentFenceOptions is not used anywhere, it is removed, and GetAgentFenceOptions2 loses it "2" and get a name the better suits conventions (not to mention common sense). This patch includes: 1. Removing the old GetAgentFenceOptionsQuery class and renaming GetAgentFenceOptions2Query to take its place. 2. Removing the old GetAgentFenceOptions constant in the VdsQueryTye enum, and renaming GetAgentFenceOptions2 to take its place. 3. Clearing up the VdsFenceOptions class from methods with "2" in their name - either by removing unused methods, or by renaming them to a more sensible name. Change-Id: Id2d7f15c16257f39f162b52d22f7c2faf8eb291a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAgentFenceOptions2Query.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAgentFenceOptionsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/queries/VdcQueryTypeTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 6 files changed, 8 insertions(+), 44 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13606 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2d7f15c16257f39f162b52d22f7c2faf8eb291a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0