April 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Improving memory footprint - JSON part
by mkublin＠redhat.com 14 Apr '13

14 Apr '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improving memory footprint - JSON part ...................................................................... engine: Improving memory footprint - JSON part The following patch should imprtove a used memory in all work related to JSON. The scenarious which will be improved: all scenarios which are using compensation and vm monitoring. Motivation is due to wiki of Jackson serializer it is thread safe, except configuration part, but we are not changing configuration (Also I did short code review in order to verify that ObjectMapper is thread safe) ObjectMapper is not lightweight object and also has some internal cache in order to improve it performance, so a change is obvious: serializer and desirializer which are based on ObjectMapper should be single instance. Change-Id: I11a76b46a5bfa269605249c3dfc2d69a55d8bbef Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AsyncTaskDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDeviceDAODbFacadeImpl.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/SerializationFactory.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 7 files changed, 72 insertions(+), 74 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13879 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11a76b46a5bfa269605249c3dfc2d69a55d8bbef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: "Any Host in Cluster" broken into two lines
by gchaplik＠redhat.com 14 Apr '13

14 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: "Any Host in Cluster" broken into two lines ...................................................................... webadmin: "Any Host in Cluster" broken into two lines in ja_JP locale; removing width property from widget. Bug-Url: https://bugzilla.redhat.com/950244 Change-Id: I1963e606651994efc48c4f1dfaf2c261c0746cbf Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13883 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1963e606651994efc48c4f1dfaf2c261c0746cbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: localize quota mode enum
by gchaplik＠redhat.com 14 Apr '13

14 Apr '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: localize quota mode enum ...................................................................... webadmin: localize quota mode enum Change-Id: I98ae26b44e82cc0ca1dd0507ad32d76207132f2a Bug-Url: https://bugzilla.redhat.com/950475 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 10 insertions(+), 9 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13882 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98ae26b44e82cc0ca1dd0507ad32d76207132f2a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: HibernateVmCommand canDoAction cleanup
by ofrenkel＠redhat.com 14 Apr '13

14 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: HibernateVmCommand canDoAction cleanup ...................................................................... core: HibernateVmCommand canDoAction cleanup return canDoAction on failed check instead of if-else, move storage domains check to be last, removed useless call to update vm disks, removed useless comment. Change-Id: Ib2c7682a7b1b47e84f71fe1a6f91b3af78d799ab Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java 1 file changed, 23 insertions(+), 40 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib2c7682a7b1b47e84f71fe1a6f91b3af78d799ab Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: allow hibernate for vm without image disks (#928708)
by ofrenkel＠redhat.com 14 Apr '13

14 Apr '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: allow hibernate for vm without image disks (#928708) ...................................................................... core: allow hibernate for vm without image disks (#928708) remove check for image disks, move storage domain space check to storage domain selection method Change-Id: I83a5ffc4653929c65174e27eae3e605dbef75c4c Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=928708 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 21 insertions(+), 30 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13395 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83a5ffc4653929c65174e27eae3e605dbef75c4c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Fix text alignment in JP localization
by derez＠redhat.com 14 Apr '13

14 Apr '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal: Fix text alignment in JP localization ...................................................................... userportal: Fix text alignment in JP localization In Jp localization some text lines were miss aligned. Fixed width of the table column to support longer text. Change-Id: Iddf44aeb457bffe3deb59cd7d151caac0230060b Bug-Url: https://bugzilla.redhat.com/951082 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.ui.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddf44aeb457bffe3deb59cd7d151caac0230060b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove not used ExtendVolume.
by mlipchuk＠redhat.com 14 Apr '13

14 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove not used ExtendVolume. ...................................................................... core: Remove not used ExtendVolume. Removed ExtendVolumeVDSCommand. There is no use of it in the engine code. VDSM side should be re-examined. Change-Id: I7d9eb342e4ab09c87bc30544cc0820b50cc0c692 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ExtendVolumeVDSCommandParameters.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ExtendVolumeVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java 5 files changed, 0 insertions(+), 55 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d9eb342e4ab09c87bc30544cc0820b50cc0c692 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove not used powerDownVDSCommand.
by mlipchuk＠redhat.com 14 Apr '13

14 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove not used powerDownVDSCommand. ...................................................................... core: Remove not used powerDownVDSCommand. Removed powerDownVDSCommand, there is no use of it in the engine code, nor in VDSM. Change-Id: I72590a278574f9b29589623042543ba3cba16c81 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PowerDownVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 4 files changed, 0 insertions(+), 32 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72590a278574f9b29589623042543ba3cba16c81 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused command VmPoolToAdGroupBaseCommand
by mlipchuk＠redhat.com 14 Apr '13

14 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove unused command VmPoolToAdGroupBaseCommand ...................................................................... core: Remove unused command VmPoolToAdGroupBaseCommand Change-Id: I1b77995d8443e93ee8246606d4834c2a4e3031a4 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolToAdGroupBaseCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolToAdElementParameters.java 2 files changed, 0 insertions(+), 50 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13508 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b77995d8443e93ee8246606d4834c2a4e3031a4 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused command VmToUserCommand.
by mlipchuk＠redhat.com 14 Apr '13

14 Apr '13

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove unused command VmToUserCommand. ...................................................................... core: Remove unused command VmToUserCommand. Change-Id: Id750a0549e6b9ae0cdd8d3edf039ea04ddff0a78 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmToUserCommand.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmToAdElementParameters.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmToUserParameters.java 3 files changed, 0 insertions(+), 52 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13507 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id750a0549e6b9ae0cdd8d3edf039ea04ddff0a78 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0