May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[engine_3.2]: packaging: ovirt-engine-3.2.2-1.1
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: ovirt-engine-3.2.2-1.1 ...................................................................... packaging: ovirt-engine-3.2.2-1.1 Updated ovirt-engine-3.2.2 rpm release to 1.1 Change-Id: I023d02ec2723b84897202b73c93c39474e4908c6 Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M version.mak 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I023d02ec2723b84897202b73c93c39474e4908c6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated DB validation flow.
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Updated DB validation flow. ...................................................................... packaging: Updated DB validation flow. This patch is an addition to http://gerrit.ovirt.org/#/c/14389. It updates the parameters handling in encodingvalidator utility. Also, it updates calling the validation utilities with an admin user (postgres) instead of engine. Change-Id: I34c87815bd667d80f3691ae4a2533523bfa89f29 Bug-Url: https://bugzilla.redhat.com/920565 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M backend/manager/tools/dbutils/encodingvalidator.sh M packaging/fedora/setup/engine-upgrade.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Alex Lourie: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34c87815bd667d80f3691ae4a2533523bfa89f29 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: engine-service: protect configuration files
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: engine-service: protect configuration files ...................................................................... packaging: engine-service: protect configuration files we need to protect configuration files as database password resides within. for some reason jboss changes the permissions of configuration file and deployment to 0777, enforcing umask of 0027 perform some remedy at the price of having logs not world readable as well, so it is not a solution. luckily, jboss does not modify the directory in which configuration file resides, so we split the configuration directory to own directory and set proper permissions. Change-Id: Ie76e5ffcdccd8c3a0bedbb9ce9bd56e146eeccd9 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/services/ovirt-engine.py M packaging/services/service.py 2 files changed, 34 insertions(+), 19 deletions(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie76e5ffcdccd8c3a0bedbb9ce9bd56e146eeccd9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove vm - remove VM during execute
by amureini＠redhat.com 08 May '13

08 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: remove vm - remove VM during execute ...................................................................... core: remove vm - remove VM during execute When removing vm the operation is done as synchronized operation, task is created for each disk and then the vm is removed from db. In order to deal with engine crash, in the end method a roll forward is performed in case that the vm still exists (the vm is being deleted and it's disks are being marked as illegal). This logic is unneeded and can cause to a bug, in case of deleted vm and imported vm with the same id, this can cause that the imported vm would be deleted from the db as the deletion tasks would end - therefore this logic is being removed. this patch contains the following changes: 1. the first step is to remove the vm, lock all the disks - in case of failure they will be in ILLEGAL status. 2. added a boolean member indicating whether RemoveImage should lock the image. 3. RemoveAllVmImages shouldn't fail in case of failure to create a task for deletion, the engine should continue and try to delete the other images- this change also prevents a storage leak in removing vm and templates from export domains. 4. RemoveAllVmImages returns a list of disks it failed to remove, instead of querying the db again. Change-Id: I7a3e497e52471f7255e6c17b59a2e3bf362b8783 Signed-off-by: Liron Aravot <laravot(a)redhat.com> Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveImageParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 6 files changed, 47 insertions(+), 78 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a3e497e52471f7255e6c17b59a2e3bf362b8783 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix disk image json serialization/deserialization
by amureini＠redhat.com 08 May '13

08 May '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix disk image json serialization/deserialization ...................................................................... core: fix disk image json serialization/deserialization Change-Id: Id40ef08ea341e6abf2bd5e6e815bb79814141c20 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id40ef08ea341e6abf2bd5e6e815bb79814141c20 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: fix engine-upgrade config creation
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: fix engine-upgrade config creation ...................................................................... pki: fix engine-upgrade config creation Change-Id: I9af1bbb2be895f4d77d9a060454b72109bb5a382 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14566 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9af1bbb2be895f4d77d9a060454b72109bb5a382 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: modify enigne.conf.d setup files prefix
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: modify enigne.conf.d setup files prefix ...................................................................... packaging: modify enigne.conf.d setup files prefix previously we used '50-' prefix, however there is no reason for setup default to be loaded so late in change, so now it was modified to '10-' prefix. clean all configuration files when engine-clean is executed to avoid leftovers. Change-Id: I173faede1f39b87a14ede05c04e0ab4da7e8e5d3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py 3 files changed, 18 insertions(+), 6 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14562 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I173faede1f39b87a14ede05c04e0ab4da7e8e5d3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: findbugs: equals between different types
by oourfali＠redhat.com 08 May '13

08 May '13

Oved Ourfali has submitted this change and it was merged. Change subject: findbugs: equals between different types ...................................................................... findbugs: equals between different types Change-Id: I125e5df8def7a223f9469decc7aa43dab61f4a47 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQueryTest.java 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I125e5df8def7a223f9469decc7aa43dab61f4a47 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: nothing was left in conf to ovirt-engine
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: nothing was left in conf to ovirt-engine ...................................................................... packaging: nothing was left in conf to ovirt-engine move last file to backend. Change-Id: I5813d6846ff8e16d32c805a6ca35546449a42830 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5813d6846ff8e16d32c805a6ca35546449a42830 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.2]: packaging: stricter FQDN validation
by oschreib＠redhat.com 08 May '13

08 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: stricter FQDN validation ...................................................................... packaging: stricter FQDN validation common_utils.getConfiguredIps now returns only Ips configured on non loopback devices. engine_validators.validateFQDN now tolerates that the FQDN provided could not be resolved through a DNS but just only by /etc/hosts. However, if the FQDN is resolved by DNS, it has also to reverse resolve the ip address provided by the DNS. engine-setup doesn't accept anymore a FQDN that doesn't pass the validation, avoiding failures at later stages. Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f Bug-Url: https://bugzilla.redhat.com/948311 Bug-Url: https://bugzilla.redhat.com/928667 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py 4 files changed, 86 insertions(+), 46 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Sandro Bonazzola: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I512446c80dfa9c83adb179a445bfae82736d403f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0