May 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Auto update quota by template
by gchaplik＠redhat.com 08 May '13

08 May '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Auto update quota by template ...................................................................... webadmin: Auto update quota by template In the VM popup - when a template is selected, update the quota to the quota of the selected template. Change-Id: Ia1d70b895738218e551128c73415a1cbd33e8915 Bug-Url: https://bugzilla.redhat.com/924928 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: ofri masad: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14112 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1d70b895738218e551128c73415a1cbd33e8915 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-live[master]: Refactoring the code.
by obasan＠redhat.com 08 May '13

08 May '13

Ohad Basan has submitted this change and it was merged. Change subject: Refactoring the code. ...................................................................... Refactoring the code. * Added Makefile * Changed the versioning style Change-Id: Iffb6b46b5e1b64f16e2e77b954dd7c2251298d46 Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com> --- A .gitignore A Makefile D VERSION D build.sh M kickstart/ovirt.ks 5 files changed, 83 insertions(+), 56 deletions(-) Approvals: Kiril Nesenko: Verified Ohad Basan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffb6b46b5e1b64f16e2e77b954dd7c2251298d46 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: cleanup: desktops are always supported in search
by ofrenkel＠redhat.com 08 May '13

08 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: cleanup: desktops are always supported in search ...................................................................... cleanup: desktops are always supported in search The distinction of servers-only has been removed a while back. only calls to search with 'false' for desktops are actually in the unitests. Change-Id: Ib5f89927643a71025302a897c175257018fda000 Signed-off-by: Itamar Heim <iheim(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SearchQueryTest.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleterTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java 6 files changed, 19 insertions(+), 24 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5f89927643a71025302a897c175257018fda000 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: Modify error to info report after fencing and fixing print
by yzaslavs＠redhat.com 08 May '13

08 May '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: Modify error to info report after fencing and fixing print ...................................................................... Modify error to info report after fencing and fixing print Change-Id: I9411c286b20f6e0627d5699ca8ea294e443cf6ae Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14495 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9411c286b20f6e0627d5699ca8ea294e443cf6ae Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Disable unit test
by ecohen＠redhat.com 08 May '13

08 May '13

Einav Cohen has submitted this change and it was merged. Change subject: core: Disable unit test ...................................................................... core: Disable unit test - Disabled DocsServlet unit test as they are giving trouble during jenkins job. Change-Id: Iab18612d463cc5fe1270aca6a81bad60e6fa8595 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/root/src/test/java/org/ovirt/engine/core/DocsServletTest.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alexander Wels: Verified Einav Cohen: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14563 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab18612d463cc5fe1270aca6a81bad60e6fa8595 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: fix rpm errors due to services separation
by oschreib＠redhat.com 07 May '13

07 May '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: fix rpm errors due to services separation ...................................................................... packaging: fix rpm errors due to services separation these errors were not show previously, even in CI... weired! Change-Id: I5d93aea07b4c65e235d47a17d4b106132479803d Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d93aea07b4c65e235d47a17d4b106132479803d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ReplicateDisk - prevent rollback on engine restart
by derez＠redhat.com 07 May '13

07 May '13

Daniel Erez has submitted this change and it was merged. Change subject: core: ReplicateDisk - prevent rollback on engine restart ...................................................................... core: ReplicateDisk - prevent rollback on engine restart VmReplicateDiskFinishTaskHandler: Rollback should be prevented on VmReplicateDiskFinish success, but we can't rely on the command's returnValue since it's not persistent. Instead, to make sure rollback is prevented on restart, query the DB to verify that the disk indeed moved to the target storage domain. Change-Id: Ibd088940d6e3f7be79fb0381076499ea1c1d73c7 Bug-Url: https://bugzilla.redhat.com/958848 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd088940d6e3f7be79fb0381076499ea1c1d73c7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove GlobalCatalogSrvLocator
by juan.hernandez＠redhat.com 07 May '13

07 May '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: Remove GlobalCatalogSrvLocator ...................................................................... core: Remove GlobalCatalogSrvLocator This class is not used. Change-Id: I3b4b4bbf41c6c138b4370479719c45eab6a28299 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/ldap/GlobalCatalogSrvLocator.java 1 file changed, 0 insertions(+), 33 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3b4b4bbf41c6c138b4370479719c45eab6a28299 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: [cleanup] tiny cleanups
by ofrenkel＠redhat.com 07 May '13

07 May '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: [cleanup] tiny cleanups ...................................................................... core: [cleanup] tiny cleanups This patch contains: 1. change the indentation in HibernateVmCommand#getAuditLogTypeValue to make it more readable 2. simplified AsyncTaskManager#hasTasksForEntityIdAndAction structure 3. replace ArrayList with List in VdsActionParameterBase public methods signatures Change-Id: I7bbfc040e06ff1cfd48ba02a5992d0d533d9e75f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java 4 files changed, 13 insertions(+), 15 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bbfc040e06ff1cfd48ba02a5992d0d533d9e75f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: sort disks by ID in webadmin
by tnisan＠redhat.com 07 May '13

07 May '13

Tal Nisan has submitted this change and it was merged. Change subject: engine: sort disks by ID in webadmin ...................................................................... engine: sort disks by ID in webadmin Add to search of Disks tab the ability to sort by disk id. Change-Id: I373260552d1656dc15da8def6ecfed9e74022675 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/14534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I373260552d1656dc15da8def6ecfed9e74022675 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0