July 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: add storage server connections resource
by amureini＠redhat.com 31 Jul '13

31 Jul '13

Allon Mureinik has submitted this change and it was merged. Change subject: restapi: add storage server connections resource ...................................................................... restapi: add storage server connections resource Several additions to REST api: 1. Add a new root resource for storage server connections. The new api is http://host:port/api/storageconnections. 2. In backend add getAllServerConnections query class, dao method and stored procedure. 3. Add ability to add (POST) a new storage connection on the resource mentioned in item 1. 4. Add ability to delete (DELETE) an existing storage connection on the resource mentioned in item 1. http://host:port/api/storageconnections/<connectionId> 5. Add ability to update (PUT) an existing storage connection. Url is the same as item 4, different request type. 6. Add ability to get a specific connection by its id. Url is the same as item 4. 7. REST unitests 8. add feature to rsdl 9. host details providing is optional, will lead to connectivity attempt to storage in vdsm. Feature page: www.ovirt.org/Features/Manage_Storage_Connections Change-Id: If6bc32ead098390723825872f6fb292097d52835 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllStorageServerConnectionsQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageServerConnectionCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageServerConnectionQueryParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAODbFacadeImpl.java M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageServerConnectionsResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/StorageConnectionValidator.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageServerConnectionsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageDomainMapperTest.java M packaging/dbscripts/storages_san_sp.sql 26 files changed, 1,279 insertions(+), 40 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16617 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If6bc32ead098390723825872f6fb292097d52835 Gerrit-PatchSet: 33 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: db: Adding default values to ssh fields
by emesika＠redhat.com 31 Jul '13

31 Jul '13

Eli Mesika has submitted this change and it was merged. Change subject: db: Adding default values to ssh fields ...................................................................... db: Adding default values to ssh fields Old vds_static raws should have values for ssh username (root as default) and ssh port (22 as defaults) after upgrade to 3.3. If the values are null, the update script set the defaults. Change-Id: I0ae6f434edcacce5039107b221bd86ccaab92309 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- A packaging/dbscripts/upgrade/03_03_0640_default_vdsstatic_values_to_ssh_fields.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ae6f434edcacce5039107b221bd86ccaab92309 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: Fix SearchableListModel.getSearchString()
by vszocs＠redhat.com 31 Jul '13

31 Jul '13

Vojtech Szocs has submitted this change and it was merged. Change subject: frontend: Fix SearchableListModel.getSearchString() ...................................................................... frontend: Fix SearchableListModel.getSearchString() Commit caef3ae [frontend: Add paging in SubTabPoolVmView] has modified SearchableListModel.getSearchString() implementation so that it returns "null" (String) instead of null (literal) when searchString field is null. In practice, GUI bound to SearchableListModel.searchString via GWT Editor framework now shows "null" (String) instead of empty string (due to null literal) when searchString field is null, for example: Data Center main tab | Permission sub tab | Add button -> text box left to "GO" button now shows "null" string This patch fixes the above mentioned problem by ensuring getSearchString() returns null (instead of "null") when searchString field is null. Change-Id: I2fc2cab5785597cd7a7c9602a967250f16742489 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2fc2cab5785597cd7a7c9602a967250f16742489 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-dwh[master]: history: made several changes to vm disks tables
by ydary＠redhat.com 31 Jul '13

31 Jul '13

Yaniv Dary has submitted this change and it was merged. Change subject: history: made several changes to vm disks tables ...................................................................... history: made several changes to vm disks tables - dropped old indexes on image_id and created indexes on vm_disk_id. - changed image_id to nullable and vm_disk_id to not nullable. - changed vm_disks_usage_daily_history time column type to date. - changed disk description to 500 chars Change-Id: Ib4f01238d50a8bd21b4b08f5aa03b2c6c771df93 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- A data-warehouse/historydbscripts_postgres/upgrade/03_03_0030_change_vm_disks_tables.sql 1 file changed, 45 insertions(+), 0 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4f01238d50a8bd21b4b08f5aa03b2c6c771df93 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-dwh[master]: history: resynced the create db scripts
by ydary＠redhat.com 31 Jul '13

31 Jul '13

Yaniv Dary has submitted this change and it was merged. Change subject: history: resynced the create db scripts ...................................................................... history: resynced the create db scripts Change-Id: I51cf70991aae6318d27d4c8475194d7f8c4c0686 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/historydbscripts_postgres/create_db.sh A data-warehouse/historydbscripts_postgres/create_schema.sh M data-warehouse/historydbscripts_postgres/create_tables.sql M data-warehouse/historydbscripts_postgres/dbcustomfunctions.sh M data-warehouse/historydbscripts_postgres/dbfunctions.sh A data-warehouse/historydbscripts_postgres/insert_data.sql D data-warehouse/historydbscripts_postgres/insert_period_table_values.sql M data-warehouse/historydbscripts_postgres/insert_timekeeping_values.sql M data-warehouse/historydbscripts_postgres/refreshStoredProcedures.sh M data-warehouse/historydbscripts_postgres/upgrade.sh D data-warehouse/historydbscripts_postgres/upgrade/03_00_0000_add_schema_version.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0020_add_single_aggregate_variable.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0030_add_index_on_biz_entities.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0040_add_disks_info.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0050_add_reports_enum_values.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0060_add_usb_policy_enum_values.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0070_change_last_hourly_init_datetime.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0080_changed_daily_tables_time_column_to_date.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0090_added_host_cpu_config_values.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0100_added_new_periods_enums.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0110_added_vm_disks_config.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0120_added_vm_device_table.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0130_remove_unused_columns.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0140_rename_fqdn_host_column.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0150_extend_host_mac_address_size.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0160_extend_enum_value_length.sql D data-warehouse/historydbscripts_postgres/upgrade/03_00_0170_add_localized_enum_values.sql A data-warehouse/historydbscripts_postgres/upgrade/03_01_0000_set_version.sql 28 files changed, 388 insertions(+), 911 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51cf70991aae6318d27d4c8475194d7f8c4c0686 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Added missing notification entries to event map
by emesika＠redhat.com 31 Jul '13

31 Jul '13

Eli Mesika has submitted this change and it was merged. Change subject: engine: Added missing notification entries to event map ...................................................................... engine: Added missing notification entries to event map Added missing event notification entries to event map Change-Id: I2958589793dd06584cb7375215f5d97fb1c48506 Bug-Url: https://bugzilla.redhat.com/982540 Bug-Url: https://bugzilla.redhat.com/974210 Signed-off-by: Sahina Bose <sabose(a)redhat.com> --- A packaging/dbscripts/upgrade/03_03_0630_add_missing_event_map.sql 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/16900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2958589793dd06584cb7375215f5d97fb1c48506 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: change suggest box event handling
by tjelinek＠redhat.com 31 Jul '13

31 Jul '13

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin,userportal: change suggest box event handling ...................................................................... webadmin,userportal: change suggest box event handling The problem was that the ListModelTypeAheadListBox could be closed only by either selecting one of the values or clicking somewhere outside of it, but not by clicking inside it again or clicking to the drop down triangle. Fixed by disabling the auto-hide feature of the suggest box and handling this events by hand. The SuggestBoxFocusHandler now contains a field called "enabled" which enables-disables the handling by this handler. It is set from FocusHandlerEnablingMouseHandlers. The order of the events is: onMouseDown onBlur onMouseUp makeing the onBlur bordered between the mouse events. The reason is that the blur handler is supposed to hide the suggestions only if the other ways are not used (e.g.: clicking on the triangle or selecting a suggestion by clicking on some suggestion). One other fix is that the EnterIgnoringNativePreviewHandler has been fixed to process the enter event only once. Change-Id: Ib73fa0160ea1a80246bb8e9cc9a6052fad63f1fe Bug-Url: https://bugzilla.redhat.com/987845 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java 2 files changed, 132 insertions(+), 36 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib73fa0160ea1a80246bb8e9cc9a6052fad63f1fe Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: fix another tiny typo
by masayag＠redhat.com 31 Jul '13

31 Jul '13

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: fix another tiny typo ...................................................................... webadmin: fix another tiny typo Change-Id: I5b82520071f0d12318b1aafb9690b2429882083e Bug-Url: https://bugzilla.redhat.com/982507 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b82520071f0d12318b1aafb9690b2429882083e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: define branding style interface
by ecohen＠redhat.com 31 Jul '13

31 Jul '13

Einav Cohen has submitted this change and it was merged. Change subject: core: define branding style interface ...................................................................... core: define branding style interface - Defined obrand styling interface for welcome page. Change-Id: Ife90f99d25927c34ba3be1049a97d11c9a89fe7d Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/root/src/main/webapp/WEB-INF/ovirt-engine.jsp M packaging/branding/ovirt.brand/welcome_page.template M packaging/branding/ovirt.brand/welcome_style.css 3 files changed, 22 insertions(+), 23 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17484 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife90f99d25927c34ba3be1049a97d11c9a89fe7d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: do not clear currently running tasks
by yzaslavs＠redhat.com 31 Jul '13

31 Jul '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: do not clear currently running tasks ...................................................................... core: do not clear currently running tasks Change-Id: I230723796721d2cfd639be9f4a405fb54ef63e2f Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandMultiAsyncTasks.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17343 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I230723796721d2cfd639be9f4a405fb54ef63e2f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0