Change in ovirt-engine[master]: core: Remove DiskImage ctor only used in tests
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove DiskImage ctor only used in tests
......................................................................
core: Remove DiskImage ctor only used in tests
Removed the ctor that isn't used anywhere in production code.
This in fact also makes the tests easier to understand, as now the test
DiskImages instances only have the relevant field values and not all
the values demanded by this useless constructor.
Change-Id: Id7a4e16f2fd993ac2b6018cf0569830c0feeff1a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllDisksByVmIdQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
2 files changed, 14 insertions(+), 71 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18126
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7a4e16f2fd993ac2b6018cf0569830c0feeff1a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: Remove Role ctor only used in tests
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove Role ctor only used in tests
......................................................................
core: Remove Role ctor only used in tests
Removed the ctor that isn't used anywhere in production code.
Change-Id: I45cace9b2f74eebd59e0e9f3c39aa50abe96d9d5
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java
2 files changed, 10 insertions(+), 9 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18124
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45cace9b2f74eebd59e0e9f3c39aa50abe96d9d5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: Remove member init in the action parameters
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove member init in the action parameters
......................................................................
core: Remove member init in the action parameters
Since the upgrade to GWT 2.5.1, we've seen several cases of GWT pruning
member initialization.
To prevent these (and future) bugs, this series of patches removes all
such initializations from the packages that should be compiled by GWT.
These initialization are either moved to the appropriate
constructor(s), or removed them completely if they are redundant.
Constants with the wrong modifiers are amended to have static final, and
are allowed to be initialized directly.
As a side bonus, this patch offers a minor performance improvement, as
some of these members are now only initialized once instead of twice
(once in the member initialization and then again via a constructor
parameter).
This patch takes care of the BLL command parameter classes.
Change-Id: I3bb06f63b6fae8d4bc0c2b931cbfeb6b71a023a9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AdElementParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddBondParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddDiskParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalEventParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalJobParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddImageFromScratchParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddNetworkStoragePoolParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVdsActionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmToPoolParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachNetworkToVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateImageTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateSnapshotFromTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesContainterParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LoginUserParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/LogoutUserParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyImageGroupParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MoveOrCopyParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveSnapshotParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveStorageDomainParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromImportExportParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmFromPoolParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmHibernationVolumesParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmInterfaceParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RolesParameterBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetNonOperationalVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetStoragePoolStatusParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StopVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageDomainParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StoragePoolParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/TryBackToAllSnapshotsOfVmParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/UpdateVmDiskParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdsOperationActionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmOperationParameterBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmPoolSimpleUserParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateImportExportParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmTemplateParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/WatchdogParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeBricksActionParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/GlusterVolumeRemoveBricksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/gluster/ResetGlusterVolumeOptionsParameters.java
54 files changed, 201 insertions(+), 114 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18138
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3bb06f63b6fae8d4bc0c2b931cbfeb6b71a023a9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: Remove member init in the VDS parameters
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove member init in the VDS parameters
......................................................................
core: Remove member init in the VDS parameters
Since the upgrade to GWT 2.5.1, we've seen several cases of GWT pruning
member initialization.
To prevent these (and future) bugs, this series of patches removes all
such initializations from the packages that should be compiled by GWT.
These initialization are either moved to the appropriate
constructor(s), or removed them completely if they are redundant.
Constants with the wrong modifiers are amended to have static final, and
are allowed to be initialized directly.
As a side bonus, this patch offers a minor performance improvement, as
some of these members are now only initialized once instead of twice
(once in the member initialization and then again via a constructor
parameter).
This patch takes care of the VDS command parameter classes.
Change-Id: Ib0be55ee582924809c072252110b5e14b1914ea4
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/AllStorageAndImageIdVDSCommandParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ConnectStoragePoolVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CopyImageVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateImageVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateSnapshotVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateStoragePoolVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/DeactivateStorageDomainVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/FenceVdsVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetDeviceListVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetImageDomainsListVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetImagesListVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetStorageConnectionsListVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HSMGetIsoListParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HSMGetStorageDomainsListVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HSMTaskGuidBaseVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/IrsBaseVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/IsVmDuringInitiatingVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MergeSnapshotsVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MigrateVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MomPolicyVDSParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/MoveImageGroupVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/NetworkVdsmVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ReconstructMasterVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RefreshStoragePoolVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RemoveVMVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SPMTaskGuidBaseVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVdsStatusVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVmStatusVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SpmStartVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/StorageDomainIdParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/StoragePoolDomainAndGroupIdBaseVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/StorageServerConnectionManagementVDSParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/TargetDomainImageGroupVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ValidateStorageDomainVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VdsAndPoolIDVDSParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VdsAndVmIDVDSParametersBase.java
37 files changed, 116 insertions(+), 60 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18137
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0be55ee582924809c072252110b5e14b1914ea4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: RM GetImagesListVDSCommandParameters ctor
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RM GetImagesListVDSCommandParameters ctor
......................................................................
core: RM GetImagesListVDSCommandParameters ctor
Removed the ctor that isn't used anywhere in the codebase.
Change-Id: Ie83fdbc7ea6ec75fd842abb3fba75fa60177b202
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/GetImagesListVDSCommandParameters.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18136
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie83fdbc7ea6ec75fd842abb3fba75fa60177b202
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: Remove member init in the query parameters
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove member init in the query parameters
......................................................................
core: Remove member init in the query parameters
Since the upgrade to GWT 2.5.1, we've seen several cases of GWT pruning
member initialization.
To prevent these (and future) bugs, this series of patches removes all
such initializations from the packages that should be compiled by GWT.
These initialization are either moved to the appropriate
constructor(s), or removed them completely if they are redundant.
Constants with the wrong modifiers are amended to have static final, and
are allowed to be initialized directly.
As a side bonus, this patch offers a minor performance improvement, as
some of these members are now only initialized once instead of twice
(once in the member initialization and then again via a constructor
parameter).
This patch takes care of the query parameter classes.
Change-Id: Ic89595cd4e26b7fca901d62ba57f4cfdf29c12b1
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetAllFromExportDomainQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetConfigurationValueParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDeviceListQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetExistingStorageDomainListParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListByStoragePoolIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetImagesListParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetNewVdsFenceStatusParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetPermissionsForObjectParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/RegisterVdsParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/SearchParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainAndPoolQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/StorageDomainQueryParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterHookContentQueryParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterHookQueryParameters.java
17 files changed, 42 insertions(+), 29 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18135
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic89595cd4e26b7fca901d62ba57f4cfdf29c12b1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: Remove member init in the common package
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove member init in the common package
......................................................................
core: Remove member init in the common package
Since the upgrade to GWT 2.5.1, we've seen several cases of GWT pruning
member initialization.
To prevent these (and future) bugs, this series of patches removes all
such initializations from the packages that should be compiled by GWT.
These initialization are either moved to the appropriate
constructor(s), or removed them completely if they are redundant.
Constants with the wrong modifiers are amended to have static final, and
are allowed to be initialized directly.
As a side bonus, this patch offers a minor performance improvement, as
some of these members are now only initialized once instead of twice
(once in the member initialization and then again via a constructor
parameter).
This patch takes care of the class for the common package that were
not handled in previous patches in this series.
Change-Id: Iecdb2abfb2e0a85f0073b0424e7936ff566f770a
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogSeverity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VDSError.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/MapBackedPreferences.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnit.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnitType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SimpleDependecyInjector.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/I18NRegexpTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/IPAddressPatternTest.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/NoRepetitiveStaticIpInListConstraintTest.java
12 files changed, 39 insertions(+), 24 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18134
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecdb2abfb2e0a85f0073b0424e7936ff566f770a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: Remove member init in business entities
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove member init in business entities
......................................................................
core: Remove member init in business entities
Since the upgrade to GWT 2.5.1, we've seen several cases of GWT pruning
member initialization.
To prevent these (and future) bugs, this series of patches removes all
such initializations from the packages that should be compiled by GWT.
These initialization are either moved to the appropriate
constructor(s), or removed them completely if they are redundant.
Constants with the wrong modifiers are amended to have static final, and
are allowed to be initialized directly.
As a side bonus, this patch offers a minor performance improvement, as
some of these members are now only initialized once instead of twice
(once in the member initialization and then again via a constructor
parameter).
This patch takes care of all the project's business entities, as
noted in the subject.
Change-Id: I8e8eb9ccb0e68db936489110d7f5c5828d07fab4
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/AsyncTaskCreationInfo.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/asynctasks/EndedTasksInfo.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionVersionMap.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTaskStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/CopyVolumeType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DateEnumForSearch.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskLunMap.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EventAuditLogSubscriber.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/EventMap.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Image.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ImageStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LUN_storage_server_connection_map.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LdapGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LdapRefStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/LdapUser.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MigrateOnErrorOptions.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Quota.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaEnforcementTypeEnum.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/QuotaUsagePerUser.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RoleGroupMap.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/RoleType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Snapshot.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/SpmStatusResult.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePoolIsoMap.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageServerConnections.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsUserGroupMap.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsUserMap.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsVdsMap.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsVmMap.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/TagsVmPoolMap.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSDomainsData.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSNiceType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdcOption.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdcRole.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsSpmStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsTransparentHugePagesState.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPauseStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPoolMap.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplateStatus.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VolumeFormat.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VolumeType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_notification_hist.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/event_subscriber.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterHookEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/image_storage_domain_map.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkCluster.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsInterfaceType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmInterfaceType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterface.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/permissions.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/vds_spm_id_map.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Job.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/Step.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/users/VdcUser.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/network/VmNetworkInterfaceValidationTest.java
93 files changed, 468 insertions(+), 323 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18133
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e8eb9ccb0e68db936489110d7f5c5828d07fab4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: Remove member init in the compat module
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove member init in the compat module
......................................................................
core: Remove member init in the compat module
Since the upgrade to GWT 2.5.1, we've seen several cases of GWT pruning
member initialization.
To prevent these (and future) bugs, this series of patches removes all
such initializations from the packages that should be compiled by GWT.
These initialization are either moved to the appropriate
constructor(s), or removed them completely if they are redundant.
Constants with the wrong modifiers are amended to have static final, and
are allowed to be initialized directly.
As a side bonus, this patch offers a minor performance improvement, as
some of these members are now only initialized once instead of twice
(once in the member initialization and then again via a constructor
parameter).
This patch takes care of the compat package, as noted in the subject.
Change-Id: I57bc886e4e53ba7842b435d516604e41b7e469e6
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/RpmVersion.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlNamespaceManager.java
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java
M backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java
4 files changed, 7 insertions(+), 5 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18132
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57bc886e4e53ba7842b435d516604e41b7e469e6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months
Change in ovirt-engine[master]: core: Disable member init for GWT-compiled code
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Disable member init for GWT-compiled code
......................................................................
core: Disable member init for GWT-compiled code
Following the upgrade of GWT(P), if an entity's constructor is not
explicitly referenced in the UI code the inline member initializations
are not taken into account in GWT's serialization policy [1].
This patch is the culmination of a series that suggests taking the safe
route - instead of having the code (silently!) break if a call to the
constructor is removed from the UI code, it simply disallows having such
inline initializations.
The previous patches in this set remove such initializers for various
parts of the common and compat modules (broken up into smaller units for
relative ease of review).
This patch implements a checkstyle check to fail the build in compile
time if such a dangerous initializer is introduced.
[1] http://lists.ovirt.org/pipermail/engine-devel/2013-July/005256.html
Change-Id: Iffd520ecb627e87254c4d325c85088179b0ef744
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/pom.xml
M backend/manager/modules/compat/pom.xml
M build-tools-root/checkstyles/src/main/resources/checkstyle.xml
A build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NoMemberInitializationCheck.java
4 files changed, 71 insertions(+), 0 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/18140
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffd520ecb627e87254c4d325c85088179b0ef744
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
11 years, 5 months