August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: packaging: db: Updated psql usage never to ask passwords
by oschreib＠redhat.com 13 Aug '13

13 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: db: Updated psql usage never to ask passwords ...................................................................... packaging: db: Updated psql usage never to ask passwords Change-Id: Id44f803bafdcc0c5bc059b59842cff54e2e8e584 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/dbscripts/create_schema.sh M packaging/dbscripts/dbfunctions.sh 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17900 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id44f803bafdcc0c5bc059b59842cff54e2e8e584 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: pki: Add a script to extract parts from a PKCS#12
by oschreib＠redhat.com 13 Aug '13

13 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: pki: Add a script to extract parts from a PKCS#12 ...................................................................... pki: Add a script to extract parts from a PKCS#12 Add a script pki-pkcs12-extract.sh to extract the key and/or cert from a PKCS#12 file, with or without encryption (for the key). Change the setup code to use it. Change-Id: Ica596fe3ef4e5f0a60ae99b0934b10433b9d5023 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M ovirt-engine.spec.in A packaging/bin/pki-pkcs12-extract.sh M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/config/websocket_proxy.py M packaging/setup/plugins/ovirt-engine-setup/pki/ca.py M packaging/setup/plugins/ovirt-engine-setup/pki/ssh.py 6 files changed, 138 insertions(+), 28 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17899 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica596fe3ef4e5f0a60ae99b0934b10433b9d5023 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: modify nfs parameters of iso domain
by oschreib＠redhat.com 13 Aug '13

13 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: modify nfs parameters of iso domain ...................................................................... packaging: setup: modify nfs parameters of iso domain sync with vdsm settings, avoid timeouts. Change-Id: I5cce9936e071b5f57cbbeccfbf039d946ced6a39 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/nfsutils.py M packaging/setup/plugins/ovirt-engine-setup/config/iso_domain.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cce9936e071b5f57cbbeccfbf039d946ced6a39 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: trust pki scripts file mode
by oschreib＠redhat.com 13 Aug '13

13 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: trust pki scripts file mode ...................................................................... packaging: setup: trust pki scripts file mode new pki scripts can be trusted to produce proper file modes. Change-Id: If5fa87a1e0c14370ea6c6b0ce98ea3bd78a2b0bb Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/pki/ca.py 1 file changed, 9 insertions(+), 26 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17897 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5fa87a1e0c14370ea6c6b0ce98ea3bd78a2b0bb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: backend: Fixing log print when vdsm version is not supported...
by yzaslavs＠redhat.com 13 Aug '13

13 Aug '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: backend: Fixing log print when vdsm version is not supported in cluster ...................................................................... backend: Fixing log print when vdsm version is not supported in cluster When adding new host we verify its vdsm version and cluster compatibility as part of HandleVdsVersionCommand. During that we printed the same message for both compatibilities issue (vdsm version and cluster level support). This patch separates the validation part with two different prints. Change-Id: Iacfb3875a0617f978b4453769a0b1c5704282fa5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=974101 Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 6 files changed, 29 insertions(+), 23 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacfb3875a0617f978b4453769a0b1c5704282fa5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: frontend: old DC used if DC is selected in tree
by tjelinek＠redhat.com 13 Aug '13

13 Aug '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: old DC used if DC is selected in tree ...................................................................... frontend: old DC used if DC is selected in tree The problem was in UnitVmModel which used the StoragePool entity from the system tree and not the one just updated from backend. Fixed by using the correct one. Change-Id: I29bd052f7ed6dacd014e0c4348584881ee15ef02 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988018 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17957 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29bd052f7ed6dacd014e0c4348584881ee15ef02 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: frontend: handling clusters without DC in VM dialogs
by tjelinek＠redhat.com 13 Aug '13

13 Aug '13

Tomas Jelinek has submitted this change and it was merged. Change subject: frontend: handling clusters without DC in VM dialogs ...................................................................... frontend: handling clusters without DC in VM dialogs There is a chance that there will be a cluster which does not have a DC (e.g. the DC has been deleted but the cluster was not). If this happened the UnitVmModel failed on NPE for new/edit VM if some DC has been selected in the system tree. Fixed by ignoring this clusters in the cluster selection dialog. Change-Id: Iab60c088d2299b9f7a9153e917c3a9ceaaa0e2fc Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988018 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17976 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iab60c088d2299b9f7a9153e917c3a9ceaaa0e2fc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: [ExternalTasks] When adding new step...
by emesika＠redhat.com 12 Aug '13

12 Aug '13

Eli Mesika has submitted this change and it was merged. Change subject: core: [ExternalTasks] When adding new step... ...................................................................... core: [ExternalTasks] When adding new step... [ExternalTasks] When adding new step, state is always STARTED Removing the state parameter when adding a new step, it is really set implicitly to STARTED. Change-Id: I16ad3d25d527360b8cfb9eaefc66569700a3e4b0 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988087 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddExternalStepCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddExternalStepParameters.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStepsResource.java 4 files changed, 5 insertions(+), 18 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I16ad3d25d527360b8cfb9eaefc66569700a3e4b0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Underscores in tag names break tags
by emesika＠redhat.com 12 Aug '13

12 Aug '13

Eli Mesika has submitted this change and it was merged. Change subject: core: Underscores in tag names break tags ...................................................................... core: Underscores in tag names break tags Fixing tag regular expression matching in TagHandler. We are adding backslashes for the SQL search query but should remove them when the regular expression is matched. Change-Id: I0925cdba0ed34e3dc68a8396eca0b17589dfa853 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=949484 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17819 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0925cdba0ed34e3dc68a8396eca0b17589dfa853 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine, webadmin: add canDo action to check it qos exists on ...
by alkaplan＠redhat.com 12 Aug '13

12 Aug '13

Alona Kaplan has submitted this change and it was merged. Change subject: engine,webadmin: add canDo action to check it qos exists on VnicProfile ...................................................................... engine,webadmin: add canDo action to check it qos exists on VnicProfile Add canDoAction to AddVnicProfileCommand and UpdateVnicProfileCommand to check that the networkQosId on the commands parameters exists. Change-Id: I6b4ad298c55ca0f3daef99ff333f800202476eff Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVnicProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVnicProfileCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VnicProfileValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VnicProfileValidatorTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 45 insertions(+), 0 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/17974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b4ad298c55ca0f3daef99ff333f800202476eff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0