August 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core: Making sshPort field to be editable always
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: core: Making sshPort field to be editable always ...................................................................... core: Making sshPort field to be editable always sshPort field was set to be editable only when vds is UP, but should be editable in any state. When perform 'edit host' we can change the port number, this can be done from any state. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=989493 Change-Id: I2c5b6a74450f8766fb13d21eea2402f41d431ffa Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18628 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c5b6a74450f8766fb13d21eea2402f41d431ffa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[ovirt-engine-3.3]: build: Fix gwt-debug target in Makefile
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: build: Fix gwt-debug target in Makefile ...................................................................... build: Fix gwt-debug target in Makefile Currently, gwt-debug target executes following command: mvn $(DEV_BUILD_FLAGS) ... This means DEV_BUILD_FLAGS can apply parameters that aren't relevant and/or shouldn't even be specified when launching GWT Developer Mode, such as: -Pgwtdraft [via DEV_BUILD_GWT_DRAFT] -Dgwt.userAgent [via DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS] Since DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS defaults to using Firefox (-Dgwt.userAgent=gecko1_8), if someone wants to debug GWT application in Chrome (or any other browser), he must override DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS with empty string, for example: make gwt-debug webadmin \ DEV_EXTRA_BUILD_FLAGS_GWT_DEFAULTS="" In other words, gwt-debug target shouldn't apply GWT-compile time parameters, such as -Dgwt.userAgent=... Change-Id: I333c3552807e76c722056231a9dedb039c81bdbb Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I333c3552807e76c722056231a9dedb039c81bdbb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Prevent cleanup without setup
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: Prevent cleanup without setup ...................................................................... packaging: setup: Prevent cleanup without setup Change-Id: Ib1dc356976ada9029895b237bd6a0b4771dea64b Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-remove/core/misc.py 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18614 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1dc356976ada9029895b237bd6a0b4771dea64b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: do not delete iptables on cleanup
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: do not delete iptables on cleanup ...................................................................... packaging: setup: do not delete iptables on cleanup Prevent /etc/sysconfig/iptables from being deleted by cleanup after it was updated by setup using otopi. Change-Id: I03f6ea7050aa6dd27809738c588c9778aaa03bce Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18613 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03f6ea7050aa6dd27809738c588c9778aaa03bce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: Remove keys on cleanup after upgrade
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: Remove keys on cleanup after upgrade ...................................................................... packaging: setup: Remove keys on cleanup after upgrade Remove engine_id_rsa, apache-ca.pem and apache.key.nopass on cleanup after upgrade from 3.2. Before this change, many other files were removed in such a case, but not these ones. Change-Id: I06a015fa56594997a17ae073b12b0fcab1c11be7 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/legacy/ca.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06a015fa56594997a17ae073b12b0fcab1c11be7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-3.3]: packaging: setup: remove the distro-rpm/image_upload
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: remove the distro-rpm/image_upload ...................................................................... packaging: setup: remove the distro-rpm/image_upload the files handled by the image_upload are rhel specific are not rpm specific and should be moved to designated downstream. Change-Id: I27aaf92d3f994bf2add2382b905ef813bc611cd0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/distro-rpm/__init__.py D packaging/setup/plugins/ovirt-engine-setup/distro-rpm/image_upload.py 2 files changed, 0 insertions(+), 152 deletions(-) Approvals: Alon Bar-Lev: Verified Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27aaf92d3f994bf2add2382b905ef813bc611cd0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: setup: remove the distro-rpm/image_upload
by oschreib＠redhat.com 28 Aug '13

28 Aug '13

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: setup: remove the distro-rpm/image_upload ...................................................................... packaging: setup: remove the distro-rpm/image_upload the files handled by the image_upload are rhel specific are not rpm specific and should be moved to designated downstream. Change-Id: I27aaf92d3f994bf2add2382b905ef813bc611cd0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/distro-rpm/__init__.py D packaging/setup/plugins/ovirt-engine-setup/distro-rpm/image_upload.py 2 files changed, 0 insertions(+), 152 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27aaf92d3f994bf2add2382b905ef813bc611cd0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: fix RunVmCommandTest
by lhornyak＠redhat.com 28 Aug '13

28 Aug '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: fix RunVmCommandTest ...................................................................... engine: fix RunVmCommandTest OsRepository mocking was missing from the test, while the code was built on the assumption that it is created and configured already. This test failed in unlucky (but not impossible) situations when it ran before any other tests that could have initialized the OsRepository. Change-Id: I6c7b8935273b91da8d1c06eb9c9867212ca022c1 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/18608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c7b8935273b91da8d1c06eb9c9867212ca022c1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Inline a method
by mkolesni＠redhat.com 28 Aug '13

28 Aug '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Inline a method ...................................................................... engine: Inline a method The method is inlined to match the other test convention. Change-Id: I92ca9d112216794d3c63b8f54e33c7f21488b9dd Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java 1 file changed, 2 insertions(+), 6 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/18635 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92ca9d112216794d3c63b8f54e33c7f21488b9dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove unused code
by mkolesni＠redhat.com 28 Aug '13

28 Aug '13

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Remove unused code ...................................................................... engine: Remove unused code The removed method and constant are being used. Change-Id: Ic926cf9f2944bef43fc9e80d23ba80154b9f185b Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java 2 files changed, 6 insertions(+), 19 deletions(-) Approvals: Mike Kolesnik: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/18544 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic926cf9f2944bef43fc9e80d23ba80154b9f185b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0