Change in ovirt-log-collector[master]: HyperVisorData: Run ssh with -n
by sbonazzo＠redhat.com
Sandro Bonazzola has submitted this change and it was merged.
Change subject: HyperVisorData: Run ssh with -n
......................................................................
HyperVisorData: Run ssh with -n
The fix to https://bugzilla.redhat.com/1010472 was to add '-t' to
provide a controlling tty to the remote ausearch. This caused the
tty to be garbled under certain conditions.
A comment in that bug mentions that this is due to ausearch expecting a
log file path on stdin if stdin is a pipe. So this change makes ssh run
with '-n' thus not providing an stdin to the remote command.
Change-Id: Id3e65b5564eb34e72e57f824fb86f9c50acfa1c5
Bug-Url: https://bugzilla.redhat.com/1041749
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/__main__.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Kiril Nesenko: Looks good to me, but someone else must approve
Yedidyah Bar David: Verified
--
To view, visit http://gerrit.ovirt.org/23426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3e65b5564eb34e72e57f824fb86f9c50acfa1c5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: James W. Mills <jamills(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <simone.tiraboschi(a)gmail.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: packaging: setup: database: extend check empty
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: packaging: setup: database: extend check empty
......................................................................
packaging: setup: database: extend check empty
do not check for specific table but if there is any table in public
schema.
Change-Id: I1703886f06afedcc339dfdf8f6c2138fa1c9d8e1
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/database.py
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23732
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1703886f06afedcc339dfdf8f6c2138fa1c9d8e1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
10 years, 3 months
Change in ovirt-guest-agent[master]: Version 1.0.9 update
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: Version 1.0.9 update
......................................................................
Version 1.0.9 update
Change-Id: I4a914522846fb879ed09c47992bc5f13d0456ead
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M configure.ac
M debian/changelog
M debian/copyright
M ovirt-guest-agent.rhel6.spec
M ovirt-guest-agent.spec
5 files changed, 22 insertions(+), 5 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a914522846fb879ed09c47992bc5f13d0456ead
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: ignore reports of lastStopTime from vdsm
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: ignore reports of lastStopTime from vdsm
......................................................................
core: ignore reports of lastStopTime from vdsm
Set VmDynamic#lastStopTime as a field that should not change by VDSM
which will reduce the number of updates in the DB (VmDynamic won't be
updated when nothing relevant was changed)
In addition "id" and "migratingToVds" fields in VmDynamic will also be
marked with the UnchangeableByVdsm annotation as they should not be
changed by VDSM as well
Change-Id: I5e46b87d8ee1753b77d88ce1987c166e7f2e4509
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23177
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e46b87d8ee1753b77d88ce1987c166e7f2e4509
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: replace explicit field names with constants
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: replace explicit field names with constants
......................................................................
core: replace explicit field names with constants
In VdsUpdateRunTimeInfo we used to have explicit strings for "appList"
and "status", representing the names of those fields in VmDynamic.
This patch changes that - new constants are declared in VmDynamic,
which hold those strings and VdsUpdateRunTimeInfo now uses them.
In addition, places where we used to check the size of collections just
to see if they are empty or not are replaced with calls to "isEmpty"
method - it is better in terms of readability and for some data
structures it is more efficient.
Change-Id: I614fecc4238cfffbf152b1b39e3c7995974188c2
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
2 files changed, 9 insertions(+), 6 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23101
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I614fecc4238cfffbf152b1b39e3c7995974188c2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: mark fields that vdsm cannot change with annotation
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: mark fields that vdsm cannot change with annotation
......................................................................
core: mark fields that vdsm cannot change with annotation
We used to have the names of the fields in VmDynamic that cannot be
changed by VDSM hard-coded in VdsUpdateRunTimeInfo (so that if we detect
when we compare the VmDynamic we hold in the DB and the VmDynamic we get
from VDSM that only such kind of fields are different, we will not
update the DB).
But holding the field names hard-coded in VdsUpdateRunTimeInfo is
problematic because:
* It means that the fields are renamed, we need to remember to rename
them in VdsUpdateRunTimeInfo as well
* When new fields that should not be change by VDSM are added to
VmDynamic, we tend to forget to add them to the list that resides in
VdsUpdateRunTimeInfo and it cause the number of unneeded writes to the
DB to increase.
The solution is to mark those fields in VmDynamic with an annotation
which indicates that they cannot be changed by VDSM, and then retrieve
all the fields with that annotation in VdsUpdateRunTimeInfo instead of
using hard-coded list of field names.
In addition, the block of code that maps pause status to audit log type
in VdsUpdateRunTimeInfo#updateRepository is extracted to separate method
to make it a bit shorter and more readable.
Change-Id: I8c1981a7adaa6b4ff3ba4012fbe7318f6488e2ab
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/UnchangeableByVdsm.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
3 files changed, 77 insertions(+), 40 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/22644
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c1981a7adaa6b4ff3ba4012fbe7318f6488e2ab
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-guest-agent[master]: Build fixes
by vfeenstr＠redhat.com
Vinzenz Feenstra has submitted this change and it was merged.
Change subject: Build fixes
......................................................................
Build fixes
* Don't execute PEP8 checks when PEP8 is not installed
* configure.ac: Don't fail on systems where AM_PROG_AR is not yet
available in automake
* m4/fhs.m4 don't fail if neither /var/lock/subsys nor /var/lock
are present
Change-Id: Iaa33a029b2e8fbbbd2e1329814dd8dc182109552
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M Makefile.am
M configure.ac
M m4/fhs.m4
3 files changed, 9 insertions(+), 5 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, approved
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/23747
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa33a029b2e8fbbbd2e1329814dd8dc182109552
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[master]: core: Remove @Ignore annotations from TestHelper
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove @Ignore annotations from TestHelper
......................................................................
core: Remove @Ignore annotations from TestHelper
TestHelper is not a test class (i.e., has no methods annotated with
@Test and does not extend the legacy org.junit.TestCase), so annotating
it or any of its methods with @Ignore is pointless.
Change-Id: Ibfa304bbaf1b20007ce1510d483dab395de2208b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/test/util/TestHelper.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23717
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfa304bbaf1b20007ce1510d483dab395de2208b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine[ovirt-engine-3.3]: core: fix possible NPE on migration failure
by iheim＠redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: fix possible NPE on migration failure
......................................................................
core: fix possible NPE on migration failure
We recently added a call to decrease pending memory from the destination
VDS when migration ends. This code was added to the
MigrateVmCommand#reportCompleted method and we assume that the
destination VDS is not null when we reach that method, but in some cases
where the migration fails we might reach the reportCompleted method
after the destination VDS is set to null (see MigrateVmCommand#rerun).
This patch solves this issue by adding null-check which ensures that the
destination VDS is valid before calling to decrease its pending memory.
Change-Id: If5c975ba5a0824c80be36cb997b3b040b5191192
Bug-Url: https://bugzilla.redhat.com/1048790
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit http://gerrit.ovirt.org/23760
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5c975ba5a0824c80be36cb997b3b040b5191192
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 3 months
Change in ovirt-engine-sdk-java[sdk_3.3]: sdk: Prepare for the next release
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: sdk: Prepare for the next release
......................................................................
sdk: Prepare for the next release
In preparation for the next release this patch increases the micro
version number, adds the SNAPHSOT suffixs to the maven version and sets
the RPM release number to 0.1.
Change-Id: Id43dd793d68fa5f81e10f0ae28e00a90e8b18f03
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M ovirt-engine-sdk-java/Makefile
M ovirt-engine-sdk-java/ovirt-engine-sdk-java.spec.in
M ovirt-engine-sdk-java/pom.xml
3 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23768
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id43dd793d68fa5f81e10f0ae28e00a90e8b18f03
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: sdk_3.3
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
10 years, 3 months