Change in ovirt-reports[master]: authentication: do not leak resources
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: authentication: do not leak resources
......................................................................
authentication: do not leak resources
Change-Id: Ic03a08f1ef136ca7a7b3af6f1102ee3e393e6b7a
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-engine-reports/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java
1 file changed, 15 insertions(+), 19 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yaniv Dary: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/23596
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic03a08f1ef136ca7a7b3af6f1102ee3e393e6b7a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 11 months
Change in ovirt-reports[master]: packaging: setup: move customization of authentication to pr...
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: move customization of authentication to property file
......................................................................
packaging: setup: move customization of authentication to property file
this will enable us not to edit files within the war.
Change-Id: Ib8503fd98fdba775c62e038b953e8100244ec8da
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M .gitignore
M Makefile
M ovirt-engine-reports/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java
R packaging/jasper-customizations/WEB-INF/applicationContext-ovirt-override.xml.in
M packaging/legacy-setup/ovirt-engine-reports-setup.py
5 files changed, 41 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yaniv Dary: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/23537
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8503fd98fdba775c62e038b953e8100244ec8da
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 11 months
Change in ovirt-reports[master]: packaging: setup: no need to use secure ssl in local host
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: no need to use secure ssl in local host
......................................................................
packaging: setup: no need to use secure ssl in local host
reduces complexity of setup.
Change-Id: I51e1e70e1124f545b2fa26ee6717e53a8bc2b325
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/jasper-customizations/WEB-INF/applicationContext-ovirt-override.xml
M packaging/legacy-setup/ovirt-engine-reports-setup.py
2 files changed, 2 insertions(+), 52 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yaniv Dary: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/23536
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I51e1e70e1124f545b2fa26ee6717e53a8bc2b325
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 11 months
Change in ovirt-reports[master]: authentication: pki: cleanup properties
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: authentication: pki: cleanup properties
......................................................................
authentication: pki: cleanup properties
prefix all with ssl, cleanup naming, remove unused getters.
rename: servletURL->getSessionUserGetSessionUserServletURL
expose: sslTrustStoreType
rename: trustStorePath->sslTrustStorePath
rename: trustStorePassword->sslTrrustStorePassword
rename: sslIgnoreCertErrors->sslInsecure
rename: sslIgnoreHostVerification->sslNoHostVerification
sslInsecure also triggers sslNoHostVerification.
Change-Id: I5ebc86f05b508a069e81639356d10477ee0a3acf
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-engine-reports/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java
M packaging/jasper-customizations/WEB-INF/applicationContext-ovirt-override.xml
M packaging/legacy-setup/ovirt-engine-reports-setup.py
3 files changed, 51 insertions(+), 62 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yaniv Dary: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/23535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ebc86f05b508a069e81639356d10477ee0a3acf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 11 months
Change in ovirt-reports[master]: authentication: pki: cleanup
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: authentication: pki: cleanup
......................................................................
authentication: pki: cleanup
- no need for static context verifier
- support non secured with no store
- simplify flow
Change-Id: Ie12f9bb3156ef280147a19c55bab019517b33ee9
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-engine-reports/EngineAuthentication/pom.xml
M ovirt-engine-reports/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java
2 files changed, 66 insertions(+), 51 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yaniv Dary: Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/23534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie12f9bb3156ef280147a19c55bab019517b33ee9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 11 months
Change in ovirt-reports[master]: packaging: setup: always deploy jasper war
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: setup: always deploy jasper war
......................................................................
packaging: setup: always deploy jasper war
remove jasper version detection using rpm or any other method, apply
single upgrade algorithm.
Change-Id: I8799bde82f7c2da2b0a3074ea47e6ffc3eb898cd
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/legacy-setup/common_utils.py
M packaging/legacy-setup/ovirt-engine-reports-setup.py
2 files changed, 30 insertions(+), 122 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23419
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8799bde82f7c2da2b0a3074ea47e6ffc3eb898cd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: core: remove not in use method
by rgolan@redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: remove not in use method
......................................................................
core: remove not in use method
Change-Id: I994a000c9b73299b7230c508304b0f8b5b0eea39
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Roy Golan: Looks good to me, approved
Omer Frenkel: Verified
--
To view, visit http://gerrit.ovirt.org/23630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I994a000c9b73299b7230c508304b0f8b5b0eea39
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Add storage types to DiskImage entity
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Add storage types to DiskImage entity
......................................................................
core: Add storage types to DiskImage entity
Currently DiskImage has a storageIds field that contains a list of the
storages it resides on. It makes sense also to add a storage types field
to avoid having to fetch the storage domain in order to know which storage
type the disk resides on.
This will be helpful when the storage pool storage type property will be
removed.
Change-Id: I8302972bb21fa076cd35fb308f5f660ca9200daa
Relates-To: https://bugzilla.redhat.com/1038053
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java
M packaging/dbscripts/create_views.sql
3 files changed, 34 insertions(+), 1 deletion(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23589
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8302972bb21fa076cd35fb308f5f660ca9200daa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Change connect/disconnect storage commands to type agn...
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Change connect/disconnect storage commands to type agnostic
......................................................................
core: Change connect/disconnect storage commands to type agnostic
As a part of the effort to remove the type of storage pool the connect
and disconnect host to storage command were changed to ignore the specific
type of the connection and instead create a map of all connections divided
by type and connect/disconnect to all type by type
Relates-To: https://bugzilla.redhat.com/1038053
Change-Id: I07a7fb8af9ce89a38b51cdb07a43a15f9c13f839
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePooServerCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java
3 files changed, 49 insertions(+), 162 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23588
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07a7fb8af9ce89a38b51cdb07a43a15f9c13f839
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: core: Changed storage type check in ConnectAllHostsToLun com...
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: Changed storage type check in ConnectAllHostsToLun command
......................................................................
core: Changed storage type check in ConnectAllHostsToLun command
As a part of the effort to remove the type of storage pool the
StoragerHelper getter in ConnectAllHostsToLun command was change from the
storage pool type to the storage domain type
Change-Id: Ifde05e609e9d7f7a02d6447047a434153770d514
Relates-To: https://bugzilla.redhat.com/1038053
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23587
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifde05e609e9d7f7a02d6447047a434153770d514
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months