Change in ovirt-engine[ovirt-engine-3.4]: restapi: Don't use method names to infer types
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: restapi: Don't use method names to infer types
......................................................................
restapi: Don't use method names to infer types
Currently when we randomly populate objects in order to run tests, we
infer the types of objects contained in lists from the names of the
methods. For example, lets say that we have an object that has a
"getNics()" method that returns a list of "Nics" objects. We use the
word after the "get" prefix to infer the type. In this case we infer
that the type will be "Nics". But doing this has the dissadvantage that
we force ourselves to use method names (and thus tag names in the XML
representation) that match the type names. There was no reasonable
alternative in Java 6, but in Java 7 we can obtain the type of the
elements of the list directly. This is what we do in this patch.
Change-Id: Iadc9827c3885d7b9e39611b006a1b02eefa5c9f0
Bug-Url: https://bugzilla.redhat.com/1051041
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 19b0310a1107dee0df60d2871fc24b24d2d3a474)
---
M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/MappingTestHelper.java
1 file changed, 3 insertions(+), 64 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23624
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadc9827c3885d7b9e39611b006a1b02eefa5c9f0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: engine: Block moving host with QoS to older cluster
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Block moving host with QoS to older cluster
......................................................................
engine: Block moving host with QoS to older cluster
This patch blocks the possibility of moving a host from a cluster that
supports Host Network QoS to one that doesn't, if any of the host's
network interfaces have any QoS capping on them.
Change-Id: I697617fcb943590f2437add7591a81a0b3a0cf3b
Bug-Url: https://bugzilla.redhat.com/1054322
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 15 insertions(+), 3 deletions(-)
Approvals:
Itamar Heim: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23405
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I697617fcb943590f2437add7591a81a0b3a0cf3b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: engine: Block sync of network with QoS when not supported
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: engine: Block sync of network with QoS when not supported
......................................................................
engine: Block sync of network with QoS when not supported
When a QoS entity is attached to network, the network is supposed to
appear as out-of-sync on a host, no matter the cluster compatibility
version of the host. However, when the host's cluster doesn't support
Host Network QoS, it shouldn't be possible to then synchronize the
network (which whould also apply QoS to it).
Change-Id: Ie79c6463676b82f1743fb162fc6c660dd88756f8
Bug-Url: https://bugzilla.redhat.com/1054320
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
2 files changed, 54 insertions(+), 21 deletions(-)
Approvals:
Mike Kolesnik: Looks good to me, approved
Lior Vernia: Verified
--
To view, visit http://gerrit.ovirt.org/23404
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie79c6463676b82f1743fb162fc6c660dd88756f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: core: fix type in VdsDeploy
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core: fix type in VdsDeploy
......................................................................
core: fix type in VdsDeploy
Change-Id: I6d5b0784be20e37f95348af33a217dead0fd5ffb
Bug-Url: https://bugzilla.redhat.com/1056307
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, but someone else must approve
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23562
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d5b0784be20e37f95348af33a217dead0fd5ffb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-live[master]: ovirt-live: update ovirt live answer file for complete autom...
by obasan@redhat.com
Ohad Basan has submitted this change and it was merged.
Change subject: ovirt-live: update ovirt live answer file for complete automatic setup
......................................................................
ovirt-live: update ovirt live answer file for complete automatic setup
Change-Id: Ia2de2323ccadd9fb6886bbcd00f04874ba072e72
---
M centos/oVirtLiveFiles/root/home/liveuser/oVirtLiveFiles/ovirt-answer
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Ohad Basan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2de2323ccadd9fb6886bbcd00f04874ba072e72
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[master]: core: removing auto-generated TODO
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: removing auto-generated TODO
......................................................................
core: removing auto-generated TODO
Change-Id: I88e04a7a19660039d9e6ea3641e867d52df6ab7a
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ExternalSchedulerBrokerImpl.java
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23597
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88e04a7a19660039d9e6ea3641e867d52df6ab7a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
10 years, 11 months
Change in ovirt-engine[ovirt-engine-3.4]: core, webadmin: Move storage type checks to domain instead of...
by iheim@redhat.com
Itamar Heim has submitted this change and it was merged.
Change subject: core,webadmin: Move storage type checks to domain instead of pool
......................................................................
core,webadmin: Move storage type checks to domain instead of pool
As a part of the effort to remove the type of storage pool, checks of the
storage type are changed to check the type on the storage domain instead of
the storage pool
Change-Id: I3db80f1749d93444e9cdac8038859b7d0865f6e5
Relates-To: https://bugzilla.redhat.com/1038053
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/LiveSnapshotMemoryImageBuilder.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetDiskAlignmentCommandTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
8 files changed, 51 insertions(+), 23 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23584
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3db80f1749d93444e9cdac8038859b7d0865f6e5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[master]: 4. webadmin: Change LoginPopup to present clickable password...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: 4. webadmin: Change LoginPopup to present clickable password URL change
......................................................................
4. webadmin: Change LoginPopup to present clickable password URL change
Change-Id: I502cfcad23c3500f1e87e3f45657cf61e9c36d69
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractLoginPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginPopupView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java
4 files changed, 28 insertions(+), 8 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23373
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I502cfcad23c3500f1e87e3f45657cf61e9c36d69
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[master]: 3. webadmin: Added appropriate AppErrors message for change ...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: 3. webadmin: Added appropriate AppErrors message for change password URL
......................................................................
3. webadmin: Added appropriate AppErrors message for change password URL
Change-Id: Ic843923f3c97f69b6faa82d85ff776e97282db34
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic843923f3c97f69b6faa82d85ff776e97282db34
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months
Change in ovirt-engine[master]: 2. core: Adding support for returning password URL change to...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: 2. core: Adding support for returning password URL change to client
......................................................................
2. core: Adding support for returning password URL change to client
This patch performs the following:
1. Change to AuthenticationResult - no need to hold the detailedInfo
classes can extend AuthenticationResult and hold information in fields if neede
2. Handling fetching the password change URL and attaching it to the canDoAction
messages in case the password has expired.
Change-Id: I0825b1624696e687d76b867f4844f7016819cf2c
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/internal/InternalAuthenticator.java
M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/nop/NopAuthenticationResult.java
M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/nop/NopAuthenticator.java
M backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/result/BooleanAuthenticationResult.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/authentication/provisional/ProvisionalAuthenticationResult.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/authentication/provisional/ProvisionalAuthenticator.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationResult.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
10 files changed, 73 insertions(+), 47 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23319
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0825b1624696e687d76b867f4844f7016819cf2c
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 11 months