January 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.3]: core : Search box with value "Events: Templates =*" gives er...
by iheim＠redhat.com 07 Jan '14

07 Jan '14

Itamar Heim has submitted this change and it was merged. Change subject: core : Search box with value "Events: Templates =*" gives error from webadmin ...................................................................... core : Search box with value "Events: Templates =*" gives error from webadmin Searching for templates from Webadmin search box with value "Events: Templates =*" throws bad SQL grammar exception Change-Id: I40393c976721440306bbe402e2e7dcc7f7fbded1 Bug-Url: https://bugzilla.redhat.com/1003796 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40393c976721440306bbe402e2e7dcc7f7fbded1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.3 Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core : Search box with value "Events: Templates =*" gives er...
by rgolan＠redhat.com 07 Jan '14

07 Jan '14

Roy Golan has submitted this change and it was merged. Change subject: core : Search box with value "Events: Templates =*" gives error from webadmin ...................................................................... core : Search box with value "Events: Templates =*" gives error from webadmin Searching for templates from Webadmin search box with value "Events: Templates =*" throws bad SQL grammar exception Change-Id: I40393c976721440306bbe402e2e7dcc7f7fbded1 Bug-Url: https://bugzilla.redhat.com/1003796 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VmTemplateConditionFieldAutoCompleter.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23049 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I40393c976721440306bbe402e2e7dcc7f7fbded1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Eli Mesika <elimesika(a)gmail.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: findbugs: inconsistent synchronization
by oourfali＠redhat.com 07 Jan '14

07 Jan '14

Oved Ourfali has submitted this change and it was merged. Change subject: core: findbugs: inconsistent synchronization ...................................................................... core: findbugs: inconsistent synchronization AsyncTasksManager is currently the only class with suffers from inconsistent synchronization. This patch does not solve those issues (in an attempt to "not rock the boat", but preserve the current situation). It does, however, move the exclusion of this check out of exclude-filters-general.xml and fine-grains it to exclude only AsyncTasksManager in order to avoid these potentially dangerous bugs in future classes. Change-Id: Iafbd7c713584ca08b2e74617e289554425ac2b68 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/exclude-filters.xml M exclude-filters-general.xml 2 files changed, 4 insertions(+), 10 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23035 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iafbd7c713584ca08b2e74617e289554425ac2b68 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-reports[ovirt-3.3]: packaging: fixed issues with setup logic
by ydary＠redhat.com 07 Jan '14

07 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed issues with setup logic ...................................................................... packaging: fixed issues with setup logic Bug-Url: https://bugzilla.redhat.com/1047521 Bug-Url: https://bugzilla.redhat.com/1047125 Bug-Url: https://bugzilla.redhat.com/1047117 Change-Id: I35be9a7bbf46ff99885d8ade800fcaa8706aa44f Signed-off-by: Yaniv Dary <ydary(a)redhat.com> Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-reports-setup.py 2 files changed, 215 insertions(+), 200 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23047 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35be9a7bbf46ff99885d8ade800fcaa8706aa44f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-dwh[ovirt-3.3]: packaging: setup: fix ugprade with remote db
by ydary＠redhat.com 07 Jan '14

07 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fix ugprade with remote db ...................................................................... packaging: setup: fix ugprade with remote db Change-Id: Ibd68ae47e3b1b21b9cb79e0c351706d166941c9a Bug-Url: https://bugzilla.redhat.com/1046676 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/ovirt-engine-dwh-setup.py 1 file changed, 43 insertions(+), 37 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23046 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd68ae47e3b1b21b9cb79e0c351706d166941c9a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-reports[master]: packaging: fixed issues with setup logic
by ydary＠redhat.com 07 Jan '14

07 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed issues with setup logic ...................................................................... packaging: fixed issues with setup logic Bug-Url: https://bugzilla.redhat.com/1047521 Bug-Url: https://bugzilla.redhat.com/1047125 Bug-Url: https://bugzilla.redhat.com/1047117 Change-Id: I35be9a7bbf46ff99885d8ade800fcaa8706aa44f Signed-off-by: Yaniv Dary <ydary(a)redhat.com> Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/common_utils.py M packaging/ovirt-engine-reports-setup.py 2 files changed, 215 insertions(+), 200 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35be9a7bbf46ff99885d8ade800fcaa8706aa44f Gerrit-PatchSet: 9 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: setup: fix ugprade with remote db
by ydary＠redhat.com 07 Jan '14

07 Jan '14

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: setup: fix ugprade with remote db ...................................................................... packaging: setup: fix ugprade with remote db Change-Id: Ibd68ae47e3b1b21b9cb79e0c351706d166941c9a Bug-Url: https://bugzilla.redhat.com/1046676 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/legacy-setup/ovirt-engine-dwh-setup.py 1 file changed, 43 insertions(+), 37 deletions(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22961 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd68ae47e3b1b21b9cb79e0c351706d166941c9a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.0]: packaging: setup: wait for cluster to become ready
by sbonazzo＠redhat.com 07 Jan '14

07 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: wait for cluster to become ready ...................................................................... packaging: setup: wait for cluster to become ready Change-Id: I6a6fb4bdafe37e363aefae11a2655a4189ae2ecb Bug-Url: https://bugzilla.redhat.com/1048479 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 31 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/23042 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a6fb4bdafe37e363aefae11a2655a4189ae2ecb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.0 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[master]: packaging: setup: wait for cluster to become ready
by sbonazzo＠redhat.com 07 Jan '14

07 Jan '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: wait for cluster to become ready ...................................................................... packaging: setup: wait for cluster to become ready Change-Id: I6a6fb4bdafe37e363aefae11a2655a4189ae2ecb Bug-Url: https://bugzilla.redhat.com/1048479 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M src/plugins/ovirt-hosted-engine-setup/engine/add_host.py 1 file changed, 31 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/22955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a6fb4bdafe37e363aefae11a2655a4189ae2ecb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Rename GetNetworksByStoragePoolIdQuery
by mkolesni＠redhat.com 07 Jan '14

07 Jan '14

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Rename GetNetworksByStoragePoolIdQuery ...................................................................... engine: Rename GetNetworksByStoragePoolIdQuery The query is renamed to GetNetworksByDataCenterIdQuery. Change-Id: Ieaa2c9e86adbbc65c1ca673923a97277c678caf3 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- R backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetNetworksByDataCenterIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworksResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworkResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDataCenterNetworksResourceTest.java 5 files changed, 13 insertions(+), 13 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/22443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieaa2c9e86adbbc65c1ca673923a97277c678caf3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0