Change in ovirt-engine-sdk-java[master]: codegen: Use files instead of HTTP requests
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: codegen: Use files instead of HTTP requests
......................................................................
codegen: Use files instead of HTTP requests
Currently the code generator issues HTTP requests to a live engine in
order to retrieve the XML schema of the entities and the RSDL. This
complicates the execution of the code generator and it makes difficult
to know exactly which schema and which RSDL was used to generate the
code. This patch adds the XML schema and the RSDL document to the
repository, in the following two files:
src/main/resources/api.xsd
src/main/resources/api.rsdl
These files are initially added empty, to avoid mixing the changes to
the code with the changes to these documents. The next patch will add
the actual files from the latest master.
The patch also modifies the generator so that it instead of connecting
to a live engine it uses always these two files.
When the XML schema or the RSDL need to be updated it can be done
manually or using the new "update-metadata" profile:
mvn validate -Pupdate-metadata \
-Dapi.url=https://localhost/ovirt-engine/api \
-Dapi.user=admin@internal \
-Dapi.password=letmein!
This will download the files from the live engine and update the local
copies, which will then need to be manually commited to the source
repository.
Change-Id: Id273997a87e1e1c0882fd5a789fa7e057b20734a
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M .gitignore
M ovirt-engine-sdk-java-codegen/pom.xml
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/common/AbstractCodegen.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/common/ICodegen.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/ApiCodegen.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/rsdl/RsdlCodegen.java
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/xsd/XsdCodegen.java
A ovirt-engine-sdk-java-codegen/src/main/resources/README
A ovirt-engine-sdk-java-codegen/src/main/resources/api.rsdl
A ovirt-engine-sdk-java-codegen/src/main/resources/api.xsd
11 files changed, 287 insertions(+), 215 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22990
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id273997a87e1e1c0882fd5a789fa7e057b20734a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
10 years, 4 months
Change in ovirt-engine[master]: engine: exception on run once when changed display protocol
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: exception on run once when changed display protocol
......................................................................
engine: exception on run once when changed display protocol
Regression from: af23e740b091832d9f12dc47083fe89007ad9b87
The problem was that the VdsProperties.Device part of the video card was added
as VmDeviceType which was not possible to serialize.
Fixed by getting the String out of it the same way as it used to be.
Change-Id: I89127115b9925574a45e5d81a90bbad2c01e3d22
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23019
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I89127115b9925574a45e5d81a90bbad2c01e3d22
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Kobi Ianko <kobi(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
10 years, 4 months
Change in ovirt-engine[master]: engine: Guard against old VDSM sending QoS as string
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: engine: Guard against old VDSM sending QoS as string
......................................................................
engine: Guard against old VDSM sending QoS as string
When no QoS was defined on a host, old versions (between 3.3 and 3.4)
of VDSM would send empty strings in the inbound/outbound entries,
where in fact they should have sent integers (and in the case of no
QoS no entries at all). This guards against such entries.
Change-Id: I8b68989bd6e8ca1ebf6e2f23e8bea3769f4ce5a9
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23026
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b68989bd6e8ca1ebf6e2f23e8bea3769f4ce5a9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Refactored Network QoS frontend code
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Refactored Network QoS frontend code
......................................................................
webadmin: Refactored Network QoS frontend code
Extracted the part concerned with the actual QoS values into
BaseNetworkQosModel and NetworkQoSpopupView, to be reusable from an
"anonymous" context (where name and DC are irrelevant).
Change-Id: I757d43302799cd5fc4c3006377a86c2841f39ea5
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/BaseNetworkQosModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/EditNetworkQoSModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkQoSModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkQosParametersModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkQoSModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQoSPopupView.ui.xml
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQosWidget.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/networkQoS/NetworkQosWidget.ui.xml
9 files changed, 429 insertions(+), 351 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I757d43302799cd5fc4c3006377a86c2841f39ea5
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Refactored edit host network code
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Refactored edit host network code
......................................................................
webadmin: Refactored edit host network code
There was a lot of common code between the supposedly different
dialogs of Edit (Host) Network and Edit Management Network, so I
unified it.
Change-Id: If78775d9cf038820cb164b9a52d7f47b58fea6b6
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/HostModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostManagementPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/SetupNetworksInterfacePopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/SetupNetworksManagementPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInterfacePopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostManagementPopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksManagementPopupView.java
14 files changed, 212 insertions(+), 819 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If78775d9cf038820cb164b9a52d7f47b58fea6b6
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: engine: Moved more QoS validation to NetworkQosValidator
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: engine: Moved more QoS validation to NetworkQosValidator
......................................................................
engine: Moved more QoS validation to NetworkQosValidator
A few more methods will now be used elsewhere in the code, so they
were also moved into this class.
Change-Id: I6b5b374ff7da21de19851bdff6df4a2f53f0dd0e
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/AddNetworkQoSCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/NetworkQoSCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/qos/UpdateNetworkQoSCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkQosValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkQosValidatorTest.java
5 files changed, 194 insertions(+), 35 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22765
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b5b374ff7da21de19851bdff6df4a2f53f0dd0e
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: core: Added QoS overridden member to VdsNetworkInterface
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: Added QoS overridden member to VdsNetworkInterface
......................................................................
core: Added QoS overridden member to VdsNetworkInterface
This boolean member represents whether QoS is allowed to be overridden
on the interface, in which case the network won't appear out-of-sync
even if its own QoS configuration is different.
Change-Id: Iaffc4c2f5b35ed34bf64e4d892a0e9ed64f94bde
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoDbFacadeImpl.java
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/network_sp.sql
A packaging/dbscripts/upgrade/03_04_0370_add_qos_overridden_to_vds_interface.sql
5 files changed, 33 insertions(+), 6 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22764
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaffc4c2f5b35ed34bf64e4d892a0e9ed64f94bde
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-engine[master]: packaging: setup: workaround python module wooes
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: packaging: setup: workaround python module wooes
......................................................................
packaging: setup: workaround python module wooes
for some reason when python loads a module it consider only short
name of module and ignores the location from which module was loaded,
so it reuses module when trying to load same module short name from
other package.
this cause the following statement in ovirt_engine.py to reuse self
instead of loading correct module:
from ovirt_engine import util as outil
work around is to rename current module name:
apache/ovirt_engine.py -> apache/engine.py
Change-Id: I19607ba117d59e310310694648e116d684f9eb2d
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/__init__.py
R packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/apache/engine.py
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/23009
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19607ba117d59e310310694648e116d684f9eb2d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months
Change in ovirt-dwh[master]: history: added ksm shared memory percent to collection
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: history: added ksm shared memory percent to collection
......................................................................
history: added ksm shared memory percent to collection
Change-Id: Iad0a026652f25b5a765a50b9aa0e064eed7ca0bb
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M etl_export/src/ovirt_engine_dwh/aggregationtodaily_3_4/AggregationToDaily.java
M etl_export/src/ovirt_engine_dwh/aggregationtohourly_3_4/AggregationToHourly.java
M etl_export/src/ovirt_engine_dwh/historyetl_3_4/HistoryETL.java
M etl_export/src/ovirt_engine_dwh/statisticssync_3_4/StatisticsSync.java
M packaging/dbscripts/create_views_3_4.sql
A packaging/dbscripts/upgrade/03_02_0000_set_version.sql
A packaging/dbscripts/upgrade/03_04_0010_add_ksm_shared_mem.sql
M tos_project/process/AggregationToDaily_3.4.item
M tos_project/process/AggregationToDaily_3.4.properties
M tos_project/process/AggregationToHourly_3.4.item
M tos_project/process/AggregationToHourly_3.4.properties
M tos_project/process/HistoryETL_3.4.properties
M tos_project/process/StatisticsSync_3.4.item
M tos_project/process/StatisticsSync_3.4.properties
M tos_project/talend.project
15 files changed, 813 insertions(+), 188 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iad0a026652f25b5a765a50b9aa0e064eed7ca0bb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
10 years, 4 months
Change in ovirt-engine[master]: webadmin: Add QoS button in Add/Edit Network dialog
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: webadmin: Add QoS button in Add/Edit Network dialog
......................................................................
webadmin: Add QoS button in Add/Edit Network dialog
Added the ability to add a new QoS entity through the Add/Edit Network
dialog, in case no fitting QoS entity exists.
Change-Id: Ia62cb0da531a06c782d9d753f46bb9f7c48a5b9a
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkQoSModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/NetworkModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/AbstractNetworkPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.ui.xml
7 files changed, 73 insertions(+), 12 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/22683
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia62cb0da531a06c782d9d753f46bb9f7c48a5b9a
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 4 months