Change in ovirt-engine[master]: webadmin: VmSnapshotList - filter LunDisks on getVmDiskList
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: VmSnapshotList - filter LunDisks on getVmDiskList
......................................................................
webadmin: VmSnapshotList - filter LunDisks on getVmDiskList
VmSnapshotList -> updatePreviewedDiskSnapshots:
filer LunDisks from 'getVmDiskList' result.
Change-Id: Iaf983d1a8095b8739cd0e4ff4a872100f3e2c921
Bug-Url: https://bugzilla.redhat.com/1148424
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
1 file changed, 11 insertions(+), 5 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
--
To view, visit http://gerrit.ovirt.org/33722
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf983d1a8095b8739cd0e4ff4a872100f3e2c921
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: frontend: Fix disk creation NPE on diskprofile selection
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: frontend: Fix disk creation NPE on diskprofile selection
......................................................................
frontend: Fix disk creation NPE on diskprofile selection
I was getting a NullPointer Exception when adding disks in oVirt 3.5
prerelease.
Bug-Url: https://bugzilla.redhat.com/1149442
Change-Id: Ia3338051ae3888fb672419c6a4a9cb1cc03e6fde
Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Antoni Segura Puimedon: Looks good to me, but someone else must approve
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33802
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3338051ae3888fb672419c6a4a9cb1cc03e6fde
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: avoid sending NUMA values if not specified
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: avoid sending NUMA values if not specified
......................................................................
core: avoid sending NUMA values if not specified
Currently NUMA Tune Mode is sent even if VM doesn't have
virtual NUMA nodes configured.
Change-Id: I306a3004861295a6743288e5ed3a70cfdd49398d
Bug-Url: https://bugzilla.redhat.com/1147261
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I306a3004861295a6743288e5ed3a70cfdd49398d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Handle NUMA preferred tune mode
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Handle NUMA preferred tune mode
......................................................................
core: Handle NUMA preferred tune mode
This patch addresses 3 issues:
- 5892ef11 added NumaTuneMode to VmBase, so we need to update all
VmStatic elements (VM templates) that was added since.
- libvirt failure when running in preferred mode without specifying
numa nodes. Added validation to add/edit VM to fail command when preferred
numa tune set and there is no single VM node configured pinned to NUMA
node.
Change-Id: I637fb996d06e97d55bdd8309a668307cac8bb546
Bug-Url: https://bugzilla.redhat.com/1146445
Bug-Url: https://bugzilla.redhat.com/1147261
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
A packaging/dbscripts/upgrade/03_05_1080_set_interleave_default_value_for_numa_tune_mode.sql
8 files changed, 58 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33732
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I637fb996d06e97d55bdd8309a668307cac8bb546
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Move cpu_over_commit from VdsDynamic to VdsStatistics
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Move cpu_over_commit from VdsDynamic to VdsStatistics
......................................................................
core: Move cpu_over_commit from VdsDynamic to VdsStatistics
cpu_over_commit field is rapidly changing, and should be located in VdsStatistics.
This patch moves it to vds_statistics and updates the relevant stored procedures
and DAOs
Change-Id: I604132f9f05c8470ff09196db77eea2957899e2a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1114285
Signed-off-by: lzelkha(a)redhat.com <lzelkha(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatistics.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationEntitiesTest.java
M packaging/dbscripts/create_views.sql
A packaging/dbscripts/upgrade/03_05_1070_move_cpu_over_commit_to_vds_stats.sql
M packaging/dbscripts/vds_sp.sql
10 files changed, 47 insertions(+), 44 deletions(-)
Approvals:
Roy Golan: Looks good to me, approved
Liran Zelkha: Verified
--
To view, visit http://gerrit.ovirt.org/33794
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I604132f9f05c8470ff09196db77eea2957899e2a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: Handle NUMA preferred tune mode
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: Handle NUMA preferred tune mode
......................................................................
core: Handle NUMA preferred tune mode
This patch addresses 3 issues:
- 5892ef11 added NumaTuneMode to VmBase, so we need to update all
VmStatic elements (VM templates) that was added since.
- libvirt failure when running in preferred mode without specifying
numa nodes. Added validation to add/edit VM to fail command when preferred
numa tune set and there is no single VM node configured pinned to NUMA
node.
Change-Id: I637fb996d06e97d55bdd8309a668307cac8bb546
Bug-Url: https://bugzilla.redhat.com/1146445
Bug-Url: https://bugzilla.redhat.com/1147261
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/numa/vm/AbstractVmNumaNodeCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
A packaging/dbscripts/upgrade/03_06_0420_set_interleave_default_value_for_numa_tune_mode.sql
8 files changed, 58 insertions(+), 0 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Gilad Chaplik: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33517
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I637fb996d06e97d55bdd8309a668307cac8bb546
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: avoid sending NUMA values if not specified
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: core: avoid sending NUMA values if not specified
......................................................................
core: avoid sending NUMA values if not specified
Currently NUMA Tune Mode is sent even if VM doesn't have
virtual NUMA nodes configured.
Change-Id: I306a3004861295a6743288e5ed3a70cfdd49398d
Bug-Url: https://bugzilla.redhat.com/1147261
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33731
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I306a3004861295a6743288e5ed3a70cfdd49398d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: webadmin: rename import-vm related classes
by ahadas＠redhat.com
Arik Hadas has submitted this change and it was merged.
Change subject: webadmin: rename import-vm related classes
......................................................................
webadmin: rename import-vm related classes
The import-vm operation is about to be extended soon for different
use-cases. This patch rename the classes in the frontend which are
related to the import-vm operation such that it would reflect they are
related specifically to the import vm from export domain operation.
Change-Id: Ia36fae2b061ed51d76739546f9914abc06689d6e
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java
R frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmFromExportDomainModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/StorageModule.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/storage/backup/ImportTemplatePopupPresenterWidget.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/storage/backup/ImportVmFromExportDomainPopupPresenterWidget.java
D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/storage/backup/ImportVmPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportTemplatePopupView.java
R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.java
R frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/backup/ImportVmFromExportDomainPopupView.ui.xml
12 files changed, 63 insertions(+), 63 deletions(-)
Approvals:
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33719
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia36fae2b061ed51d76739546f9914abc06689d6e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: frontend: Fix disk creation NPE on diskprofile selection
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: frontend: Fix disk creation NPE on diskprofile selection
......................................................................
frontend: Fix disk creation NPE on diskprofile selection
I was getting a NullPointer Exception when adding disks in oVirt 3.5
prerelease.
Change-Id: Ia3338051ae3888fb672419c6a4a9cb1cc03e6fde
Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33735
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3338051ae3888fb672419c6a4a9cb1cc03e6fde
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.2]: Use monotonic time to compute intervals in broker's submonitors
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: Use monotonic time to compute intervals in broker's submonitors
......................................................................
Use monotonic time to compute intervals in broker's submonitors
The submonitors stopped reporting data when the system time
on a host was moved backwards.
Change-Id: I775ec7b9f11b253d06c45eb01a765123088944aa
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1036683
Signed-off-by: Martin Sivak <mars(a)montik.net>
(cherry picked from commit a77563b17962aa36680605669d2a774c9b3aea00)
---
M ovirt_hosted_engine_ha/broker/submonitor_base.py
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Jiří Moskovčák: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/33769
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I775ec7b9f11b253d06c45eb01a765123088944aa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.2
Gerrit-Owner: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months