Change in ovirt-engine[master]: core: error fix: removed statement negation
by lvernia＠redhat.com
Lior Vernia has submitted this change and it was merged.
Change subject: core: error fix: removed statement negation
......................................................................
core: error fix: removed statement negation
statement labelAdded() was mistakenly negated.
Change-Id: I00966d8cb83b2d51562dcf4b5c5ab04fd01f448e
Bug-Url: https://bugzilla.redhat.com/1142203
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Martin Mucha: Verified
Lior Vernia: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33846
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00966d8cb83b2d51562dcf4b5c5ab04fd01f448e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 7 months
Change in ovirt-engine[ovirt-engine-3.5]: core: Import image from glance storage allocation
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Import image from glance storage allocation
......................................................................
core: Import image from glance storage allocation
This patch is a part of a series of patches, adding storage allocation
validations to the system when they're missing, and replacing old
verification usage with unified, new, correct and tested verification.
This patch did this for ImportRepoImageCommand, using only existing
validations.
Reorganized sparse/preallocated determination as part of the CDA flow as
to have the correct storage allocation validation.
Change-Id: I60b7f13d8f64608f97e4eeebe2f9eef3087d9920
Bug-Url: https://bugzilla.redhat.com/1053750
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportRepoImageCommandTest.java
3 files changed, 28 insertions(+), 24 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/33850
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60b7f13d8f64608f97e4eeebe2f9eef3087d9920
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 7 months
Change in ovirt-engine[master]: core: Import image from glance storage allocation
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Import image from glance storage allocation
......................................................................
core: Import image from glance storage allocation
This patch is a part of a series of patches, adding storage allocation
validations to the system when they're missing, and replacing old
verification usage with unified, new, correct and tested verification.
This patch did this for ImportRepoImageCommand, using only existing
validations.
Reorganized sparse/preallocated determination as part of the CDA flow as
to have the correct storage allocation validation.
Change-Id: I60b7f13d8f64608f97e4eeebe2f9eef3087d9920
Bug-Url: https://bugzilla.redhat.com/1053750
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCreateTaskHandler.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportRepoImageCommandTest.java
3 files changed, 28 insertions(+), 24 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/33844
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60b7f13d8f64608f97e4eeebe2f9eef3087d9920
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 7 months
Change in ovirt-engine[master]: core: cleanup - removed stale JavaDoc params
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: cleanup - removed stale JavaDoc params
......................................................................
core: cleanup - removed stale JavaDoc params
In RunVmValidator
Change-Id: Ia4f1bea2f13077869233dd9218cbbd5f4ceb4845
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
1 file changed, 4 insertions(+), 8 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/33799
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4f1bea2f13077869233dd9218cbbd5f4ceb4845
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 7 months
Change in ovirt-engine[master]: db:add tab/col name validation to common functions
by emesika＠redhat.com
Eli Mesika has submitted this change and it was merged.
Change subject: db:add tab/col name validation to common functions
......................................................................
db:add tab/col name validation to common functions
No error thrown in common_sp functions in case column or table does not
exists.
This patch adds validations to drop/change type/rename column common
functions in order to prevent the setup continue in case that there was
an error in the table/column name.
This patch also fix some upgrade scripts that used invalid/non-existing
column names.
Change-Id: Iba5f087f3d47b4f36bb99151a21c2e1016d77b64
Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1141829
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M packaging/dbscripts/common_sp.sql
M packaging/dbscripts/upgrade/03_03_0060_drop_desktop_device.sql
M packaging/dbscripts/upgrade/03_03_0380_remove_auto_suspend.sql
M packaging/dbscripts/upgrade/03_03_0710_add_profile_to_network_interface.sql
4 files changed, 14 insertions(+), 3 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32959
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba5f087f3d47b4f36bb99151a21c2e1016d77b64
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 7 months
Change in ovirt-hosted-engine-ha[ovirt-hosted-engine-ha-1.1]: don't die when broker disconnects
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: don't die when broker disconnects
......................................................................
don't die when broker disconnects
Change-Id: Ibd8627346c03894c1654af5d41c3caaf9f3a5ffa
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1093646
Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/agent.py
M ovirt_hosted_engine_ha/agent/constants.py.in
M ovirt_hosted_engine_ha/agent/hosted_engine.py
M ovirt_hosted_engine_ha/lib/brokerlink.py
4 files changed, 31 insertions(+), 4 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jiří Moskovčák: Verified
--
To view, visit http://gerrit.ovirt.org/33849
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd8627346c03894c1654af5d41c3caaf9f3a5ffa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: ovirt-hosted-engine-ha-1.1
Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 7 months
Change in ovirt-engine[master]: core: MoveVmCommand storage allocation
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: MoveVmCommand storage allocation
......................................................................
core: MoveVmCommand storage allocation
This patch is a part of a series of patches, fixing storage allocation
validations throughout the system.
In this patch MoveVmCommand is now using correct validations - as they
were already implemented in the superclass MoveOrCopyTemplateCommand.
Change-Id: I9d0600d21573cae4ef278a4c0951724449e4eded
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java
1 file changed, 1 insertion(+), 9 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/33811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d0600d21573cae4ef278a4c0951724449e4eded
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 7 months
Change in ovirt-engine[master]: core: Removed redundant tests
by amureini＠redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Removed redundant tests
......................................................................
core: Removed redundant tests
After the refactoring of storage allocation there's no longer need for
tests of the 'old' verifications in StorageDomainValidatorTest.
Removed.
Change-Id: I5270d2ee1c1a567f61ab9813ffe2d223e062d8a0
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java
1 file changed, 0 insertions(+), 29 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Vered Volansky: Verified
--
To view, visit http://gerrit.ovirt.org/33708
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5270d2ee1c1a567f61ab9813ffe2d223e062d8a0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
9 years, 7 months
Change in ovirt-host-deploy[master]: packaging: ovirt-host-deploy-1.3.0
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: ovirt-host-deploy-1.3.0
......................................................................
packaging: ovirt-host-deploy-1.3.0
Change-Id: Iaa6bf1f0be88514812958c48862088ab4a9a5c5d
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M configure.ac
M ovirt-host-deploy-offline.spec.in
M ovirt-host-deploy.spec.in
4 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33842
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa6bf1f0be88514812958c48862088ab4a9a5c5d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months
Change in ovirt-host-deploy[master]: packaging: post ovirt-host-deploy-1.3.0
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: packaging: post ovirt-host-deploy-1.3.0
......................................................................
packaging: post ovirt-host-deploy-1.3.0
Change-Id: I3eb9eeac851e18bd4566c6c18e53ade755027dcf
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ChangeLog
M configure.ac
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33843
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3eb9eeac851e18bd4566c6c18e53ade755027dcf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
9 years, 7 months