October 2014 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-3.5]: restapi: Validate QoS type
by piotr.kliczewski＠gmail.com 03 Oct '14

03 Oct '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi: Validate QoS type ...................................................................... restapi: Validate QoS type Currently when a QoS is added to a data center we don't validate that the mandatory type is specified. This eventually triggers a NPE when validating the value. To avoid this this patch adds the validation and modifies the type validator so that it won't fail if no type is provided. Change-Id: I90b62c4f4499dcc4abec5495a9907102e213df0e Bug-Url: https://bugzilla.redhat.com/1148773 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit ba3dbd7a4e7e8f516445a9717c9f7a74ddbfe90b) --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/QosValidator.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Gilad Chaplik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33727 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90b62c4f4499dcc4abec5495a9907102e213df0e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[ovirt-engine-3.5]: engine: boot-protocol for VmInitNetwork
by piotr.kliczewski＠gmail.com 03 Oct '14

03 Oct '14

Piotr Kliczewski has submitted this change and it was merged. Change subject: engine: boot-protocol for VmInitNetwork ...................................................................... engine: boot-protocol for VmInitNetwork Needs to return STATIC instead of STATIC_IP Validate BootProtocol input. Bug-Url: https://bugzilla.redhat.com/1144005 Change-Id: I21f8a9cf509dd4d3d6e73a83ce9f66b183605161 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInitNetwork.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/GuestNicConfigurationValidator.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/VmValidator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 4 files changed, 33 insertions(+), 4 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Shahar Havivi: Verified Omer Frenkel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33721 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I21f8a9cf509dd4d3d6e73a83ce9f66b183605161 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Corrected ownership of the directories
by sbonazzo＠redhat.com 03 Oct '14

03 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: engine: Corrected ownership of the directories ...................................................................... engine: Corrected ownership of the directories Added entries for directories for correct ownership Change-Id: I946b446a908e4189e30fe60946e7946e4be384f7 Bug-Url: https://bugzilla.redhat.com/1104128 Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31136 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I946b446a908e4189e30fe60946e7946e4be384f7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-1.2]: build: ovirt-hosted-engine-setup-1.2.1
by sbonazzo＠redhat.com 03 Oct '14

03 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: ovirt-hosted-engine-setup-1.2.1 ...................................................................... build: ovirt-hosted-engine-setup-1.2.1 Change-Id: I00c599f202a071fb9336271b49216180ce55a66c Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M configure.ac M ovirt-hosted-engine-setup.spec.in 2 files changed, 9 insertions(+), 6 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33748 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00c599f202a071fb9336271b49216180ce55a66c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: ovirt-hosted-engine-setup-1.2 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: reduce autocompleter time in chrome
by awels＠redhat.com 02 Oct '14

02 Oct '14

Alexander Wels has submitted this change and it was merged. Change subject: webadmin: reduce autocompleter time in chrome ...................................................................... webadmin: reduce autocompleter time in chrome - The profiler in chrome was indicating that the autocompleter was taking significant amounts of time during login. This time was taken mostly loading the exception handlers. I modified the code to not throw exceptions during the time of day lookup. Running the profiler in FF didn't seem to be affected by this. Change-Id: I3f9f0e26274caef5745d2adae9d573498ca6cf4c Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseAutoCompleter.java 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Alexander Wels: Verified Vojtech Szocs: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3f9f0e26274caef5745d2adae9d573498ca6cf4c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: restapi: Validate QoS type
by juan.hernandez＠redhat.com 02 Oct '14

02 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Validate QoS type ...................................................................... restapi: Validate QoS type Currently when a QoS is added to a data center we don't validate that the mandatory type is specified. This eventually triggers a NPE when validating the value. To avoid this this patch adds the validation and modifies the type validator so that it won't fail if no type is provided. Change-Id: I90b62c4f4499dcc4abec5495a9907102e213df0e Bug-Url: https://bugzilla.redhat.com/1148773 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendQossResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/QosValidator.java 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Gilad Chaplik: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/33726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I90b62c4f4499dcc4abec5495a9907102e213df0e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: core : Add custom error page for reports
by oourfali＠redhat.com 02 Oct '14

02 Oct '14

Oved Ourfali has submitted this change and it was merged. Change subject: core : Add custom error page for reports ...................................................................... core : Add custom error page for reports Custom error page for reports not installed error message Change-Id: Ic4489ef8a5a7d07734094e3c974fdaa215f44bef Bug-Url: https://bugzilla.redhat.com/1143998 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- A backend/manager/modules/welcome/src/main/webapp/WEB-INF/ReportsNotInstalled.jsp 1 file changed, 43 insertions(+), 0 deletions(-) Approvals: Ravi Nori: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic4489ef8a5a7d07734094e3c974fdaa215f44bef Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-live[ovirt-live-3.5]: build: oVirt Live 3.5.0 RC4
by sbonazzo＠redhat.com 02 Oct '14

02 Oct '14

Sandro Bonazzola has submitted this change and it was merged. Change subject: build: oVirt Live 3.5.0 RC4 ...................................................................... build: oVirt Live 3.5.0 RC4 Change-Id: I9730556d6f2fb54bc29e6e8d156772bec94f3c83 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M centos/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9730556d6f2fb54bc29e6e8d156772bec94f3c83 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-live Gerrit-Branch: ovirt-live-3.5 Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

1 0

Change in ovirt-engine[master]: restapi: Remove redundant condition in NetworkMapper
by juan.hernandez＠redhat.com 02 Oct '14

02 Oct '14

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Remove redundant condition in NetworkMapper ...................................................................... restapi: Remove redundant condition in NetworkMapper Remove redundant condition in NetworkMapper class. Change-Id: I2538941cc544725dcc2f70f5f3ae91a294fe6b2b Signed-off-by: Yevgeny Zaspitsky <yzaspits(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkMapper.java 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Looks good to me, approved Moti Asayag: Looks good to me, but someone else must approve Yevgeny Zaspitsky: Verified -- To view, visit http://gerrit.ovirt.org/33716 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2538941cc544725dcc2f70f5f3ae91a294fe6b2b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-hosted-engine-ha[master]: use vdsm to get the storage domain path
by msivak＠redhat.com 02 Oct '14

02 Oct '14

Martin Sivák has submitted this change and it was merged. Change subject: use vdsm to get the storage domain path ...................................................................... use vdsm to get the storage domain path We used to list all the dirs mounted in /rhev/data-center/mnt to find the path to HE storage domain. This causes problems when there is an ISO domain which is not accessible - the agent gets stuck in blocking I/O until the mounted domain is online again. Change-Id: Ia32197ba888623d34e169d14010802c71625d5ea Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1140824 Signed-off-by: Jiri Moskovcak <jmoskovc(a)redhat.com> --- M ovirt_hosted_engine_ha/env/path.py 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jiří Moskovčák: Verified -- To view, visit http://gerrit.ovirt.org/33725 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia32197ba888623d34e169d14010802c71625d5ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

1 0